[{"id":31066,"web_url":"https://patchwork.libcamera.org/comment/31066/","msgid":"<20240902185539.GI1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:55:39","subject":"Re: [PATCH v3 12/18] libcamera: ipa: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:05PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  include/libcamera/ipa/ipa_interface.h | 5 -----\n>  1 file changed, 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 7c835e98..2fdc085e 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,11 +7,6 @@\n>  \n>  #pragma once\n>  \n> -#include <map>\n> -#include <stddef.h>\n> -#include <stdint.h>\n> -#include <vector>\n> -\n>  #include <libcamera/base/flags.h>\n>  #include <libcamera/base/signal.h>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF56DBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Sep 2024 18:56:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69BBC634E0;\n\tMon,  2 Sep 2024 20:56:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DAA4618FF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Sep 2024 20:56:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98698F89;\n\tMon,  2 Sep 2024 20:55:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HAjDUI50\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725303300;\n\tbh=oy2/lv/dnoBXJ8g5fQBqg4JC5ehg0sHxetjDvSfNQ5E=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HAjDUI50Gd7G4J7KLylhVeiOALEHihv3AaCr7QFHyadabEiMuDM/zkWprCsWaBk+J\n\tHr6h8sTZTHaZ1KNW9nMkHrO6fRM/z/pboTSHWS/LLfCH1ft7qmC/WXuWqSFgbE+cdl\n\tyC/m1tc6BKLnASTWnB4v2G5L3NvzTP6OyZH3972E=","Date":"Mon, 2 Sep 2024 21:55:39 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 12/18] libcamera: ipa: Remove unused includes","Message-ID":"<20240902185539.GI1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-13-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-13-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]