[{"id":31067,"web_url":"https://patchwork.libcamera.org/comment/31067/","msgid":"<20240902192949.GJ1995@pendragon.ideasonboard.com>","date":"2024-09-02T19:29:49","subject":"Re: [PATCH v3 13/18] libcamera: libcamera: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:06PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed. Additionally, add some\n> directly used includes not listed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/base/event_dispatcher_poll.cpp | 2 --\n> src/libcamera/camera.cpp | 2 --\n> src/libcamera/controls.cpp | 1 -\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 -\n> src/libcamera/formats.cpp | 3 ---\n> src/libcamera/ipa_module.cpp | 1 -\n> src/libcamera/ipa_proxy.cpp | 1 -\n> src/libcamera/orientation.cpp | 1 -\n> src/libcamera/pipeline_handler.cpp | 1 -\n> src/libcamera/process.cpp | 1 -\n> src/libcamera/sensor/camera_sensor.cpp | 2 --\n> src/libcamera/shared_mem_object.cpp | 1 -\n> src/libcamera/stream.cpp | 2 --\n> 13 files changed, 19 deletions(-)\n> \n> diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\n> index b737ca7a..194d7bd2 100644\n> --- a/src/libcamera/base/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/base/event_dispatcher_poll.cpp\n> @@ -7,8 +7,6 @@\n> \n> #include \n> \n> -#include \n> -#include \n> #include \n> #include \n> #include \n\nvector should be added\n\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 61925e83..9d1ae696 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -9,7 +9,6 @@\n> \n> #include \n> #include \n> -#include \n\nMissing ios, optional and sstream.\n\n> \n> #include \n> #include \n> @@ -21,7 +20,6 @@\n> \n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_controls.h\"\n> -#include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> #include \"libcamera/internal/request.h\"\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 11d35321..67400797 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -7,7 +7,6 @@\n> \n> #include \n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 006ba9f7..e4f656da 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -8,7 +8,6 @@\n> \n> #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 1d1d9a30..3ee89590 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,9 +7,6 @@\n> \n> #include \"libcamera/internal/formats.h\"\n> \n> -#include \n> -#include \n> -\n> #include \n> #include \n> \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 0756b691..86d88a86 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -8,7 +8,6 @@\n> #include \"libcamera/internal/ipa_module.h\"\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 69975d8f..85004737 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -7,7 +7,6 @@\n> \n> #include \"libcamera/internal/ipa_proxy.h\"\n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> index fd191197..bf960249 100644\n> --- a/src/libcamera/orientation.cpp\n> +++ b/src/libcamera/orientation.cpp\n> @@ -8,7 +8,6 @@\n> #include \n> \n> #include \n> -#include \n> \n> /**\n> * \\file orientation.h\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index b18b6d0b..e5940469 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -22,7 +22,6 @@\n> #include \"libcamera/internal/camera.h\"\n> #include \"libcamera/internal/camera_manager.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> -#include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/request.h\"\n> #include \"libcamera/internal/tracepoints.h\"\n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 86d27b2d..c0f4d49f 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> index c6d7f801..1382081a 100644\n> --- a/src/libcamera/sensor/camera_sensor.cpp\n> +++ b/src/libcamera/sensor/camera_sensor.cpp\n> @@ -10,7 +10,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> @@ -24,7 +23,6 @@\n> #include \"libcamera/internal/bayer_format.h\"\n> #include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor_properties.h\"\n> -#include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/sysfs.h\"\n> \n> /**\n> diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> index d4c7991a..65b53919 100644\n> --- a/src/libcamera/shared_mem_object.cpp\n> +++ b/src/libcamera/shared_mem_object.cpp\n> @@ -10,7 +10,6 @@\n> \n> #include \"libcamera/internal/shared_mem_object.h\"\n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 053cc4b8..e70688f6 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -9,9 +9,7 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> -#include \n\nYou should include ostream.\n\nI'll fix this when applying.\n\nReviewed-by: Laurent Pinchart \n\n> \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2B27C324C\n\tfor ;\n\tMon, 2 Sep 2024 19:30:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7693634CB;\n\tMon, 2 Sep 2024 21:30:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6587618FD\n\tfor ;\n\tMon, 2 Sep 2024 21:30:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2AE954CE;\n\tMon, 2 Sep 2024 21:29:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SqAprnZh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725305351;\n\tbh=uhotajuAHOCYcXUdrY6N5DCm4SHkKmMzg4zaHmV9Gac=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SqAprnZhO/f4JSVqJepNJeVGmH4k+pF1OetrTTqUpAAXzy6hEzt7VNVwVVRLwkxKh\n\tWdfHn9htvLLBzZawlJnaYmafTDAb1gncYClaQocL1V4cYWygkFZRWUw4+rgSfRKuE5\n\tl0OwyLPTh+CfkLlH9BPRPDWv0rpx/mbLy/hAduLE=","Date":"Mon, 2 Sep 2024 22:29:49 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 13/18] libcamera: libcamera: Remove unused includes","Message-ID":"<20240902192949.GJ1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-14-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-14-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31068,"web_url":"https://patchwork.libcamera.org/comment/31068/","msgid":"<20240902193117.GK1995@pendragon.ideasonboard.com>","date":"2024-09-02T19:31:17","subject":"Re: [PATCH v3 13/18] libcamera: libcamera: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 10:29:49PM +0300, Laurent Pinchart wrote:\n> Hi Milan,\n> \n> Thank you for the patch.\n> \n> On Mon, Sep 02, 2024 at 05:42:06PM +0200, Milan Zamazal wrote:\n> > The includes that are not used can be removed. Additionally, add some\n> > directly used includes not listed.\n> > \n> > Signed-off-by: Milan Zamazal \n> > ---\n> > src/libcamera/base/event_dispatcher_poll.cpp | 2 --\n> > src/libcamera/camera.cpp | 2 --\n> > src/libcamera/controls.cpp | 1 -\n> > src/libcamera/converter/converter_v4l2_m2m.cpp | 1 -\n> > src/libcamera/formats.cpp | 3 ---\n> > src/libcamera/ipa_module.cpp | 1 -\n> > src/libcamera/ipa_proxy.cpp | 1 -\n> > src/libcamera/orientation.cpp | 1 -\n> > src/libcamera/pipeline_handler.cpp | 1 -\n> > src/libcamera/process.cpp | 1 -\n> > src/libcamera/sensor/camera_sensor.cpp | 2 --\n> > src/libcamera/shared_mem_object.cpp | 1 -\n> > src/libcamera/stream.cpp | 2 --\n> > 13 files changed, 19 deletions(-)\n> > \n> > diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\n> > index b737ca7a..194d7bd2 100644\n> > --- a/src/libcamera/base/event_dispatcher_poll.cpp\n> > +++ b/src/libcamera/base/event_dispatcher_poll.cpp\n> > @@ -7,8 +7,6 @@\n> > \n> > #include \n> > \n> > -#include \n> > -#include \n> > #include \n> > #include \n> > #include \n> \n> vector should be added\n> \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index 61925e83..9d1ae696 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -9,7 +9,6 @@\n> > \n> > #include \n> > #include \n> > -#include \n> \n> Missing ios, optional and sstream.\n> \n> > \n> > #include \n> > #include \n> > @@ -21,7 +20,6 @@\n> > \n> > #include \"libcamera/internal/camera.h\"\n> > #include \"libcamera/internal/camera_controls.h\"\n> > -#include \"libcamera/internal/formats.h\"\n> > #include \"libcamera/internal/pipeline_handler.h\"\n> > #include \"libcamera/internal/request.h\"\n> > \n> > diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> > index 11d35321..67400797 100644\n> > --- a/src/libcamera/controls.cpp\n> > +++ b/src/libcamera/controls.cpp\n> > @@ -7,7 +7,6 @@\n> > \n> > #include \n> > \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > index 006ba9f7..e4f656da 100644\n> > --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> > @@ -8,7 +8,6 @@\n> > \n> > #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> > \n> > -#include \n> > #include \n> > \n> > #include \n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index 1d1d9a30..3ee89590 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -7,9 +7,6 @@\n> > \n> > #include \"libcamera/internal/formats.h\"\n> > \n> > -#include \n> > -#include \n> > -\n> > #include \n> > #include \n> > \n> > diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> > index 0756b691..86d88a86 100644\n> > --- a/src/libcamera/ipa_module.cpp\n> > +++ b/src/libcamera/ipa_module.cpp\n> > @@ -8,7 +8,6 @@\n> > #include \"libcamera/internal/ipa_module.h\"\n> > \n> > #include \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> > index 69975d8f..85004737 100644\n> > --- a/src/libcamera/ipa_proxy.cpp\n> > +++ b/src/libcamera/ipa_proxy.cpp\n> > @@ -7,7 +7,6 @@\n> > \n> > #include \"libcamera/internal/ipa_proxy.h\"\n> > \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> > index fd191197..bf960249 100644\n> > --- a/src/libcamera/orientation.cpp\n> > +++ b/src/libcamera/orientation.cpp\n> > @@ -8,7 +8,6 @@\n> > #include \n> > \n> > #include \n> > -#include \n> > \n> > /**\n> > * \\file orientation.h\n> > diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> > index b18b6d0b..e5940469 100644\n> > --- a/src/libcamera/pipeline_handler.cpp\n> > +++ b/src/libcamera/pipeline_handler.cpp\n> > @@ -22,7 +22,6 @@\n> > #include \"libcamera/internal/camera.h\"\n> > #include \"libcamera/internal/camera_manager.h\"\n> > #include \"libcamera/internal/device_enumerator.h\"\n> > -#include \"libcamera/internal/framebuffer.h\"\n> > #include \"libcamera/internal/media_device.h\"\n> > #include \"libcamera/internal/request.h\"\n> > #include \"libcamera/internal/tracepoints.h\"\n> > diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> > index 86d27b2d..c0f4d49f 100644\n> > --- a/src/libcamera/process.cpp\n> > +++ b/src/libcamera/process.cpp\n> > @@ -10,7 +10,6 @@\n> > #include \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> > index c6d7f801..1382081a 100644\n> > --- a/src/libcamera/sensor/camera_sensor.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor.cpp\n> > @@ -10,7 +10,6 @@\n> > \n> > #include \n> > #include \n> > -#include \n> > #include \n> > #include \n> > #include \n> > @@ -24,7 +23,6 @@\n> > #include \"libcamera/internal/bayer_format.h\"\n> > #include \"libcamera/internal/camera_lens.h\"\n> > #include \"libcamera/internal/camera_sensor_properties.h\"\n> > -#include \"libcamera/internal/formats.h\"\n> > #include \"libcamera/internal/sysfs.h\"\n> > \n> > /**\n> > diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> > index d4c7991a..65b53919 100644\n> > --- a/src/libcamera/shared_mem_object.cpp\n> > +++ b/src/libcamera/shared_mem_object.cpp\n> > @@ -10,7 +10,6 @@\n> > \n> > #include \"libcamera/internal/shared_mem_object.h\"\n> > \n> > -#include \n> > #include \n> > #include \n> > #include \n> > diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> > index 053cc4b8..e70688f6 100644\n> > --- a/src/libcamera/stream.cpp\n> > +++ b/src/libcamera/stream.cpp\n> > @@ -9,9 +9,7 @@\n> > \n> > #include \n> > #include \n> > -#include \n> > #include \n> > -#include \n> \n> You should include ostream.\n> \n> I'll fix this when applying.\n\nI won't because patch 14/18 does :-)\n\n> Reviewed-by: Laurent Pinchart \n> \n> > \n> > #include \n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19716C324C\n\tfor ;\n\tMon, 2 Sep 2024 19:31:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3216618FF;\n\tMon, 2 Sep 2024 21:31:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54A9E618FD\n\tfor ;\n\tMon, 2 Sep 2024 21:31:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CFF2B4CE;\n\tMon, 2 Sep 2024 21:30:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jq8zKHun\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725305438;\n\tbh=10CkJOx5mKkG7XgUCDpUr5Z/i/UGrYVJpnMNwEABA6Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Jq8zKHun4CwUEGoyOiIYaabOS8ccDIvoXrpOKzkh80GO/kwJfZijhRXM8DcRqxWCf\n\txfp6z7SGwDkgcqw4+qpXC52osaGRprd0q9E07ewa9XYmpwSgYrBu9VD83hkIKGnYl9\n\t3og89IwoCdGOGYBFpZBaA44F9rc2m/SSptpbbdjQ=","Date":"Mon, 2 Sep 2024 22:31:17 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 13/18] libcamera: libcamera: Remove unused includes","Message-ID":"<20240902193117.GK1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-14-mzamazal@redhat.com>\n\t<20240902192949.GJ1995@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902192949.GJ1995@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]