[{"id":31065,"web_url":"https://patchwork.libcamera.org/comment/31065/","msgid":"<20240902185416.GH1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:54:16","subject":"Re: [PATCH v3 10/18] libcamera: v4l2: Fix an include placement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 05:42:03PM +0200, Milan Zamazal wrote:\n> Put the inclusion of geometry.h to the right place.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 6eaa8f01..9f2ec479 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -17,11 +17,11 @@\n> #include \n> #include \n> \n> -#include \n> -\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/media_device.h\"\n> #include \"libcamera/internal/media_object.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6F0CBF415\n\tfor ;\n\tMon, 2 Sep 2024 18:54:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9423763471;\n\tMon, 2 Sep 2024 20:54:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4839C618FF\n\tfor ;\n\tMon, 2 Sep 2024 20:54:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D31D84CE;\n\tMon, 2 Sep 2024 20:53:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WZLHugcl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725303218;\n\tbh=8GhhnwGB4MmJgurY7oBcw0wJwkWfAfWMUDjMF72jaM0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WZLHugcl/YefXlN+wMZpK9hU5bVM1pqlif5rfety/4kIldX6/zk6uJmpG3xRR3p6s\n\tOU7xdaCsupAkzoEpNIAh98opeF9FVWuTsnNNwZ6Cgp+I6WfDMDLONoP+2MGdz3yVyL\n\tpT+Q9/UiK1TsZAd4Bshw445qPnxErgyjtsl1JTdA=","Date":"Mon, 2 Sep 2024 21:54:16 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 10/18] libcamera: v4l2: Fix an include placement","Message-ID":"<20240902185416.GH1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-11-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-11-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]