[{"id":2805,"web_url":"https://patchwork.libcamera.org/comment/2805/","msgid":"<20191006193728.snjx4ybkcluktgdi@uno.localdomain>","date":"2019-10-06T19:37:28","subject":"Re: [libcamera-devel] [PATCH 9/9] test: timer: Test start() with\n\tabsolute deadline","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Oct 06, 2019 at 08:32:26AM +0300, Laurent Pinchart wrote:\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/timer.cpp | 19 +++++++++++++++++++\n> 1 file changed, 19 insertions(+)\n>\n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index 5ff94dbbdeb0..93ce26a0a9a3 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -35,6 +35,15 @@ public:\n> \t\tTimer::start(msec);\n> \t}\n>\n> +\tvoid start(std::chrono::steady_clock::time_point deadline)\n> +\t{\n> +\t\tcount_ = 0;\n> +\t\tstart_ = std::chrono::steady_clock::now();\n> +\t\texpiration_ = std::chrono::steady_clock::time_point();\n> +\n> +\t\tTimer::start(deadline);\n> +\t}\n> +\n> \tint jitter()\n> \t{\n> \t\tstd::chrono::steady_clock::duration duration = expiration_ - deadline();\n> @@ -127,6 +136,16 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n>\n> +\t\t/* Timer with absolute deadline. */\n> +\t\ttimer.start(std::chrono::steady_clock::now() + std::chrono::milliseconds(200));\n> +\n> +\t\tdispatcher->processEvents();\n> +\n> +\t\tif (timer.isRunning() || timer.jitter() > 50) {\n> +\t\t\tcout << \"Absolute timer test failed\" << endl;\n\n\"Absolute timer\" sounds funny.\n\nOtherwise\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\t/* Two timers. */\n> \t\ttimer.start(1000);\n> \t\ttimer2.start(300);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F119060E1E\n\tfor ;\n\tSun, 6 Oct 2019 21:35:43 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 82EAC1C0002;\n\tSun, 6 Oct 2019 19:35:42 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sun, 6 Oct 2019 21:37:28 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191006193728.snjx4ybkcluktgdi@uno.localdomain>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>\n\t<20191006053226.8976-10-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3r6koqijifnjqyrs\"","Content-Disposition":"inline","In-Reply-To":"<20191006053226.8976-10-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 9/9] test: timer: Test start() with\n\tabsolute deadline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Oct 2019 19:35:44 -0000"}},{"id":2813,"web_url":"https://patchwork.libcamera.org/comment/2813/","msgid":"<20191007032008.GK4740@pendragon.ideasonboard.com>","date":"2019-10-07T03:20:08","subject":"Re: [libcamera-devel] [PATCH 9/9] test: timer: Test start() with\n\tabsolute deadline","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Sun, Oct 06, 2019 at 09:37:28PM +0200, Jacopo Mondi wrote:\n> On Sun, Oct 06, 2019 at 08:32:26AM +0300, Laurent Pinchart wrote:\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/timer.cpp | 19 +++++++++++++++++++\n> > 1 file changed, 19 insertions(+)\n> >\n> > diff --git a/test/timer.cpp b/test/timer.cpp\n> > index 5ff94dbbdeb0..93ce26a0a9a3 100644\n> > --- a/test/timer.cpp\n> > +++ b/test/timer.cpp\n> > @@ -35,6 +35,15 @@ public:\n> > \t\tTimer::start(msec);\n> > \t}\n> >\n> > +\tvoid start(std::chrono::steady_clock::time_point deadline)\n> > +\t{\n> > +\t\tcount_ = 0;\n> > +\t\tstart_ = std::chrono::steady_clock::now();\n> > +\t\texpiration_ = std::chrono::steady_clock::time_point();\n> > +\n> > +\t\tTimer::start(deadline);\n> > +\t}\n> > +\n> > \tint jitter()\n> > \t{\n> > \t\tstd::chrono::steady_clock::duration duration = expiration_ - deadline();\n> > @@ -127,6 +136,16 @@ protected:\n> > \t\t\treturn TestFail;\n> > \t\t}\n> >\n> > +\t\t/* Timer with absolute deadline. */\n> > +\t\ttimer.start(std::chrono::steady_clock::now() + std::chrono::milliseconds(200));\n> > +\n> > +\t\tdispatcher->processEvents();\n> > +\n> > +\t\tif (timer.isRunning() || timer.jitter() > 50) {\n> > +\t\t\tcout << \"Absolute timer test failed\" << endl;\n> \n> \"Absolute timer\" sounds funny.\n\nI'll rename that to \"Absolute deadline\".\n\n> Otherwise\n> Reviewed-by: Jacopo Mondi \n> \n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > \t\t/* Two timers. */\n> > \t\ttimer.start(1000);\n> > \t\ttimer2.start(300);","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FF606157C\n\tfor ;\n\tMon, 7 Oct 2019 05:20:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(modemcable151.96-160-184.mc.videotron.ca [184.160.96.151])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23638DD;\n\tMon, 7 Oct 2019 05:20:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570418411;\n\tbh=v7UjAjKou8ZC/wuK2OOzy/PFuAJrSyeVc8tUZyXP2jg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rtEZr00hnnuBcsz6ln1Tk0m8r3vlMNbFaCFCppAO5LBo1ygSI5FwjgNwab8hZYfQi\n\trKnVx2982gVzKGCFF2b6URJ+PpcFNPOnriZjOmd14MUVeaLmTT5BWCowAgFhHaSC1W\n\tOugua7dbbaDHPDjypO1akOtvKDUPWaF/WTEm0EwE=","Date":"Mon, 7 Oct 2019 06:20:08 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191007032008.GK4740@pendragon.ideasonboard.com>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>\n\t<20191006053226.8976-10-laurent.pinchart@ideasonboard.com>\n\t<20191006193728.snjx4ybkcluktgdi@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191006193728.snjx4ybkcluktgdi@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 9/9] test: timer: Test start() with\n\tabsolute deadline","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 07 Oct 2019 03:20:12 -0000"}}]