[{"id":31064,"web_url":"https://patchwork.libcamera.org/comment/31064/","msgid":"<20240902185337.GG1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:53:37","subject":"Re: [PATCH v3 09/18] libcamera: v4l2: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:02PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed. Also, some directly used\n> includes not listed are added.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_device.cpp | 2 --\n> src/libcamera/v4l2_subdevice.cpp | 1 -\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> src/v4l2/v4l2_camera.h | 3 ++-\n> src/v4l2/v4l2_camera_proxy.cpp | 1 -\n> src/v4l2/v4l2_compat.cpp | 1 -\n> src/v4l2/v4l2_compat_manager.cpp | 1 -\n> 7 files changed, 2 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index 4a2048cf..68add4f2 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -8,8 +8,6 @@\n> #include \"libcamera/internal/v4l2_device.h\"\n> \n> #include \n> -#include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 82824433..6eaa8f01 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -8,7 +8,6 @@\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 6f32521f..76742e18 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\n> index 278cc33e..9a0b0455 100644\n> --- a/src/v4l2/v4l2_camera.h\n> +++ b/src/v4l2/v4l2_camera.h\n> @@ -8,7 +8,8 @@\n> #pragma once\n> \n> #include \n> -#include \n> +#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 3f7c00a2..a020a2b0 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -8,7 +8,6 @@\n> #include \"v4l2_camera_proxy.h\"\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/v4l2/v4l2_compat.cpp b/src/v4l2/v4l2_compat.cpp\n> index 6c9dca72..ff833f57 100644\n> --- a/src/v4l2/v4l2_compat.cpp\n> +++ b/src/v4l2/v4l2_compat.cpp\n> @@ -8,7 +8,6 @@\n> #include \"v4l2_compat_manager.h\"\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/v4l2/v4l2_compat_manager.cpp b/src/v4l2/v4l2_compat_manager.cpp\n> index 6a00afb5..f53fb300 100644\n> --- a/src/v4l2/v4l2_compat_manager.cpp\n> +++ b/src/v4l2/v4l2_compat_manager.cpp\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4312CBF415\n\tfor ;\n\tMon, 2 Sep 2024 18:54:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECCD8634E0;\n\tMon, 2 Sep 2024 20:54:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9742A618FF\n\tfor ;\n\tMon, 2 Sep 2024 20:54:10 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FD074CE;\n\tMon, 2 Sep 2024 20:52:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WNILCFQO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725303179;\n\tbh=jQljk7icHkExUaq9YZ8tzpGCg2BVPn8o3vPrJOduzyA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WNILCFQO6O2fHCDfyjvSIHqRrgaBFSMMmu25XhuhWrIR4vA+Yy/wX2YMqQxWHgwsM\n\tI9i6NbskCGRGv++sS45O0YYd1SUNV1wzd2Uz1QHH2ktJxtEbH2uXuPTTIWkrbgeym7\n\tY5wHSjtZBkOWI/uKv02/lfAxJUisWJJG73GldHi8=","Date":"Mon, 2 Sep 2024 21:53:37 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 09/18] libcamera: v4l2: Remove unused includes","Message-ID":"<20240902185337.GG1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-10-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-10-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]