[{"id":31063,"web_url":"https://patchwork.libcamera.org/comment/31063/","msgid":"<20240902185232.GF1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:52:32","subject":"Re: [PATCH v3 08/18] libcamera: uvcvideo: Fix includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 05:42:01PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed and there are also\n> directly used includes not listed. Let's fix both.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index e9faa1a9..6b32fa18 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -7,10 +7,12 @@\n> \n> #include \n> #include \n> -#include \n> +#include \n> #include \n> #include \n> -#include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DF96C324C\n\tfor ;\n\tMon, 2 Sep 2024 18:53:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10A83634E0;\n\tMon, 2 Sep 2024 20:53:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56E18618FF\n\tfor ;\n\tMon, 2 Sep 2024 20:53:05 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D84634CE;\n\tMon, 2 Sep 2024 20:51:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sJkVD/BC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725303114;\n\tbh=DCe2GeNFGKzgfJhtdtanHOP2kmbJWGypXm9vRuxWUOQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sJkVD/BCXch/viTjIF2FUMlvMPjk0E5q4XF/OEFDNd3Y8+5fVe1XQyV+pXPs9QiUl\n\tHhFpwsq4F6UwCwCtCfVgtJVDiKGnEVR4AU2rxvYeTr0Wo1oC+FEaJ/cVX650OxqBAx\n\t8zGaYrpjtuFOZ0vfEK41ZWCe4LnwSQ6uaNtiVIjg=","Date":"Mon, 2 Sep 2024 21:52:32 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 08/18] libcamera: uvcvideo: Fix includes","Message-ID":"<20240902185232.GF1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-9-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-9-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]