[{"id":31062,"web_url":"https://patchwork.libcamera.org/comment/31062/","msgid":"<20240902185052.GE1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:50:52","subject":"Re: [PATCH v3 07/18] libcamera: libipa: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:42:00PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed. And two identified\n> missing includes (directly used but available only through other\n> includes) are added.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/histogram.h | 1 -\n> src/ipa/libipa/matrix.h | 1 -\n> src/ipa/libipa/matrix_interpolator.cpp | 7 -------\n> src/ipa/libipa/matrix_interpolator.h | 2 --\n> src/ipa/libipa/pwl.cpp | 2 --\n> src/ipa/libipa/pwl.h | 3 ---\n> src/ipa/libipa/vector.h | 4 ++--\n> 7 files changed, 2 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 032adca0..6fd64168 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -7,7 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/ipa/libipa/matrix.h b/src/ipa/libipa/matrix.h\n> index 8aa8f343..5471e697 100644\n> --- a/src/ipa/libipa/matrix.h\n> +++ b/src/ipa/libipa/matrix.h\n> @@ -7,7 +7,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/ipa/libipa/matrix_interpolator.cpp b/src/ipa/libipa/matrix_interpolator.cpp\n> index 04ca177f..d5188f8a 100644\n> --- a/src/ipa/libipa/matrix_interpolator.cpp\n> +++ b/src/ipa/libipa/matrix_interpolator.cpp\n> @@ -6,15 +6,8 @@\n> */\n> #include \"matrix_interpolator.h\"\n> \n> -#include \n> -#include \n> -\n> #include \n> \n> -#include \"libcamera/internal/yaml_parser.h\"\n> -\n> -#include \"matrix.h\"\n> -\n> /**\n> * \\file matrix_interpolator.h\n> * \\brief Helper class for interpolating maps of matrices\n> diff --git a/src/ipa/libipa/matrix_interpolator.h b/src/ipa/libipa/matrix_interpolator.h\n> index 087c4fd1..afbce538 100644\n> --- a/src/ipa/libipa/matrix_interpolator.h\n> +++ b/src/ipa/libipa/matrix_interpolator.h\n> @@ -7,10 +7,8 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index 9b213754..88fe2022 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -8,10 +8,8 @@\n> \n> #include \"pwl.h\"\n> \n> -#include \n> #include \n> #include \n> -#include \n> \n> /**\n> * \\file pwl.h\n> diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n> index b6f93494..d4ec9f4f 100644\n> --- a/src/ipa/libipa/pwl.h\n> +++ b/src/ipa/libipa/pwl.h\n> @@ -7,14 +7,11 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> #include \n> \n> -#include \"libcamera/internal/yaml_parser.h\"\n> -\n> #include \"vector.h\"\n> \n> namespace libcamera {\n> diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\n> index 556e0967..8612a06a 100644\n> --- a/src/ipa/libipa/vector.h\n> +++ b/src/ipa/libipa/vector.h\n> @@ -6,10 +6,10 @@\n> */\n> #pragma once\n> \n> -#include \n> #include \n> #include \n> -#include \n> +#include \n> +#include \n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86BACC324C\n\tfor ;\n\tMon, 2 Sep 2024 18:51:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46BD463471;\n\tMon, 2 Sep 2024 20:51:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E36E5618FF\n\tfor ;\n\tMon, 2 Sep 2024 20:51:23 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CB014CE;\n\tMon, 2 Sep 2024 20:50:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qL+ynOl7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725303012;\n\tbh=FfhNoGq34Y1YRlcQbNZv8VWPQVCcm3TsGYn8p6PSnrY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=qL+ynOl73bIkajaon+exvkD6lNVluxzdbVay9JrGySl+BDVLig7blXbWKWGEjCydv\n\tQhj3mQrVH6HuTnrxzkt0beL6Oi7yWz312Ut1vhnxNcXE5/V7kJ+h4/zhYDauP1mCLm\n\tPM99YdktwRTFlBUy7DsRxrXzeiP+8AOobxLMW0OI=","Date":"Mon, 2 Sep 2024 21:50:52 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 07/18] libcamera: libipa: Remove unused includes","Message-ID":"<20240902185052.GE1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-8-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-8-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]