[{"id":31061,"web_url":"https://patchwork.libcamera.org/comment/31061/","msgid":"<20240902184914.GD1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:49:14","subject":"Re: [PATCH v3 06/18] libcamera: rkisp1: Formatting improvements","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 05:41:59PM +0200, Milan Zamazal wrote:\n> The LSP autoformatter doesn't like some of the current formatting, let's\n> make it happier. Note that not all of its suggestions were accepted\n> because readability is preferred and adjusting .clang-format may not be\n> easy or possible.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 3 ++-\n> src/ipa/rkisp1/rkisp1.cpp | 4 ++--\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index c6451719..955a9ff4 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -306,7 +306,8 @@ void Awb::process(IPAContext &context,\n> \tactiveState.awb.gains.automatic.blue = blueGain;\n> \tactiveState.awb.gains.automatic.green = 1.0;\n> \n> -\tLOG(RkISP1Awb, Debug) << std::showpoint\n> +\tLOG(RkISP1Awb, Debug)\n> +\t\t<< std::showpoint\n> \t\t<< \"Means [\" << redMean << \", \" << greenMean << \", \" << blueMean\n> \t\t<< \"], gains [\" << activeState.awb.gains.automatic.red << \", \"\n> \t\t<< activeState.awb.gains.automatic.green << \", \"\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index a62fe151..f164d7c5 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -165,8 +165,8 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n> \t\treturn -ENODEV;\n> \t}\n> \n> -\tcontext_.configuration.sensor.lineDuration = sensorInfo.minLineLength\n> -\t\t\t\t\t\t * 1.0s / sensorInfo.pixelRate;\n> +\tcontext_.configuration.sensor.lineDuration =\n> +\t\tsensorInfo.minLineLength * 1.0s / sensorInfo.pixelRate;\n> \n> \t/* Load the tuning data file. */\n> \tFile file(settings.configurationFile);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62C4DC324C\n\tfor ;\n\tMon, 2 Sep 2024 18:49:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0ADED634E0;\n\tMon, 2 Sep 2024 20:49:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D12E618FD\n\tfor ;\n\tMon, 2 Sep 2024 20:49:47 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF4784CE;\n\tMon, 2 Sep 2024 20:48:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BOc4LN/+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725302915;\n\tbh=PmkQl2NHFsidbOExsjBX8PmQPaOBrtr8GFkER9htuug=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BOc4LN/+xIFII+Rm6zzIbXmjAZYR28Q0gUknWJKqxDszl3Owy7s2NhXFamfwdA0SV\n\tkzh0UmDLPz+gil2lsmleBhNfdMb8gX+mHEyCGrw2cN9oqUfpDrq2cXYyorh9tJp5BH\n\tqM5100RraDIsUgasGiIgEP0vPubhYfMcf/6bNevc=","Date":"Mon, 2 Sep 2024 21:49:14 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 06/18] libcamera: rkisp1: Formatting improvements","Message-ID":"<20240902184914.GD1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-7-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-7-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]