[{"id":31060,"web_url":"https://patchwork.libcamera.org/comment/31060/","msgid":"<20240902183600.GC1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:36:00","subject":"Re: [PATCH v3 05/18] libcamera: rkisp1: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:41:58PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/rkisp1/algorithms/agc.h | 1 -\n> src/ipa/rkisp1/algorithms/awb.cpp | 4 ++--\n> src/ipa/rkisp1/algorithms/ccm.cpp | 6 +-----\n> src/ipa/rkisp1/algorithms/dpf.cpp | 4 +++-\n> src/ipa/rkisp1/rkisp1.cpp | 7 ++++---\n> src/ipa/rkisp1/utils.h | 1 -\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +--\n> 7 files changed, 11 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index d64ff42c..aa86f2c5 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -15,7 +15,6 @@\n> #include \n> \n> #include \"libipa/agc_mean_luminance.h\"\n> -#include \"libipa/histogram.h\"\n> \n> #include \"algorithm.h\"\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b40f405f..c6451719 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -8,12 +8,12 @@\n> #include \"awb.h\"\n> \n> #include \n> -#include \n> -#include \n> +#include \n> \n> #include \n> \n> #include \n> +\n> #include \n> \n> /**\n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index ca80112a..1ca0e73f 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -7,11 +7,7 @@\n> \n> #include \"ccm.h\"\n> \n> -#include \n> -#include \n> -#include \n> -#include \n> -#include \n> +#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index 079cc2c3..cb6095da 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -7,7 +7,9 @@\n> \n> #include \"dpf.h\"\n> \n> -#include \n> +#include \n> +#include \n> +#include \n> \n> #include \n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 79ae9289..a62fe151 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -6,8 +6,8 @@\n> */\n> \n> #include \n> -#include \n> -#include \n> +#include \n> +#include \n> #include \n> #include \n> \n> @@ -19,10 +19,11 @@\n> \n> #include \n> #include \n> +#include \n> +\n> #include \n> #include \n> #include \n> -#include \n> \n> #include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> diff --git a/src/ipa/rkisp1/utils.h b/src/ipa/rkisp1/utils.h\n> index 450f2244..5f38b50b 100644\n> --- a/src/ipa/rkisp1/utils.h\n> +++ b/src/ipa/rkisp1/utils.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> \n> namespace libcamera {\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 710d9573..e521623b 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -6,10 +6,9 @@\n> */\n> \n> #include \n> -#include \n> -#include \n> #include \n> #include \n> +#include \n> #include \n> \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F29CABF415\n\tfor ;\n\tMon, 2 Sep 2024 18:36:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15ECB634E4;\n\tMon, 2 Sep 2024 20:36:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45FB7618FD\n\tfor ;\n\tMon, 2 Sep 2024 20:36:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA7704CE;\n\tMon, 2 Sep 2024 20:35:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hDkzJnYY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725302122;\n\tbh=EJcrtZ3a6PKxIy7thYkXPOFD0wGrIFkuTHkGM6HqsFk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hDkzJnYYwyjhvS3FgCMptT1BuuScKP3hXSdnYFyG3VYNyoe5Zj97IK6ful6aBQ+4b\n\tHdBUrUbJhWuVKGUmcbN2SdJ1IGeqS7c9XSdSEqIXK76yvmJhh66vinjMGOFMH3PUND\n\tvK6mhAqt9qEypg7z6kDu9OEaPqrm0F8vvekLgtlw=","Date":"Mon, 2 Sep 2024 21:36:00 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 05/18] libcamera: rkisp1: Remove unused includes","Message-ID":"<20240902183600.GC1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-6-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-6-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]