[{"id":31058,"web_url":"https://patchwork.libcamera.org/comment/31058/","msgid":"<20240902183149.GA1995@pendragon.ideasonboard.com>","date":"2024-09-02T18:31:49","subject":"Re: [PATCH v3 03/18] libcamera: ipu3: Replace wrong include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2024 at 05:41:56PM +0200, Milan Zamazal wrote:\n> v4l2_videodevice.h is not used but logging is imported through it.\n> Remove the unused include and include log.h instead.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/frames.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n> index 88eb9d05..bc0526a7 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n> @@ -7,12 +7,13 @@\n> \n> #include \"frames.h\"\n> \n> +#include \n> +\n> #include \n> #include \n> \n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/pipeline_handler.h\"\n> -#include \"libcamera/internal/v4l2_videodevice.h\"\n> \n> namespace libcamera {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 20200C324C\n\tfor ;\n\tMon, 2 Sep 2024 18:32:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9849634CB;\n\tMon, 2 Sep 2024 20:32:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D578618FD\n\tfor ;\n\tMon, 2 Sep 2024 20:32:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88D004CE;\n\tMon, 2 Sep 2024 20:31:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n220LtZy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725301870;\n\tbh=FkCQkRkryPAJlvEjj/uMQRl0nOdAhDPR6tm8xD/48QU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n220LtZyRwF+1Ep7UavdS472Q1GqOTsi1WA8ipq+BQuI8RbBvWzJ9d9M67G9uGpvn\n\tRTsK3EmKoIIMhFOUGahYhiFL/F+EiAMfvPBY/vTAImJ6li9nQUt3T8OdahcQ2s0lm3\n\tUq2wykaZ/525guRBHDPiLxpn3ZYXrbtpWLZPYaAQ=","Date":"Mon, 2 Sep 2024 21:31:49 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 03/18] libcamera: ipu3: Replace wrong include","Message-ID":"<20240902183149.GA1995@pendragon.ideasonboard.com>","References":"<20240902154212.1281257-1-mzamazal@redhat.com>\n\t<20240902154212.1281257-4-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240902154212.1281257-4-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]