{"id":21129,"url":"https://patchwork.libcamera.org/api/patches/21129/?format=json","web_url":"https://patchwork.libcamera.org/patch/21129/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240831190511.128151-1-robert.mader@collabora.com>","date":"2024-08-31T19:05:11","name":"libcamera: debayer_cpu: Sync output buffer","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"21ae42bff2637b52e8e2116976498a77d494f542","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21129/mbox/","series":[{"id":4555,"url":"https://patchwork.libcamera.org/api/series/4555/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4555","date":"2024-08-31T19:05:11","name":"libcamera: debayer_cpu: Sync output buffer","version":1,"mbox":"https://patchwork.libcamera.org/series/4555/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21129/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21129/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":["parsemail@patchwork.libcamera.org","robert.mader@collabora.com"],"Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 280B6C324C\n\tfor ;\n\tSat, 31 Aug 2024 19:05:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E4E9E634A6;\n\tSat, 31 Aug 2024 21:05:21 +0200 (CEST)","from sender4-op-o10.zoho.com (sender4-op-o10.zoho.com\n\t[136.143.188.10])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A5B96345D\n\tfor ;\n\tSat, 31 Aug 2024 21:05:20 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1725131115907906.7921780898891;\n\tSat, 31 Aug 2024 12:05:15 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"SIeQ4Jkm\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1725131117; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=IhAlkPMGH2StUY9HrN0eb+tXNCnrsk8xirdMq7C9IuSegH+Zm4VpXcg+xzr5sJknxBDiPkG9VPjkq4bTbGbw+TETWFGfkJcdffSrposU0dgiKmZ+Osni1UVmXiRgT15/VBdfs7qzSBvWOBlCBrdHK4fVtlD7umI8Idr+igqfUGk=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1725131117;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=jT/ibiwe89QiZJuc3fBwZcESm8chbR2WdGDJRxF1muY=; \n\tb=EDpAu2qSSsEG8LPb79b4ujs2uYzTXTTWmPn3CSqKo3Ns59hYzUgJpyJ/bKWFR2pWyhp/qzMZdBLWGIyTCV6ylfhZaAN21/KTiAYlEarpsQMXD+5TAciwoK2xdSCnhw83qOSe/Y47ZPcFIYhl8fvkRujVJ/bzIipQL4bl+dk+kN8=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1725131117;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=jT/ibiwe89QiZJuc3fBwZcESm8chbR2WdGDJRxF1muY=;\n\tb=SIeQ4Jkmj/SDTmGjJt49scgXaX8hAMARH9y0gUNzFQX73aa09hZjcDi5VxhF8h6x\n\t2E3hW4tjalAlBz/jQ3Ml7CbQz63yTnXd8kPwn3hndfX7TOCHEVgUAlyB/b1qkeRIk7Z\n\tHJIMtDGHvwnwXj+d7WThYCT8Y65fnITvKVtcye50=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ","Subject":"[PATCH] libcamera: debayer_cpu: Sync output buffer","Date":"Sat, 31 Aug 2024 21:05:11 +0200","Message-ID":"<20240831190511.128151-1-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.46.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Using `DMA_BUF_IOCTL_SYNC` is required for dmabufs in order to ensure\ncorrect results. Not doing so currently results in occasional tearing\nand/or backlashes in GL/VK clients that use the buffers directly for\nrendering.\n\nSigned-off-by: Robert Mader \n---\n src/libcamera/software_isp/debayer_cpu.cpp | 22 ++++++++++++++++++++++\n 1 file changed, 22 insertions(+)","diff":"diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 077f7f4b..6c953b03 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -11,7 +11,9 @@\n \n #include \"debayer_cpu.h\"\n \n+#include \n #include \n+#include \n #include \n \n #include \n@@ -733,6 +735,16 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \t\tclock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime);\n \t}\n \n+\tfor (const FrameBuffer::Plane &plane : output->planes()) {\n+\t\tconst int fd = plane.fd.get();\n+\t\tstruct dma_buf_sync sync = { DMA_BUF_SYNC_START };\n+\n+\t\tsync.flags |= DMA_BUF_SYNC_WRITE;\n+\n+\t\tif (ioctl (fd, DMA_BUF_IOCTL_SYNC, &sync) < 0)\n+\t\t\tLOG(Debayer, Error) << \"Syncing buffer FD \" << fd << \"failed: \" << errno;\n+\t}\n+\n \tgreen_ = params.green;\n \tred_ = swapRedBlueGains_ ? params.blue : params.red;\n \tblue_ = swapRedBlueGains_ ? params.red : params.blue;\n@@ -760,6 +772,16 @@ void DebayerCpu::process(FrameBuffer *input, FrameBuffer *output, DebayerParams\n \n \tmetadata.planes()[0].bytesused = out.planes()[0].size();\n \n+\tfor (const FrameBuffer::Plane &plane : output->planes()) {\n+\t\tconst int fd = plane.fd.get();\n+\t\tstruct dma_buf_sync sync = { DMA_BUF_SYNC_END };\n+\n+\t\tsync.flags |= DMA_BUF_SYNC_WRITE;\n+\n+\t\tif (ioctl (fd, DMA_BUF_IOCTL_SYNC, &sync) < 0)\n+\t\t\tLOG(Debayer, Error) << \"Syncing buffer FD \" << fd << \"failed: \" << errno;\n+\t}\n+\n \t/* Measure before emitting signals */\n \tif (measuredFrames_ < DebayerCpu::kLastFrameToMeasure &&\n \t ++measuredFrames_ > DebayerCpu::kFramesToSkip) {\n","prefixes":[]}