[{"id":31016,"web_url":"https://patchwork.libcamera.org/comment/31016/","msgid":"<20240831004414.GS3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:44:14","subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2024 at 05:27:16PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> include/libcamera/base/event_dispatcher.h | 2 --\n> include/libcamera/base/log.h | 1 -\n> include/libcamera/base/memfd.h | 2 --\n> include/libcamera/base/signal.h | 1 -\n> include/libcamera/base/span.h | 1 -\n> include/libcamera/base/timer.h | 1 -\n> include/libcamera/base/utils.h | 1 -\n> include/libcamera/framebuffer.h | 1 -\n> include/libcamera/internal/camera_manager.h | 1 -\n> include/libcamera/internal/camera_sensor.h | 1 -\n> include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n> include/libcamera/internal/dma_buf_allocator.h | 2 --\n> include/libcamera/internal/formats.h | 1 -\n> include/libcamera/internal/ipa_data_serializer.h | 4 ----\n> include/libcamera/internal/ipa_proxy.h | 2 --\n> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n> include/libcamera/internal/media_device.h | 1 -\n> include/libcamera/internal/pipeline_handler.h | 3 ---\n> include/libcamera/internal/shared_mem_object.h | 1 -\n> include/libcamera/pixel_format.h | 1 -\n> include/libcamera/request.h | 1 -\n> include/libcamera/stream.h | 1 -\n> include/libcamera/transform.h | 2 --\n> 23 files changed, 33 deletions(-)\n> \n> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n> index e9a09c6e..408f8da6 100644\n> --- a/include/libcamera/base/event_dispatcher.h\n> +++ b/include/libcamera/base/event_dispatcher.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> #include \n> \n> namespace libcamera {\n> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> index df27df03..62093012 100644\n> --- a/include/libcamera/base/log.h\n> +++ b/include/libcamera/base/log.h\n> @@ -7,7 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> \n> #include \n> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> index b0edd2de..705d9929 100644\n> --- a/include/libcamera/base/memfd.h\n> +++ b/include/libcamera/base/memfd.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -\n\nDon't we need this for size_t ?\n\n> #include \n> #include \n> \n> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> index 849fbbda..bbff1495 100644\n> --- a/include/libcamera/base/signal.h\n> +++ b/include/libcamera/base/signal.h\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n> index c3e63f69..92cce4f0 100644\n> --- a/include/libcamera/base/span.h\n> +++ b/include/libcamera/base/span.h\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n\nSame.\n\n> #include \n> \n> namespace libcamera {\n> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n> index 5ef45959..9646a0fe 100644\n> --- a/include/libcamera/base/timer.h\n> +++ b/include/libcamera/base/timer.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> index 734ff81e..98c683a7 100644\n> --- a/include/libcamera/base/utils.h\n> +++ b/include/libcamera/base/utils.h\n> @@ -10,7 +10,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> index 5ae2270b..ff839243 100644\n> --- a/include/libcamera/framebuffer.h\n> +++ b/include/libcamera/framebuffer.h\n> @@ -7,7 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> index e098cb69..0150ca61 100644\n> --- a/include/libcamera/internal/camera_manager.h\n> +++ b/include/libcamera/internal/camera_manager.h\n> @@ -9,7 +9,6 @@\n> \n> #include \n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index fc44ab98..a42c15fa 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -23,7 +23,6 @@\n> #include \n> \n> #include \"libcamera/internal/bayer_format.h\"\n> -#include \"libcamera/internal/formats.h\"\n> #include \"libcamera/internal/v4l2_subdevice.h\"\n> \n> namespace libcamera {\n> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h b/include/libcamera/internal/device_enumerator_sysfs.h\n> index a5bfc711..4ccc9845 100644\n> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n> @@ -7,7 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> \n> #include \"libcamera/internal/device_enumerator.h\"\n> diff --git a/include/libcamera/internal/dma_buf_allocator.h b/include/libcamera/internal/dma_buf_allocator.h\n> index 36ec1696..d2a0a0d1 100644\n> --- a/include/libcamera/internal/dma_buf_allocator.h\n> +++ b/include/libcamera/internal/dma_buf_allocator.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -\n\nNeeded for size_t too ?\n\n> #include \n> #include \n> \n> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> index 71895cd8..6a3e9c16 100644\n> --- a/include/libcamera/internal/formats.h\n> +++ b/include/libcamera/internal/formats.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> \n> #include \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 337c948c..13470a89 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> #include \n> #include \n> #include \n> @@ -22,8 +20,6 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/byte_stream_buffer.h\"\n> -#include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/control_serializer.h\"\n> \n> namespace libcamera {\n> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> index 0f564d99..983bcc5f 100644\n> --- a/include/libcamera/internal/ipa_proxy.h\n> +++ b/include/libcamera/internal/ipa_proxy.h\n> @@ -7,9 +7,7 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> index 4a0f6d57..8c972613 100644\n> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> @@ -9,7 +9,6 @@\n> \n> #include \n> #include \n> -#include \n> \n> #include \"libcamera/internal/ipc_pipe.h\"\n> #include \"libcamera/internal/ipc_unixsocket.h\"\n> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> index bf2e475d..e412d3a0 100644\n> --- a/include/libcamera/internal/media_device.h\n> +++ b/include/libcamera/internal/media_device.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index cad5812f..c37e6d02 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -9,7 +9,6 @@\n> \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> @@ -20,8 +19,6 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/ipa_proxy.h\"\n> -\n> namespace libcamera {\n> \n> class Camera;\n> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> index 2ab0189f..e9f1dacd 100644\n> --- a/include/libcamera/internal/shared_mem_object.h\n> +++ b/include/libcamera/internal/shared_mem_object.h\n> @@ -8,7 +8,6 @@\n> */\n> #pragma once\n> \n> -#include \n\nsize_t too.\n\n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> index ea60fe72..1b4d8c7c 100644\n> --- a/include/libcamera/pixel_format.h\n> +++ b/include/libcamera/pixel_format.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 2c78d9bb..e214a9d1 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -12,7 +12,6 @@\n> #include \n> #include \n> #include \n> -#include \n> \n> #include \n> #include \n> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> index d510238a..071b7169 100644\n> --- a/include/libcamera/stream.h\n> +++ b/include/libcamera/stream.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n> index a88f809e..4517412a 100644\n> --- a/include/libcamera/transform.h\n> +++ b/include/libcamera/transform.h\n> @@ -7,8 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> namespace libcamera {\n> \n> enum class Orientation;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE3CEC323E\n\tfor ;\n\tSat, 31 Aug 2024 00:44:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D99C63469;\n\tSat, 31 Aug 2024 02:44:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C6E8618FF\n\tfor ;\n\tSat, 31 Aug 2024 02:44:46 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50C3D74C;\n\tSat, 31 Aug 2024 02:43:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pI7zWPwM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725065016;\n\tbh=ggdnJt1s5YECQ72iSdJSUjKCMl7FOg5pPwM366OJaJw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pI7zWPwMPwEZMx197g+F22+bTshiTn4wOxQmLgR++LreQG2eLNMX4aYHv6vgJYXDn\n\tmcMAlZDe2EFKgtHQJtnE6dhW2ylEA8T+KRo2dOUqQSskOktCl+K/XwQEeVI4/n2IW4\n\tIZbnrYxY/VoAkyqvJEUQyHA/V423jFyv/yoKyUBo=","Date":"Sat, 31 Aug 2024 03:44:14 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","Message-ID":"<20240831004414.GS3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-20-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-20-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31049,"web_url":"https://patchwork.libcamera.org/comment/31049/","msgid":"<871q22uosc.fsf@redhat.com>","date":"2024-09-02T14:13:23","subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart writes:\n\n> Hi Milan,\n>\n> Thank you for the patch.\n>\n> On Fri, Aug 30, 2024 at 05:27:16PM +0200, Milan Zamazal wrote:\n>> The includes that are not used can be removed.\n>> \n>> Signed-off-by: Milan Zamazal \n>> ---\n>> include/libcamera/base/event_dispatcher.h | 2 --\n>> include/libcamera/base/log.h | 1 -\n>> include/libcamera/base/memfd.h | 2 --\n>> include/libcamera/base/signal.h | 1 -\n>> include/libcamera/base/span.h | 1 -\n>> include/libcamera/base/timer.h | 1 -\n>> include/libcamera/base/utils.h | 1 -\n>> include/libcamera/framebuffer.h | 1 -\n>> include/libcamera/internal/camera_manager.h | 1 -\n>> include/libcamera/internal/camera_sensor.h | 1 -\n>> include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n>> include/libcamera/internal/dma_buf_allocator.h | 2 --\n>> include/libcamera/internal/formats.h | 1 -\n>> include/libcamera/internal/ipa_data_serializer.h | 4 ----\n>> include/libcamera/internal/ipa_proxy.h | 2 --\n>> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n>> include/libcamera/internal/media_device.h | 1 -\n>> include/libcamera/internal/pipeline_handler.h | 3 ---\n>> include/libcamera/internal/shared_mem_object.h | 1 -\n>> include/libcamera/pixel_format.h | 1 -\n>> include/libcamera/request.h | 1 -\n>> include/libcamera/stream.h | 1 -\n>> include/libcamera/transform.h | 2 --\n>> 23 files changed, 33 deletions(-)\n>> \n>> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n>> index e9a09c6e..408f8da6 100644\n>> --- a/include/libcamera/base/event_dispatcher.h\n>> +++ b/include/libcamera/base/event_dispatcher.h\n>> @@ -7,8 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -\n>> #include \n>> \n>> namespace libcamera {\n>> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n>> index df27df03..62093012 100644\n>> --- a/include/libcamera/base/log.h\n>> +++ b/include/libcamera/base/log.h\n>> @@ -7,7 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> #include \n>> \n>> #include \n>> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n>> index b0edd2de..705d9929 100644\n>> --- a/include/libcamera/base/memfd.h\n>> +++ b/include/libcamera/base/memfd.h\n>> @@ -7,8 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -\n>\n> Don't we need this for size_t ?\n\nIt would work for size_t but not for std::size_t. The latter is\nincluded in several header files, including , but C++ only.\nlibcamera permits only , which includes std::size_t too, but only\nindirectly; it would be nonsense to import std::size_t this way.\n\nI'm not sure what's the best to do here. I'd say nothing -- std::size_t\nis so ubiquitous that it is included some way via almost any C++ header\nfile. If we would like to be 100% clean then I think or\n should be included but then checkstyle.py had to be modified\nto permit that.\n\nIn any case, including is truly redundant here.\n\n>> #include \n>> #include \n>> \n>> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n>> index 849fbbda..bbff1495 100644\n>> --- a/include/libcamera/base/signal.h\n>> +++ b/include/libcamera/base/signal.h\n>> @@ -10,7 +10,6 @@\n>> #include \n>> #include \n>> #include \n>> -#include \n>> \n>> #include \n>> \n>> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n>> index c3e63f69..92cce4f0 100644\n>> --- a/include/libcamera/base/span.h\n>> +++ b/include/libcamera/base/span.h\n>> @@ -10,7 +10,6 @@\n>> #include \n>> #include \n>> #include \n>> -#include \n>\n> Same.\n>\n>> #include \n>> \n>> namespace libcamera {\n>> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n>> index 5ef45959..9646a0fe 100644\n>> --- a/include/libcamera/base/timer.h\n>> +++ b/include/libcamera/base/timer.h\n>> @@ -8,7 +8,6 @@\n>> #pragma once\n>> \n>> #include \n>> -#include \n>> \n>> #include \n>> \n>> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n>> index 734ff81e..98c683a7 100644\n>> --- a/include/libcamera/base/utils.h\n>> +++ b/include/libcamera/base/utils.h\n>> @@ -10,7 +10,6 @@\n>> #include \n>> #include \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n>> index 5ae2270b..ff839243 100644\n>> --- a/include/libcamera/framebuffer.h\n>> +++ b/include/libcamera/framebuffer.h\n>> @@ -7,7 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n>> index e098cb69..0150ca61 100644\n>> --- a/include/libcamera/internal/camera_manager.h\n>> +++ b/include/libcamera/internal/camera_manager.h\n>> @@ -9,7 +9,6 @@\n>> \n>> #include \n>> \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n>> index fc44ab98..a42c15fa 100644\n>> --- a/include/libcamera/internal/camera_sensor.h\n>> +++ b/include/libcamera/internal/camera_sensor.h\n>> @@ -23,7 +23,6 @@\n>> #include \n>> \n>> #include \"libcamera/internal/bayer_format.h\"\n>> -#include \"libcamera/internal/formats.h\"\n>> #include \"libcamera/internal/v4l2_subdevice.h\"\n>> \n>> namespace libcamera {\n>> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h\n>> b/include/libcamera/internal/device_enumerator_sysfs.h\n>> index a5bfc711..4ccc9845 100644\n>> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n>> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n>> @@ -7,7 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> #include \n>> \n>> #include \"libcamera/internal/device_enumerator.h\"\n>> diff --git a/include/libcamera/internal/dma_buf_allocator.h\n>> b/include/libcamera/internal/dma_buf_allocator.h\n>> index 36ec1696..d2a0a0d1 100644\n>> --- a/include/libcamera/internal/dma_buf_allocator.h\n>> +++ b/include/libcamera/internal/dma_buf_allocator.h\n>> @@ -7,8 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -\n>\n> Needed for size_t too ?\n>\n>> #include \n>> #include \n>> \n>> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n>> index 71895cd8..6a3e9c16 100644\n>> --- a/include/libcamera/internal/formats.h\n>> +++ b/include/libcamera/internal/formats.h\n>> @@ -8,7 +8,6 @@\n>> #pragma once\n>> \n>> #include \n>> -#include \n>> #include \n>> \n>> #include \n>> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n>> index 337c948c..13470a89 100644\n>> --- a/include/libcamera/internal/ipa_data_serializer.h\n>> +++ b/include/libcamera/internal/ipa_data_serializer.h\n>> @@ -7,8 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> @@ -22,8 +20,6 @@\n>> #include \n>> #include \n>> \n>> -#include \"libcamera/internal/byte_stream_buffer.h\"\n>> -#include \"libcamera/internal/camera_sensor.h\"\n>> #include \"libcamera/internal/control_serializer.h\"\n>> \n>> namespace libcamera {\n>> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n>> index 0f564d99..983bcc5f 100644\n>> --- a/include/libcamera/internal/ipa_proxy.h\n>> +++ b/include/libcamera/internal/ipa_proxy.h\n>> @@ -7,9 +7,7 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> #include \n>> -#include \n>> \n>> #include \n>> \n>> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> index 4a0f6d57..8c972613 100644\n>> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> @@ -9,7 +9,6 @@\n>> \n>> #include \n>> #include \n>> -#include \n>> \n>> #include \"libcamera/internal/ipc_pipe.h\"\n>> #include \"libcamera/internal/ipc_unixsocket.h\"\n>> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n>> index bf2e475d..e412d3a0 100644\n>> --- a/include/libcamera/internal/media_device.h\n>> +++ b/include/libcamera/internal/media_device.h\n>> @@ -8,7 +8,6 @@\n>> #pragma once\n>> \n>> #include \n>> -#include \n>> #include \n>> #include \n>> \n>> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n>> index cad5812f..c37e6d02 100644\n>> --- a/include/libcamera/internal/pipeline_handler.h\n>> +++ b/include/libcamera/internal/pipeline_handler.h\n>> @@ -9,7 +9,6 @@\n>> \n>> #include \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> @@ -20,8 +19,6 @@\n>> #include \n>> #include \n>> \n>> -#include \"libcamera/internal/ipa_proxy.h\"\n>> -\n>> namespace libcamera {\n>> \n>> class Camera;\n>> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n>> index 2ab0189f..e9f1dacd 100644\n>> --- a/include/libcamera/internal/shared_mem_object.h\n>> +++ b/include/libcamera/internal/shared_mem_object.h\n>> @@ -8,7 +8,6 @@\n>> */\n>> #pragma once\n>> \n>> -#include \n>\n> size_t too.\n>\n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n>> index ea60fe72..1b4d8c7c 100644\n>> --- a/include/libcamera/pixel_format.h\n>> +++ b/include/libcamera/pixel_format.h\n>> @@ -8,7 +8,6 @@\n>> #pragma once\n>> \n>> #include \n>> -#include \n>> #include \n>> #include \n>> \n>> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n>> index 2c78d9bb..e214a9d1 100644\n>> --- a/include/libcamera/request.h\n>> +++ b/include/libcamera/request.h\n>> @@ -12,7 +12,6 @@\n>> #include \n>> #include \n>> #include \n>> -#include \n>> \n>> #include \n>> #include \n>> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n>> index d510238a..071b7169 100644\n>> --- a/include/libcamera/stream.h\n>> +++ b/include/libcamera/stream.h\n>> @@ -8,7 +8,6 @@\n>> #pragma once\n>> \n>> #include \n>> -#include \n>> #include \n>> #include \n>> #include \n>> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n>> index a88f809e..4517412a 100644\n>> --- a/include/libcamera/transform.h\n>> +++ b/include/libcamera/transform.h\n>> @@ -7,8 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -\n>> namespace libcamera {\n>> \n>> enum class Orientation;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F81CBF415\n\tfor ;\n\tMon, 2 Sep 2024 14:13:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3672B618FF;\n\tMon, 2 Sep 2024 16:13:33 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8033618FD\n\tfor ;\n\tMon, 2 Sep 2024 16:13:30 +0200 (CEST)","from mail-ed1-f71.google.com (mail-ed1-f71.google.com\n\t[209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-670-gIliK-15M7OpZtNi9TlFCg-1; Mon, 02 Sep 2024 10:13:27 -0400","by mail-ed1-f71.google.com with SMTP id\n\t4fb4d7f45d1cf-5c25e0a50bfso773571a12.0\n\tfor ;\n\tMon, 02 Sep 2024 07:13:27 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a89891d698bsm575464566b.145.2024.09.02.07.13.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Sep 2024 07:13:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Sx6zajsH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725286409;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=sPk4PAO4aoJfRnesRQQgcPbSkdoJ0sOyfr+pCAmlIkQ=;\n\tb=Sx6zajsHFKAA3r5eToRLOSTyCUde5uGu84iMUlSP7u7UFl6oJ4pIUsNhkSZabFHpaIOgKs\n\tX2GoHpG3+/3vgme+FtGp2pxGFa1CjaXelv0twtrqJxf8g3Tkf0Q5AumO13OI60BVKfsk+F\n\t9oz5sC1iKYJl7Fp4go/3d8fhLxqlCtU=","X-MC-Unique":"gIliK-15M7OpZtNi9TlFCg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725286406; x=1725891206;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=sPk4PAO4aoJfRnesRQQgcPbSkdoJ0sOyfr+pCAmlIkQ=;\n\tb=FIiMT385dPQpgmi7CQTkgdcYVAsyOvQ4USNLPa1KVcx4Wy4T3vgjhr/39Dpa0G/4J9\n\ttRwTtHXWR37j7cEo7qOGpIyGAyS6dyV3uICVIRzdVu1PzXObRdtdbzUnj/8RD7ojgeXO\n\twKAOE4U7iKZKtcQaAKcicipToL1tFMsmmYcDWaunGMaUaFI9ChLBJHhl9o4FQdrqsz+0\n\tureNDhDOjH5D5BZ9MRGel32tZpvCYbSSP31eR1UgUbLyC2mK8TlqJxW+s9cJXrYGDLur\n\tKwmV3RUFq4Wh4vZBrlnRa+WYZpic9aujNJ1vgiqt17V7EELpFtQLElff5p7bBzxO5Es0\n\tIecw==","X-Gm-Message-State":"AOJu0Yxs92FMs1ZaR5Yz1z3p5wkrZWgec6DV7VIlA6+5egTl4UczXMq2\n\tjmbSnWmen9MNcCscuOaR8iGcIqPOCnE9N8fnC38gGygoWSbM6tC3GNFtnkFetga2WbUv3rF1Dws\n\tXYylPppwmDS7KE5QuTpEHLyHut5DxTbo0T0Ir6iYPwm2smslUAmtwn9ehODfunIVpcPk4R7PPSX\n\tzKXw/sDpSmXi4tAJwBo8djj4PiuBLWALhVqh+bBZudg6a87Zbx89hMInU=","X-Received":["by 2002:a17:907:7b95:b0:a7a:b070:92c6 with SMTP id\n\ta640c23a62f3a-a89faf98528mr307521166b.50.1725286406026; \n\tMon, 02 Sep 2024 07:13:26 -0700 (PDT)","by 2002:a17:907:7b95:b0:a7a:b070:92c6 with SMTP id\n\ta640c23a62f3a-a89faf98528mr307518566b.50.1725286405440; \n\tMon, 02 Sep 2024 07:13:25 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGSOpQHWD0Fg7P3JM+2EhFeFmmFbFNLkuqb+5+jkTuGMeQFjWJJyVtfWZRIObyh3U8ITlqTRA==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","In-Reply-To":"<20240831004414.GS3811@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Sat, 31 Aug 2024 03:44:14 +0300\")","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-20-mzamazal@redhat.com>\n\t<20240831004414.GS3811@pendragon.ideasonboard.com>","Date":"Mon, 02 Sep 2024 16:13:23 +0200","Message-ID":"<871q22uosc.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31053,"web_url":"https://patchwork.libcamera.org/comment/31053/","msgid":"<20240902144426.GI4313@pendragon.ideasonboard.com>","date":"2024-09-02T14:44:26","subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nOn Mon, Sep 02, 2024 at 04:13:23PM +0200, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> > On Fri, Aug 30, 2024 at 05:27:16PM +0200, Milan Zamazal wrote:\n> >> The includes that are not used can be removed.\n> >> \n> >> Signed-off-by: Milan Zamazal \n> >> ---\n> >> include/libcamera/base/event_dispatcher.h | 2 --\n> >> include/libcamera/base/log.h | 1 -\n> >> include/libcamera/base/memfd.h | 2 --\n> >> include/libcamera/base/signal.h | 1 -\n> >> include/libcamera/base/span.h | 1 -\n> >> include/libcamera/base/timer.h | 1 -\n> >> include/libcamera/base/utils.h | 1 -\n> >> include/libcamera/framebuffer.h | 1 -\n> >> include/libcamera/internal/camera_manager.h | 1 -\n> >> include/libcamera/internal/camera_sensor.h | 1 -\n> >> include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n> >> include/libcamera/internal/dma_buf_allocator.h | 2 --\n> >> include/libcamera/internal/formats.h | 1 -\n> >> include/libcamera/internal/ipa_data_serializer.h | 4 ----\n> >> include/libcamera/internal/ipa_proxy.h | 2 --\n> >> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n> >> include/libcamera/internal/media_device.h | 1 -\n> >> include/libcamera/internal/pipeline_handler.h | 3 ---\n> >> include/libcamera/internal/shared_mem_object.h | 1 -\n> >> include/libcamera/pixel_format.h | 1 -\n> >> include/libcamera/request.h | 1 -\n> >> include/libcamera/stream.h | 1 -\n> >> include/libcamera/transform.h | 2 --\n> >> 23 files changed, 33 deletions(-)\n> >> \n> >> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n> >> index e9a09c6e..408f8da6 100644\n> >> --- a/include/libcamera/base/event_dispatcher.h\n> >> +++ b/include/libcamera/base/event_dispatcher.h\n> >> @@ -7,8 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -\n> >> #include \n> >> \n> >> namespace libcamera {\n> >> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> >> index df27df03..62093012 100644\n> >> --- a/include/libcamera/base/log.h\n> >> +++ b/include/libcamera/base/log.h\n> >> @@ -7,7 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> #include \n> >> \n> >> #include \n> >> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> >> index b0edd2de..705d9929 100644\n> >> --- a/include/libcamera/base/memfd.h\n> >> +++ b/include/libcamera/base/memfd.h\n> >> @@ -7,8 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -\n> >\n> > Don't we need this for size_t ?\n> \n> It would work for size_t but not for std::size_t. The latter is\n> included in several header files, including , but C++ only.\n> libcamera permits only , which includes std::size_t too, but only\n> indirectly; it would be nonsense to import std::size_t this way.\n> \n> I'm not sure what's the best to do here. I'd say nothing -- std::size_t\n> is so ubiquitous that it is included some way via almost any C++ header\n> file. If we would like to be 100% clean then I think or\n> should be included but then checkstyle.py had to be modified\n> to permit that.\n> \n> In any case, including is truly redundant here.\n\nstddef.h is required to provide ::size_t and may provide std::size_t.\ncstddef is required to provide std::size_t and may provide ::size_t. We\ncurrently rely on the fact that both libstdc++ and libc++ provide the\nstd namespace symbols in the C headers. This isn't the case for\nstd::size_t only, but for all the other C symbols.\n\n> >> #include \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> >> index 849fbbda..bbff1495 100644\n> >> --- a/include/libcamera/base/signal.h\n> >> +++ b/include/libcamera/base/signal.h\n> >> @@ -10,7 +10,6 @@\n> >> #include \n> >> #include \n> >> #include \n> >> -#include \n> >> \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n> >> index c3e63f69..92cce4f0 100644\n> >> --- a/include/libcamera/base/span.h\n> >> +++ b/include/libcamera/base/span.h\n> >> @@ -10,7 +10,6 @@\n> >> #include \n> >> #include \n> >> #include \n> >> -#include \n> >\n> > Same.\n> >\n> >> #include \n> >> \n> >> namespace libcamera {\n> >> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n> >> index 5ef45959..9646a0fe 100644\n> >> --- a/include/libcamera/base/timer.h\n> >> +++ b/include/libcamera/base/timer.h\n> >> @@ -8,7 +8,6 @@\n> >> #pragma once\n> >> \n> >> #include \n> >> -#include \n> >> \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> >> index 734ff81e..98c683a7 100644\n> >> --- a/include/libcamera/base/utils.h\n> >> +++ b/include/libcamera/base/utils.h\n> >> @@ -10,7 +10,6 @@\n> >> #include \n> >> #include \n> >> #include \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> >> index 5ae2270b..ff839243 100644\n> >> --- a/include/libcamera/framebuffer.h\n> >> +++ b/include/libcamera/framebuffer.h\n> >> @@ -7,7 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\n> >> index e098cb69..0150ca61 100644\n> >> --- a/include/libcamera/internal/camera_manager.h\n> >> +++ b/include/libcamera/internal/camera_manager.h\n> >> @@ -9,7 +9,6 @@\n> >> \n> >> #include \n> >> \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> >> index fc44ab98..a42c15fa 100644\n> >> --- a/include/libcamera/internal/camera_sensor.h\n> >> +++ b/include/libcamera/internal/camera_sensor.h\n> >> @@ -23,7 +23,6 @@\n> >> #include \n> >> \n> >> #include \"libcamera/internal/bayer_format.h\"\n> >> -#include \"libcamera/internal/formats.h\"\n> >> #include \"libcamera/internal/v4l2_subdevice.h\"\n> >> \n> >> namespace libcamera {\n> >> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h\n> >> b/include/libcamera/internal/device_enumerator_sysfs.h\n> >> index a5bfc711..4ccc9845 100644\n> >> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n> >> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n> >> @@ -7,7 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> #include \n> >> \n> >> #include \"libcamera/internal/device_enumerator.h\"\n> >> diff --git a/include/libcamera/internal/dma_buf_allocator.h\n> >> b/include/libcamera/internal/dma_buf_allocator.h\n> >> index 36ec1696..d2a0a0d1 100644\n> >> --- a/include/libcamera/internal/dma_buf_allocator.h\n> >> +++ b/include/libcamera/internal/dma_buf_allocator.h\n> >> @@ -7,8 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -\n> >\n> > Needed for size_t too ?\n> >\n> >> #include \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> >> index 71895cd8..6a3e9c16 100644\n> >> --- a/include/libcamera/internal/formats.h\n> >> +++ b/include/libcamera/internal/formats.h\n> >> @@ -8,7 +8,6 @@\n> >> #pragma once\n> >> \n> >> #include \n> >> -#include \n> >> #include \n> >> \n> >> #include \n> >> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> >> index 337c948c..13470a89 100644\n> >> --- a/include/libcamera/internal/ipa_data_serializer.h\n> >> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> >> @@ -7,8 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> @@ -22,8 +20,6 @@\n> >> #include \n> >> #include \n> >> \n> >> -#include \"libcamera/internal/byte_stream_buffer.h\"\n> >> -#include \"libcamera/internal/camera_sensor.h\"\n> >> #include \"libcamera/internal/control_serializer.h\"\n> >> \n> >> namespace libcamera {\n> >> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> >> index 0f564d99..983bcc5f 100644\n> >> --- a/include/libcamera/internal/ipa_proxy.h\n> >> +++ b/include/libcamera/internal/ipa_proxy.h\n> >> @@ -7,9 +7,7 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> #include \n> >> -#include \n> >> \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> index 4a0f6d57..8c972613 100644\n> >> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> @@ -9,7 +9,6 @@\n> >> \n> >> #include \n> >> #include \n> >> -#include \n> >> \n> >> #include \"libcamera/internal/ipc_pipe.h\"\n> >> #include \"libcamera/internal/ipc_unixsocket.h\"\n> >> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> >> index bf2e475d..e412d3a0 100644\n> >> --- a/include/libcamera/internal/media_device.h\n> >> +++ b/include/libcamera/internal/media_device.h\n> >> @@ -8,7 +8,6 @@\n> >> #pragma once\n> >> \n> >> #include \n> >> -#include \n> >> #include \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> >> index cad5812f..c37e6d02 100644\n> >> --- a/include/libcamera/internal/pipeline_handler.h\n> >> +++ b/include/libcamera/internal/pipeline_handler.h\n> >> @@ -9,7 +9,6 @@\n> >> \n> >> #include \n> >> #include \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> @@ -20,8 +19,6 @@\n> >> #include \n> >> #include \n> >> \n> >> -#include \"libcamera/internal/ipa_proxy.h\"\n> >> -\n> >> namespace libcamera {\n> >> \n> >> class Camera;\n> >> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> >> index 2ab0189f..e9f1dacd 100644\n> >> --- a/include/libcamera/internal/shared_mem_object.h\n> >> +++ b/include/libcamera/internal/shared_mem_object.h\n> >> @@ -8,7 +8,6 @@\n> >> */\n> >> #pragma once\n> >> \n> >> -#include \n> >\n> > size_t too.\n> >\n> >> #include \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> >> index ea60fe72..1b4d8c7c 100644\n> >> --- a/include/libcamera/pixel_format.h\n> >> +++ b/include/libcamera/pixel_format.h\n> >> @@ -8,7 +8,6 @@\n> >> #pragma once\n> >> \n> >> #include \n> >> -#include \n> >> #include \n> >> #include \n> >> \n> >> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> >> index 2c78d9bb..e214a9d1 100644\n> >> --- a/include/libcamera/request.h\n> >> +++ b/include/libcamera/request.h\n> >> @@ -12,7 +12,6 @@\n> >> #include \n> >> #include \n> >> #include \n> >> -#include \n> >> \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> >> index d510238a..071b7169 100644\n> >> --- a/include/libcamera/stream.h\n> >> +++ b/include/libcamera/stream.h\n> >> @@ -8,7 +8,6 @@\n> >> #pragma once\n> >> \n> >> #include \n> >> -#include \n> >> #include \n> >> #include \n> >> #include \n> >> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n> >> index a88f809e..4517412a 100644\n> >> --- a/include/libcamera/transform.h\n> >> +++ b/include/libcamera/transform.h\n> >> @@ -7,8 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -\n> >> namespace libcamera {\n> >> \n> >> enum class Orientation;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81467C324C\n\tfor ;\n\tMon, 2 Sep 2024 14:45:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7B168634E4;\n\tMon, 2 Sep 2024 16:45:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2A12618FD\n\tfor ;\n\tMon, 2 Sep 2024 16:44:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 315414CE;\n\tMon, 2 Sep 2024 16:43:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hhscOGjI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725288227;\n\tbh=3C/Cksr86T5I71UMn9n/zhgD6Ja1BC+FGCZ0bw1+xto=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hhscOGjImwWmju22ADrqAjDHJ42qm4TnY4n4W2tIqS7TPj8bk0MI32FR7ZkGHcd35\n\tl6oy3s09jXMNrwolHQcR2KelKD2BhE0WTRq6xPRUicksx36N5kKuZimeQuzaVBqXSx\n\toVUugNEZ6OQvZiUQcQ7Go6X4Q4+d+a8RatTMyPRg=","Date":"Mon, 2 Sep 2024 17:44:26 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","Message-ID":"<20240902144426.GI4313@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-20-mzamazal@redhat.com>\n\t<20240831004414.GS3811@pendragon.ideasonboard.com>\n\t<871q22uosc.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<871q22uosc.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31054,"web_url":"https://patchwork.libcamera.org/comment/31054/","msgid":"<87o756t7sm.fsf@redhat.com>","date":"2024-09-02T15:05:45","subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> Hi Milan,\n>\n> On Mon, Sep 02, 2024 at 04:13:23PM +0200, Milan Zamazal wrote:\n>> Laurent Pinchart writes:\n>> > On Fri, Aug 30, 2024 at 05:27:16PM +0200, Milan Zamazal wrote:\n>> >> The includes that are not used can be removed.\n>> >> \n>> >> Signed-off-by: Milan Zamazal \n>> >> ---\n>> >> include/libcamera/base/event_dispatcher.h | 2 --\n>> >> include/libcamera/base/log.h | 1 -\n>> >> include/libcamera/base/memfd.h | 2 --\n>> >> include/libcamera/base/signal.h | 1 -\n>> >> include/libcamera/base/span.h | 1 -\n>> >> include/libcamera/base/timer.h | 1 -\n>> >> include/libcamera/base/utils.h | 1 -\n>> >> include/libcamera/framebuffer.h | 1 -\n>> >> include/libcamera/internal/camera_manager.h | 1 -\n>> >> include/libcamera/internal/camera_sensor.h | 1 -\n>> >> include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n>> >> include/libcamera/internal/dma_buf_allocator.h | 2 --\n>> >> include/libcamera/internal/formats.h | 1 -\n>> >> include/libcamera/internal/ipa_data_serializer.h | 4 ----\n>> >> include/libcamera/internal/ipa_proxy.h | 2 --\n>> >> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n>> >> include/libcamera/internal/media_device.h | 1 -\n>> >> include/libcamera/internal/pipeline_handler.h | 3 ---\n>> >> include/libcamera/internal/shared_mem_object.h | 1 -\n>> >> include/libcamera/pixel_format.h | 1 -\n>> >> include/libcamera/request.h | 1 -\n>> >> include/libcamera/stream.h | 1 -\n>> >> include/libcamera/transform.h | 2 --\n>> >> 23 files changed, 33 deletions(-)\n>> >> \n>> >> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n>> >> index e9a09c6e..408f8da6 100644\n>> >> --- a/include/libcamera/base/event_dispatcher.h\n>> >> +++ b/include/libcamera/base/event_dispatcher.h\n>> >> @@ -7,8 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> -\n>> >> #include \n>> >> \n>> >> namespace libcamera {\n>> >> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n>> >> index df27df03..62093012 100644\n>> >> --- a/include/libcamera/base/log.h\n>> >> +++ b/include/libcamera/base/log.h\n>> >> @@ -7,7 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> #include \n>> >> \n>> >> #include \n>> >> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n>> >> index b0edd2de..705d9929 100644\n>> >> --- a/include/libcamera/base/memfd.h\n>> >> +++ b/include/libcamera/base/memfd.h\n>> >> @@ -7,8 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> -\n>> >\n>> > Don't we need this for size_t ?\n>> \n>> It would work for size_t but not for std::size_t. The latter is\n>> included in several header files, including , but C++ only.\n>> libcamera permits only , which includes std::size_t too, but only\n>> indirectly; it would be nonsense to import std::size_t this way.\n>> \n>> I'm not sure what's the best to do here. I'd say nothing -- std::size_t\n>> is so ubiquitous that it is included some way via almost any C++ header\n>> file. If we would like to be 100% clean then I think or\n>> should be included but then checkstyle.py had to be modified\n>> to permit that.\n>> \n>> In any case, including is truly redundant here.\n>\n> stddef.h is required to provide ::size_t and may provide std::size_t.\n> cstddef is required to provide std::size_t and may provide ::size_t. We\n> currently rely on the fact that both libstdc++ and libc++ provide the\n> std namespace symbols in the C headers. This isn't the case for\n> std::size_t only, but for all the other C symbols.\n\nIt doesn't seem to be the case in the environment I use to compile libcamera. Compilation of:\n\n #include \n\n void foo() {\n std::size_t x = 1;\n }\n\nwith g++ fails with:\n\n /home/pdm/tmp/foo.cc: In function ‘void foo()’:\n /home/pdm/tmp/foo.cc:3:8: error: ‘size_t’ is not a member of ‘std’; did you mean ‘size_t’?\n 3 | std::size_t x = 1;\n | ^~~~~~\n In file included from /home/pdm/tmp/foo.cc:1:\n /usr/lib/gcc/x86_64-redhat-linux/14/include/stddef.h:214:23: note: ‘size_t’ declared here\n 214 | typedef __SIZE_TYPE__ size_t;\n | ^~~~~~\n\nDo I miss something? Does it perhaps require some option to be set?\n\n>> >> #include \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n>> >> index 849fbbda..bbff1495 100644\n>> >> --- a/include/libcamera/base/signal.h\n>> >> +++ b/include/libcamera/base/signal.h\n>> >> @@ -10,7 +10,6 @@\n>> >> #include \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >> \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n>> >> index c3e63f69..92cce4f0 100644\n>> >> --- a/include/libcamera/base/span.h\n>> >> +++ b/include/libcamera/base/span.h\n>> >> @@ -10,7 +10,6 @@\n>> >> #include \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >\n>> > Same.\n>> >\n>> >> #include \n>> >> \n>> >> namespace libcamera {\n>> >> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n>> >> index 5ef45959..9646a0fe 100644\n>> >> --- a/include/libcamera/base/timer.h\n>> >> +++ b/include/libcamera/base/timer.h\n>> >> @@ -8,7 +8,6 @@\n>> >> #pragma once\n>> >> \n>> >> #include \n>> >> -#include \n>> >> \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n>> >> index 734ff81e..98c683a7 100644\n>> >> --- a/include/libcamera/base/utils.h\n>> >> +++ b/include/libcamera/base/utils.h\n>> >> @@ -10,7 +10,6 @@\n>> >> #include \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n>> >> index 5ae2270b..ff839243 100644\n>> >> --- a/include/libcamera/framebuffer.h\n>> >> +++ b/include/libcamera/framebuffer.h\n>> >> @@ -7,7 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/internal/camera_manager.h\n>> >> b/include/libcamera/internal/camera_manager.h\n>> >> index e098cb69..0150ca61 100644\n>> >> --- a/include/libcamera/internal/camera_manager.h\n>> >> +++ b/include/libcamera/internal/camera_manager.h\n>> >> @@ -9,7 +9,6 @@\n>> >> \n>> >> #include \n>> >> \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n>> >> index fc44ab98..a42c15fa 100644\n>> >> --- a/include/libcamera/internal/camera_sensor.h\n>> >> +++ b/include/libcamera/internal/camera_sensor.h\n>> >> @@ -23,7 +23,6 @@\n>> >> #include \n>> >> \n>> >> #include \"libcamera/internal/bayer_format.h\"\n>> >> -#include \"libcamera/internal/formats.h\"\n>> >> #include \"libcamera/internal/v4l2_subdevice.h\"\n>> >> \n>> >> namespace libcamera {\n>> >> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h\n>> >> b/include/libcamera/internal/device_enumerator_sysfs.h\n>> >> index a5bfc711..4ccc9845 100644\n>> >> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n>> >> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n>> >> @@ -7,7 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> #include \n>> >> \n>> >> #include \"libcamera/internal/device_enumerator.h\"\n>> >> diff --git a/include/libcamera/internal/dma_buf_allocator.h\n>> >> b/include/libcamera/internal/dma_buf_allocator.h\n>> >> index 36ec1696..d2a0a0d1 100644\n>> >> --- a/include/libcamera/internal/dma_buf_allocator.h\n>> >> +++ b/include/libcamera/internal/dma_buf_allocator.h\n>> >> @@ -7,8 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> -\n>> >\n>> > Needed for size_t too ?\n>> >\n>> >> #include \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n>> >> index 71895cd8..6a3e9c16 100644\n>> >> --- a/include/libcamera/internal/formats.h\n>> >> +++ b/include/libcamera/internal/formats.h\n>> >> @@ -8,7 +8,6 @@\n>> >> #pragma once\n>> >> \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> \n>> >> #include \n>> >> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n>> >> index 337c948c..13470a89 100644\n>> >> --- a/include/libcamera/internal/ipa_data_serializer.h\n>> >> +++ b/include/libcamera/internal/ipa_data_serializer.h\n>> >> @@ -7,8 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> @@ -22,8 +20,6 @@\n>> >> #include \n>> >> #include \n>> >> \n>> >> -#include \"libcamera/internal/byte_stream_buffer.h\"\n>> >> -#include \"libcamera/internal/camera_sensor.h\"\n>> >> #include \"libcamera/internal/control_serializer.h\"\n>> >> \n>> >> namespace libcamera {\n>> >> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n>> >> index 0f564d99..983bcc5f 100644\n>> >> --- a/include/libcamera/internal/ipa_proxy.h\n>> >> +++ b/include/libcamera/internal/ipa_proxy.h\n>> >> @@ -7,9 +7,7 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> #include \n>> >> -#include \n>> >> \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> >> index 4a0f6d57..8c972613 100644\n>> >> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> >> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n>> >> @@ -9,7 +9,6 @@\n>> >> \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >> \n>> >> #include \"libcamera/internal/ipc_pipe.h\"\n>> >> #include \"libcamera/internal/ipc_unixsocket.h\"\n>> >> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n>> >> index bf2e475d..e412d3a0 100644\n>> >> --- a/include/libcamera/internal/media_device.h\n>> >> +++ b/include/libcamera/internal/media_device.h\n>> >> @@ -8,7 +8,6 @@\n>> >> #pragma once\n>> >> \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n>> >> index cad5812f..c37e6d02 100644\n>> >> --- a/include/libcamera/internal/pipeline_handler.h\n>> >> +++ b/include/libcamera/internal/pipeline_handler.h\n>> >> @@ -9,7 +9,6 @@\n>> >> \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> @@ -20,8 +19,6 @@\n>> >> #include \n>> >> #include \n>> >> \n>> >> -#include \"libcamera/internal/ipa_proxy.h\"\n>> >> -\n>> >> namespace libcamera {\n>> >> \n>> >> class Camera;\n>> >> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n>> >> index 2ab0189f..e9f1dacd 100644\n>> >> --- a/include/libcamera/internal/shared_mem_object.h\n>> >> +++ b/include/libcamera/internal/shared_mem_object.h\n>> >> @@ -8,7 +8,6 @@\n>> >> */\n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >\n>> > size_t too.\n>> >\n>> >> #include \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n>> >> index ea60fe72..1b4d8c7c 100644\n>> >> --- a/include/libcamera/pixel_format.h\n>> >> +++ b/include/libcamera/pixel_format.h\n>> >> @@ -8,7 +8,6 @@\n>> >> #pragma once\n>> >> \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> \n>> >> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n>> >> index 2c78d9bb..e214a9d1 100644\n>> >> --- a/include/libcamera/request.h\n>> >> +++ b/include/libcamera/request.h\n>> >> @@ -12,7 +12,6 @@\n>> >> #include \n>> >> #include \n>> >> #include \n>> >> -#include \n>> >> \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n>> >> index d510238a..071b7169 100644\n>> >> --- a/include/libcamera/stream.h\n>> >> +++ b/include/libcamera/stream.h\n>> >> @@ -8,7 +8,6 @@\n>> >> #pragma once\n>> >> \n>> >> #include \n>> >> -#include \n>> >> #include \n>> >> #include \n>> >> #include \n>> >> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n>> >> index a88f809e..4517412a 100644\n>> >> --- a/include/libcamera/transform.h\n>> >> +++ b/include/libcamera/transform.h\n>> >> @@ -7,8 +7,6 @@\n>> >> \n>> >> #pragma once\n>> >> \n>> >> -#include \n>> >> -\n>> >> namespace libcamera {\n>> >> \n>> >> enum class Orientation;\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BFCD4BF415\n\tfor ;\n\tMon, 2 Sep 2024 15:05:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5105618FF;\n\tMon, 2 Sep 2024 17:05:56 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8D9B4618FD\n\tfor ;\n\tMon, 2 Sep 2024 17:05:54 +0200 (CEST)","from mail-lf1-f69.google.com (mail-lf1-f69.google.com\n\t[209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-594-Ab_6qFbZOs2rDNqyqfq1Yg-1; Mon, 02 Sep 2024 11:05:51 -0400","by mail-lf1-f69.google.com with SMTP id\n\t2adb3069b0e04-53440ff1ecfso4622508e87.3\n\tfor ;\n\tMon, 02 Sep 2024 08:05:50 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a89891968e9sm565860766b.120.2024.09.02.08.05.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Sep 2024 08:05:47 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GsI1rAcr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725289553;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=gYVqy1Au0R99f9ug3aBRTowfYYw2SH/ftBuyYo/D9VM=;\n\tb=GsI1rAcrOuvl0BdfZfjECgI098lWgEmJwuLN9P/qKr0nLFjlpCirCBgmBD0vxXvu3ysk4D\n\tlrIwpUUYUTof25MF4FLljuCssCqLC34maYZ/DSBj5qGlmk58HRkTAii9xMNVj5clf3nlrb\n\t/nvPn4VqvX7tyTgFyLA3rA53VtojvjA=","X-MC-Unique":"Ab_6qFbZOs2rDNqyqfq1Yg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725289549; x=1725894349;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nkiyhpdyYOSjgSQMZ7m3mN4jtEEOr8it5Xz7Hh4Yui4=;\n\tb=ut0Kol1BrrxSsmYz36pWVAEarbTR/nncKhvCNh+yQo4NpZnglVCURINU6qgBzyDoJj\n\t4M9Bbx+EdlLlqNQK3ce2gakmPs3yHgaADrPD1zxRj+yLyA+aw1KBSUelfoFr9dTKWHlL\n\tu1uaTHzyo7yGzOv4y/Liz0C+/yF5ekqLzvRfWtJrINgdCdpJwPgSe2GB9uUntJhSxv2l\n\tcgE6kO6mx3UtDvMRplokzvb3y3wD+rlXO8PiTbYUoMdBJVWYmws+ztBm/17YSOR061t7\n\t/3u/HgrPbJ772DyZJI8UIqA3obuiqg/MUdIG4rjy0vuPrUR19cI0Nb1rDZ06fWyD2Axq\n\t9s5g==","X-Gm-Message-State":"AOJu0YwrQf31qtBxN3HejnPVnCYFoWijPH9fEpjNro+XtVq9kvO7dD3G\n\txfSbrhj3K46GqDfglX7jRWhAfIpF7/oLW0iOH3+rCQYPxYdwvXQlY8BhO/4GzFxHc5ha8cyXoy/\n\t5avOYZXMj9suntFBm7Nw16meW+P6mrMGvd6G04hgrpqpo7koO/QprD04b116Nat8xfvuwy942Xr\n\t+mmvqq54+a4HHbSCKEVK73NsHHf2qNYwhz+CAY/rouFJWKZ+eBfHmmklo=","X-Received":["by 2002:a05:6512:3b90:b0:52c:e326:f4cf with SMTP id\n\t2adb3069b0e04-53546afa29dmr7629327e87.3.1725289549044; \n\tMon, 02 Sep 2024 08:05:49 -0700 (PDT)","by 2002:a05:6512:3b90:b0:52c:e326:f4cf with SMTP id\n\t2adb3069b0e04-53546afa29dmr7629293e87.3.1725289548161; \n\tMon, 02 Sep 2024 08:05:48 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGDn4hGlrpVORsi/xYpBwklNoZeQpfNio/CaIgKepUq9Jwtb6WLXuqBhsJS/ii9qMHUHXvi4Q==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","In-Reply-To":"<20240902144426.GI4313@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 2 Sep 2024 17:44:26 +0300\")","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-20-mzamazal@redhat.com>\n\t<20240831004414.GS3811@pendragon.ideasonboard.com>\n\t<871q22uosc.fsf@redhat.com>\n\t<20240902144426.GI4313@pendragon.ideasonboard.com>","Date":"Mon, 02 Sep 2024 17:05:45 +0200","Message-ID":"<87o756t7sm.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31055,"web_url":"https://patchwork.libcamera.org/comment/31055/","msgid":"<20240902151655.GK4313@pendragon.ideasonboard.com>","date":"2024-09-02T15:16:55","subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 05:05:45PM +0200, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> \n> > Hi Milan,\n> >\n> > On Mon, Sep 02, 2024 at 04:13:23PM +0200, Milan Zamazal wrote:\n> >> Laurent Pinchart writes:\n> >> > On Fri, Aug 30, 2024 at 05:27:16PM +0200, Milan Zamazal wrote:\n> >> >> The includes that are not used can be removed.\n> >> >> \n> >> >> Signed-off-by: Milan Zamazal \n> >> >> ---\n> >> >> include/libcamera/base/event_dispatcher.h | 2 --\n> >> >> include/libcamera/base/log.h | 1 -\n> >> >> include/libcamera/base/memfd.h | 2 --\n> >> >> include/libcamera/base/signal.h | 1 -\n> >> >> include/libcamera/base/span.h | 1 -\n> >> >> include/libcamera/base/timer.h | 1 -\n> >> >> include/libcamera/base/utils.h | 1 -\n> >> >> include/libcamera/framebuffer.h | 1 -\n> >> >> include/libcamera/internal/camera_manager.h | 1 -\n> >> >> include/libcamera/internal/camera_sensor.h | 1 -\n> >> >> include/libcamera/internal/device_enumerator_sysfs.h | 1 -\n> >> >> include/libcamera/internal/dma_buf_allocator.h | 2 --\n> >> >> include/libcamera/internal/formats.h | 1 -\n> >> >> include/libcamera/internal/ipa_data_serializer.h | 4 ----\n> >> >> include/libcamera/internal/ipa_proxy.h | 2 --\n> >> >> include/libcamera/internal/ipc_pipe_unixsocket.h | 1 -\n> >> >> include/libcamera/internal/media_device.h | 1 -\n> >> >> include/libcamera/internal/pipeline_handler.h | 3 ---\n> >> >> include/libcamera/internal/shared_mem_object.h | 1 -\n> >> >> include/libcamera/pixel_format.h | 1 -\n> >> >> include/libcamera/request.h | 1 -\n> >> >> include/libcamera/stream.h | 1 -\n> >> >> include/libcamera/transform.h | 2 --\n> >> >> 23 files changed, 33 deletions(-)\n> >> >> \n> >> >> diff --git a/include/libcamera/base/event_dispatcher.h b/include/libcamera/base/event_dispatcher.h\n> >> >> index e9a09c6e..408f8da6 100644\n> >> >> --- a/include/libcamera/base/event_dispatcher.h\n> >> >> +++ b/include/libcamera/base/event_dispatcher.h\n> >> >> @@ -7,8 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> -\n> >> >> #include \n> >> >> \n> >> >> namespace libcamera {\n> >> >> diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\n> >> >> index df27df03..62093012 100644\n> >> >> --- a/include/libcamera/base/log.h\n> >> >> +++ b/include/libcamera/base/log.h\n> >> >> @@ -7,7 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> #include \n> >> >> \n> >> >> #include \n> >> >> diff --git a/include/libcamera/base/memfd.h b/include/libcamera/base/memfd.h\n> >> >> index b0edd2de..705d9929 100644\n> >> >> --- a/include/libcamera/base/memfd.h\n> >> >> +++ b/include/libcamera/base/memfd.h\n> >> >> @@ -7,8 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> -\n> >> >\n> >> > Don't we need this for size_t ?\n> >> \n> >> It would work for size_t but not for std::size_t. The latter is\n> >> included in several header files, including , but C++ only.\n> >> libcamera permits only , which includes std::size_t too, but only\n> >> indirectly; it would be nonsense to import std::size_t this way.\n> >> \n> >> I'm not sure what's the best to do here. I'd say nothing -- std::size_t\n> >> is so ubiquitous that it is included some way via almost any C++ header\n> >> file. If we would like to be 100% clean then I think or\n> >> should be included but then checkstyle.py had to be modified\n> >> to permit that.\n> >> \n> >> In any case, including is truly redundant here.\n> >\n> > stddef.h is required to provide ::size_t and may provide std::size_t.\n> > cstddef is required to provide std::size_t and may provide ::size_t. We\n> > currently rely on the fact that both libstdc++ and libc++ provide the\n> > std namespace symbols in the C headers. This isn't the case for\n> > std::size_t only, but for all the other C symbols.\n> \n> It doesn't seem to be the case in the environment I use to compile libcamera. Compilation of:\n> \n> #include \n> \n> void foo() {\n> std::size_t x = 1;\n> }\n> \n> with g++ fails with:\n> \n> /home/pdm/tmp/foo.cc: In function ‘void foo()’:\n> /home/pdm/tmp/foo.cc:3:8: error: ‘size_t’ is not a member of ‘std’; did you mean ‘size_t’?\n> 3 | std::size_t x = 1;\n> | ^~~~~~\n> In file included from /home/pdm/tmp/foo.cc:1:\n> /usr/lib/gcc/x86_64-redhat-linux/14/include/stddef.h:214:23: note: ‘size_t’ declared here\n> 214 | typedef __SIZE_TYPE__ size_t;\n> | ^~~~~~\n> \n> Do I miss something? Does it perhaps require some option to be set?\n\nYes, you missed the fact that I was wrong :-S I would have sworn the C\nheaders would provide the std:: namespace too.\n\nI wonder if this would call for switching to the C++ headers\nunconditionally. Not as part of this series of course :-)\n\n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\n> >> >> index 849fbbda..bbff1495 100644\n> >> >> --- a/include/libcamera/base/signal.h\n> >> >> +++ b/include/libcamera/base/signal.h\n> >> >> @@ -10,7 +10,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >> \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/base/span.h b/include/libcamera/base/span.h\n> >> >> index c3e63f69..92cce4f0 100644\n> >> >> --- a/include/libcamera/base/span.h\n> >> >> +++ b/include/libcamera/base/span.h\n> >> >> @@ -10,7 +10,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >\n> >> > Same.\n> >> >\n> >> >> #include \n> >> >> \n> >> >> namespace libcamera {\n> >> >> diff --git a/include/libcamera/base/timer.h b/include/libcamera/base/timer.h\n> >> >> index 5ef45959..9646a0fe 100644\n> >> >> --- a/include/libcamera/base/timer.h\n> >> >> +++ b/include/libcamera/base/timer.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> #pragma once\n> >> >> \n> >> >> #include \n> >> >> -#include \n> >> >> \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\n> >> >> index 734ff81e..98c683a7 100644\n> >> >> --- a/include/libcamera/base/utils.h\n> >> >> +++ b/include/libcamera/base/utils.h\n> >> >> @@ -10,7 +10,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\n> >> >> index 5ae2270b..ff839243 100644\n> >> >> --- a/include/libcamera/framebuffer.h\n> >> >> +++ b/include/libcamera/framebuffer.h\n> >> >> @@ -7,7 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/internal/camera_manager.h\n> >> >> b/include/libcamera/internal/camera_manager.h\n> >> >> index e098cb69..0150ca61 100644\n> >> >> --- a/include/libcamera/internal/camera_manager.h\n> >> >> +++ b/include/libcamera/internal/camera_manager.h\n> >> >> @@ -9,7 +9,6 @@\n> >> >> \n> >> >> #include \n> >> >> \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> >> >> index fc44ab98..a42c15fa 100644\n> >> >> --- a/include/libcamera/internal/camera_sensor.h\n> >> >> +++ b/include/libcamera/internal/camera_sensor.h\n> >> >> @@ -23,7 +23,6 @@\n> >> >> #include \n> >> >> \n> >> >> #include \"libcamera/internal/bayer_format.h\"\n> >> >> -#include \"libcamera/internal/formats.h\"\n> >> >> #include \"libcamera/internal/v4l2_subdevice.h\"\n> >> >> \n> >> >> namespace libcamera {\n> >> >> diff --git a/include/libcamera/internal/device_enumerator_sysfs.h\n> >> >> b/include/libcamera/internal/device_enumerator_sysfs.h\n> >> >> index a5bfc711..4ccc9845 100644\n> >> >> --- a/include/libcamera/internal/device_enumerator_sysfs.h\n> >> >> +++ b/include/libcamera/internal/device_enumerator_sysfs.h\n> >> >> @@ -7,7 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> #include \n> >> >> \n> >> >> #include \"libcamera/internal/device_enumerator.h\"\n> >> >> diff --git a/include/libcamera/internal/dma_buf_allocator.h\n> >> >> b/include/libcamera/internal/dma_buf_allocator.h\n> >> >> index 36ec1696..d2a0a0d1 100644\n> >> >> --- a/include/libcamera/internal/dma_buf_allocator.h\n> >> >> +++ b/include/libcamera/internal/dma_buf_allocator.h\n> >> >> @@ -7,8 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> -\n> >> >\n> >> > Needed for size_t too ?\n> >> >\n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\n> >> >> index 71895cd8..6a3e9c16 100644\n> >> >> --- a/include/libcamera/internal/formats.h\n> >> >> +++ b/include/libcamera/internal/formats.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> #pragma once\n> >> >> \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> \n> >> >> #include \n> >> >> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> >> >> index 337c948c..13470a89 100644\n> >> >> --- a/include/libcamera/internal/ipa_data_serializer.h\n> >> >> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> >> >> @@ -7,8 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> @@ -22,8 +20,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> -#include \"libcamera/internal/byte_stream_buffer.h\"\n> >> >> -#include \"libcamera/internal/camera_sensor.h\"\n> >> >> #include \"libcamera/internal/control_serializer.h\"\n> >> >> \n> >> >> namespace libcamera {\n> >> >> diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\n> >> >> index 0f564d99..983bcc5f 100644\n> >> >> --- a/include/libcamera/internal/ipa_proxy.h\n> >> >> +++ b/include/libcamera/internal/ipa_proxy.h\n> >> >> @@ -7,9 +7,7 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> #include \n> >> >> -#include \n> >> >> \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/internal/ipc_pipe_unixsocket.h b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> >> index 4a0f6d57..8c972613 100644\n> >> >> --- a/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> >> +++ b/include/libcamera/internal/ipc_pipe_unixsocket.h\n> >> >> @@ -9,7 +9,6 @@\n> >> >> \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >> \n> >> >> #include \"libcamera/internal/ipc_pipe.h\"\n> >> >> #include \"libcamera/internal/ipc_unixsocket.h\"\n> >> >> diff --git a/include/libcamera/internal/media_device.h b/include/libcamera/internal/media_device.h\n> >> >> index bf2e475d..e412d3a0 100644\n> >> >> --- a/include/libcamera/internal/media_device.h\n> >> >> +++ b/include/libcamera/internal/media_device.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> #pragma once\n> >> >> \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> >> >> index cad5812f..c37e6d02 100644\n> >> >> --- a/include/libcamera/internal/pipeline_handler.h\n> >> >> +++ b/include/libcamera/internal/pipeline_handler.h\n> >> >> @@ -9,7 +9,6 @@\n> >> >> \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> @@ -20,8 +19,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> -#include \"libcamera/internal/ipa_proxy.h\"\n> >> >> -\n> >> >> namespace libcamera {\n> >> >> \n> >> >> class Camera;\n> >> >> diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> >> >> index 2ab0189f..e9f1dacd 100644\n> >> >> --- a/include/libcamera/internal/shared_mem_object.h\n> >> >> +++ b/include/libcamera/internal/shared_mem_object.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> */\n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >\n> >> > size_t too.\n> >> >\n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/pixel_format.h b/include/libcamera/pixel_format.h\n> >> >> index ea60fe72..1b4d8c7c 100644\n> >> >> --- a/include/libcamera/pixel_format.h\n> >> >> +++ b/include/libcamera/pixel_format.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> #pragma once\n> >> >> \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> \n> >> >> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> >> >> index 2c78d9bb..e214a9d1 100644\n> >> >> --- a/include/libcamera/request.h\n> >> >> +++ b/include/libcamera/request.h\n> >> >> @@ -12,7 +12,6 @@\n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> -#include \n> >> >> \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\n> >> >> index d510238a..071b7169 100644\n> >> >> --- a/include/libcamera/stream.h\n> >> >> +++ b/include/libcamera/stream.h\n> >> >> @@ -8,7 +8,6 @@\n> >> >> #pragma once\n> >> >> \n> >> >> #include \n> >> >> -#include \n> >> >> #include \n> >> >> #include \n> >> >> #include \n> >> >> diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\n> >> >> index a88f809e..4517412a 100644\n> >> >> --- a/include/libcamera/transform.h\n> >> >> +++ b/include/libcamera/transform.h\n> >> >> @@ -7,8 +7,6 @@\n> >> >> \n> >> >> #pragma once\n> >> >> \n> >> >> -#include \n> >> >> -\n> >> >> namespace libcamera {\n> >> >> \n> >> >> enum class Orientation;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 471D8C324C\n\tfor ;\n\tMon, 2 Sep 2024 15:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 799A3618FD;\n\tMon, 2 Sep 2024 17:17:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FED9618FD\n\tfor ;\n\tMon, 2 Sep 2024 17:17:28 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32B40720;\n\tMon, 2 Sep 2024 17:16:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bgJU7yMz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725290177;\n\tbh=v39HRHJZnzjl36iuBlWpQpyKZwZWGk2P71khrXsVpg4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bgJU7yMzo/K7/wljaH+RfxzlMaCa8sOj/fSeAxjLCEReuFoAr8BTPUPgVQ+wq08gc\n\t+Ff+/1IGqdh0COwUtuB1AJ9Ao7xy4pgdJT+zUy5wgvvCvPVgcF/ED/MJ3az+HTB24A\n\t03qJ/NcWKhTgfl80J2nWW0XL6uBkdHwLRALvqRYg=","Date":"Mon, 2 Sep 2024 18:16:55 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 19/20] libcamera: includes: Remove unused includes","Message-ID":"<20240902151655.GK4313@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-20-mzamazal@redhat.com>\n\t<20240831004414.GS3811@pendragon.ideasonboard.com>\n\t<871q22uosc.fsf@redhat.com>\n\t<20240902144426.GI4313@pendragon.ideasonboard.com>\n\t<87o756t7sm.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<87o756t7sm.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]