[{"id":31015,"web_url":"https://patchwork.libcamera.org/comment/31015/","msgid":"<20240831003948.GR3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:39:48","subject":"Re: [PATCH v2 18/20] libcamera: includes: Add missing includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2024 at 05:27:15PM +0200, Milan Zamazal wrote:\n> Let's add direct includes for classes currently included indirectly,\n> through other header files.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/request.h | 1 +\n> include/libcamera/logging.h | 2 ++\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/include/libcamera/internal/request.h b/include/libcamera/internal/request.h\n> index f5d98069..4e7d05b1 100644\n> --- a/include/libcamera/internal/request.h\n> +++ b/include/libcamera/internal/request.h\n> @@ -10,6 +10,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> #include \n> #include \n> diff --git a/include/libcamera/logging.h b/include/libcamera/logging.h\n> index e334d87b..e1c6341c 100644\n> --- a/include/libcamera/logging.h\n> +++ b/include/libcamera/logging.h\n> @@ -7,6 +7,8 @@\n> \n> #pragma once\n> \n> +#include \n> +\n> namespace libcamera {\n> \n> enum LoggingTarget {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FFE6C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:40:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A0F963469;\n\tSat, 31 Aug 2024 02:40:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5BD4618FF\n\tfor ;\n\tSat, 31 Aug 2024 02:40:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D16C74C;\n\tSat, 31 Aug 2024 02:39:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rRa/8G4/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725064750;\n\tbh=0gmzaf3dY+EuCJ9bAW4N7CaTmc/AvpsSHtj4V8tH7bk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rRa/8G4/uDxlj+oHVSI2820MtOBqOgaxR1lV0RnHoOH4Ote9TyXnrQCInkNsxCDyx\n\tv/CBzmnIBtzhdw1h10IxPbh824ZdGxMqcd9SvsUvbarwPcwjgapveiyXqy+12kbdIc\n\tzPocA33uctJ63SrEk00Eg8SGWtsF7mjyfUMCfvZg=","Date":"Sat, 31 Aug 2024 03:39:48 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 18/20] libcamera: includes: Add missing includes","Message-ID":"<20240831003948.GR3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-19-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-19-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]