[{"id":31013,"web_url":"https://patchwork.libcamera.org/comment/31013/","msgid":"<20240831003227.GP3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:32:27","subject":"Re: [PATCH v2 16/20] libcamera: libcamera: Add missing includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2024 at 05:27:13PM +0200, Milan Zamazal wrote:\n> Let's add direct includes for classes currently included indirectly,\n> through other header files.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 2 ++\n> src/libcamera/ipa_data_serializer.cpp | 2 ++\n> 2 files changed, 4 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 3ee89590..dbefb094 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,6 +7,8 @@\n> \n> #include \"libcamera/internal/formats.h\"\n> \n> +#include \n> +\n> #include \n> #include \n> \n> diff --git a/src/libcamera/ipa_data_serializer.cpp b/src/libcamera/ipa_data_serializer.cpp\n> index 3e9bef08..f6dd7e6f 100644\n> --- a/src/libcamera/ipa_data_serializer.cpp\n> +++ b/src/libcamera/ipa_data_serializer.cpp\n> @@ -11,6 +11,8 @@\n> \n> #include \n> \n> +#include \"libcamera/internal/byte_stream_buffer.h\"\n> +\n> /**\n> * \\file ipa_data_serializer.h\n> * \\brief IPA Data Serializer","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB74FC323E\n\tfor ;\n\tSat, 31 Aug 2024 00:33:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 715DF63466;\n\tSat, 31 Aug 2024 02:33:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0993C6341E\n\tfor ;\n\tSat, 31 Aug 2024 02:32:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 84F5574C;\n\tSat, 31 Aug 2024 02:31:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t8pF3m4A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725064309;\n\tbh=TNV37m52mg3O1na364fhBSEHBZUd+Idci2nyBRssRQ4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=t8pF3m4AWBeeS3luJMyEJpsRxn11RYLAcLTDbKsEb4hYMryAfG0ZJ7UG5sBEEaQI/\n\twAXSAlsHaYIw/8vLMItRLNBolIhckIO1zWcq/gIu/74vPJHO4L9AT4Cje5Gz3b6Uxz\n\tsin/tM0wvQWCooGrEt/0UpoHxOs723L/7346GwKk=","Date":"Sat, 31 Aug 2024 03:32:27 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 16/20] libcamera: libcamera: Add missing includes","Message-ID":"<20240831003227.GP3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-17-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-17-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]