[{"id":31011,"web_url":"https://patchwork.libcamera.org/comment/31011/","msgid":"<20240831002048.GN3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:20:48","subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:27:11PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> include/libcamera/ipa/ipa_interface.h | 5 -----\n> 1 file changed, 5 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 7c835e98..2fdc085e 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,11 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -#include \n> -#include \n> -\n> #include \n> #include \n\nI think all the other includes can be dropped too.\n\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B79B6C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:21:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D41863469;\n\tSat, 31 Aug 2024 02:21:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0A9A66341E\n\tfor ;\n\tSat, 31 Aug 2024 02:21:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DA1574C;\n\tSat, 31 Aug 2024 02:20:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d6kjdKV+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725063610;\n\tbh=koVs65hdCLzSVGDGAGdPEtV+aCA8am+55uxViojpKUc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d6kjdKV+Z16qc/ceGUnTCSlMIKbon6Ce9j60ak9goLMf4UaweP0ChySrRtpH6dvTU\n\tsiwGTXzSJ7yonPhgRIXqestjHsoqwURFH0PgvyLs4Yo0LA4CC1OYrzwf+l739/b0UK\n\tR+I2FGYlmElswGynKldn0KpnQXFc//ahRUUAxVoE=","Date":"Sat, 31 Aug 2024 03:20:48 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","Message-ID":"<20240831002048.GN3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-15-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-15-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31043,"web_url":"https://patchwork.libcamera.org/comment/31043/","msgid":"<87jzfuuu28.fsf@redhat.com>","date":"2024-09-02T12:19:27","subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart writes:\n\n> On Fri, Aug 30, 2024 at 05:27:11PM +0200, Milan Zamazal wrote:\n>> The includes that are not used can be removed.\n>> \n>\n>> Signed-off-by: Milan Zamazal \n>> ---\n>> include/libcamera/ipa/ipa_interface.h | 5 -----\n>> 1 file changed, 5 deletions(-)\n>> \n>> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n>> index 7c835e98..2fdc085e 100644\n>> --- a/include/libcamera/ipa/ipa_interface.h\n>> +++ b/include/libcamera/ipa/ipa_interface.h\n>> @@ -7,11 +7,6 @@\n>> \n>> #pragma once\n>> \n>> -#include \n>> -#include \n>> -#include \n>> -#include \n>> -\n>> #include \n>> #include \n>\n> I think all the other includes can be dropped too.\n\nI'm not sure. ipa_interface.h is included in the generated files and\nthey rely on the includes (and what is worse, apparently on things\nincluded through them). Perhaps this should be fixed by including the\ncorresponding stuff at the right places but I'm worried by the fact that\nLSP doesn't mark these includes as redundant (apparently for a reason).\nI would rather not mess with the generated code in this patch series.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9C1DC324C\n\tfor ;\n\tMon, 2 Sep 2024 12:19:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7927618FF;\n\tMon, 2 Sep 2024 14:19:36 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C372618FD\n\tfor ;\n\tMon, 2 Sep 2024 14:19:34 +0200 (CEST)","from mail-lj1-f200.google.com (mail-lj1-f200.google.com\n\t[209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-596-ElSEaLOVN5-1fIxbRk3TIw-1; Mon, 02 Sep 2024 08:19:32 -0400","by mail-lj1-f200.google.com with SMTP id\n\t38308e7fff4ca-2f3eaab2d0aso37165261fa.1\n\tfor ;\n\tMon, 02 Sep 2024 05:19:32 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t2adb3069b0e04-5354079b7fdsm1592080e87.38.2024.09.02.05.19.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Sep 2024 05:19:29 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"fa9h+fd6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725279573;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=JBsxP+++m2a9sFfQGWkgEmNyLJBVatWQlCykr4rZ4AQ=;\n\tb=fa9h+fd6tHgR0pE/elifFk7Ic1O9IQTntDU+q5Qrw4X3ECmiZZBYcMmE9n5ch9BFOxQ+28\n\tDxjiwmujlu8lGqn7vgh4AX+qnwsiHP0PtXu5jwU5BUfIjZom2gv+cFGlRU/Q0/hKADyCZM\n\t2vNoXcwexhBUMV6zQNnBLXRZuutPYDw=","X-MC-Unique":"ElSEaLOVN5-1fIxbRk3TIw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725279570; x=1725884370;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=JBsxP+++m2a9sFfQGWkgEmNyLJBVatWQlCykr4rZ4AQ=;\n\tb=IdVBDO3ikMzH0ffOjjHEhQ5/mYhnThVXEzZkOLI533HaYsKfA2vzoae83o63ZKvDzj\n\t+xCORIkBxzLI5NEJSRqTbJl8MDzp+T+NgDvVoTezyQ/q3S+aHYehf52yEGhSbeteK0ce\n\tZiuBK7oNb9hrbUe87b9gb7+6uHNqTIp8hSRTdRorwgnIUJxQsJWmFbFGi7pdpjj5ArrY\n\tFxIVPZXNohGLgb8SFZnHInjurF9fZWZgPahEKJ6VWrNtyl/luPNw635lhZZLL7YvMbDP\n\tlv/Yh/hsKTF3bkMtSrFZE7kX3Uh1VrEhvudesMq/nLbL0OWpothn8BPZtr4iXH1YBbSM\n\t9Rjg==","X-Gm-Message-State":"AOJu0YzDX+iPMljojHveJfD4oomnO15X0bo9nbBXFWqyXwfZ2bwZnZO+\n\tHUYWOj16KxQo05xNow0LJ5tPU+IrmYXcCZYieUk/4oRo9BDI3WsBIbYkB3cNa/5I/qttBSZMNwE\n\t7onwCcDwIX5MPvP8Ta+Mjmhaxuy/NwHnfGHhCTv+AYz+0HJA2ALXjV90ySawNfO0yinEX0d20B5\n\tFtUTPVdTU9p5YAP85cLU/vah9XvnHQoaAOc+zXKsZTBRHv3OXsxCUfEBg=","X-Received":["by 2002:a05:6512:4007:b0:52f:336:e846 with SMTP id\n\t2adb3069b0e04-5353ebb9842mr5046044e87.14.1725279570331; \n\tMon, 02 Sep 2024 05:19:30 -0700 (PDT)","by 2002:a05:6512:4007:b0:52f:336:e846 with SMTP id\n\t2adb3069b0e04-5353ebb9842mr5046029e87.14.1725279569658; \n\tMon, 02 Sep 2024 05:19:29 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IH4xiTPmEELCQ0GWIPO4qUWl8ixFZueszR/JdyxS6HdkmrL/fUf0fYPjmbp2R9yMgAlbgrquw==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","In-Reply-To":"<20240831002048.GN3811@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Sat, 31 Aug 2024 03:20:48 +0300\")","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-15-mzamazal@redhat.com>\n\t<20240831002048.GN3811@pendragon.ideasonboard.com>","Date":"Mon, 02 Sep 2024 14:19:27 +0200","Message-ID":"<87jzfuuu28.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31046,"web_url":"https://patchwork.libcamera.org/comment/31046/","msgid":"<20240902123525.GD4313@pendragon.ideasonboard.com>","date":"2024-09-02T12:35:25","subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nOn Mon, Sep 02, 2024 at 02:19:27PM +0200, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> > On Fri, Aug 30, 2024 at 05:27:11PM +0200, Milan Zamazal wrote:\n> >> The includes that are not used can be removed.\n> >\n> >> Signed-off-by: Milan Zamazal \n> >> ---\n> >> include/libcamera/ipa/ipa_interface.h | 5 -----\n> >> 1 file changed, 5 deletions(-)\n> >> \n> >> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> >> index 7c835e98..2fdc085e 100644\n> >> --- a/include/libcamera/ipa/ipa_interface.h\n> >> +++ b/include/libcamera/ipa/ipa_interface.h\n> >> @@ -7,11 +7,6 @@\n> >> \n> >> #pragma once\n> >> \n> >> -#include \n> >> -#include \n> >> -#include \n> >> -#include \n> >> -\n> >> #include \n> >> #include \n> >\n> > I think all the other includes can be dropped too.\n> \n> I'm not sure. ipa_interface.h is included in the generated files and\n> they rely on the includes (and what is worse, apparently on things\n> included through them). Perhaps this should be fixed by including the\n> corresponding stuff at the right places but I'm worried by the fact that\n> LSP doesn't mark these includes as redundant (apparently for a reason).\n> I would rather not mess with the generated code in this patch series.\n\nWe can handle it in a separate series, but I think it should still be\nfixed.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 75F9AC324C\n\tfor ;\n\tMon, 2 Sep 2024 12:35:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 270ED63471;\n\tMon, 2 Sep 2024 14:35:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8898B618FD\n\tfor ;\n\tMon, 2 Sep 2024 14:35:57 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53A084CE;\n\tMon, 2 Sep 2024 14:34:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BdMIcN1/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725280486;\n\tbh=0vot/AHPf09GEWeC0UjPzOBSIVgbq79biT9fJloczKM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BdMIcN1/oKpzG5W+5VaP6KsJ2ZC/uonYLzdarA8osZRmEqEjdOMIex7kZYiAj1C6y\n\t3IoHAirlZea/k0RLOsectmO8pm7OO+0HF8nkQcOI8N3dmCgxC+hIe/25NvVG5NuK6X\n\tin1J8qF74pQSrNyJwvFxD7hMh1XHz3pIRvCybx8s=","Date":"Mon, 2 Sep 2024 15:35:25 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 14/20] libcamera: ipa: Remove unused includes","Message-ID":"<20240902123525.GD4313@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-15-mzamazal@redhat.com>\n\t<20240831002048.GN3811@pendragon.ideasonboard.com>\n\t<87jzfuuu28.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87jzfuuu28.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]