[{"id":31012,"web_url":"https://patchwork.libcamera.org/comment/31012/","msgid":"<20240831003131.GO3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:31:31","subject":"Re: [PATCH v2 15/20] libcamera: libcamera: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2024 at 05:27:12PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n> ---\n>  src/libcamera/base/event_dispatcher_poll.cpp   | 1 -\n>  src/libcamera/camera.cpp                       | 2 --\n>  src/libcamera/controls.cpp                     | 1 -\n>  src/libcamera/converter/converter_v4l2_m2m.cpp | 1 -\n>  src/libcamera/formats.cpp                      | 3 ---\n>  src/libcamera/ipa_module.cpp                   | 1 -\n>  src/libcamera/ipa_proxy.cpp                    | 1 -\n>  src/libcamera/orientation.cpp                  | 1 -\n>  src/libcamera/pipeline_handler.cpp             | 1 -\n>  src/libcamera/process.cpp                      | 1 -\n>  src/libcamera/sensor/camera_sensor.cpp         | 2 --\n>  src/libcamera/shared_mem_object.cpp            | 1 -\n>  src/libcamera/stream.cpp                       | 2 --\n>  13 files changed, 18 deletions(-)\n> \n> diff --git a/src/libcamera/base/event_dispatcher_poll.cpp b/src/libcamera/base/event_dispatcher_poll.cpp\n> index b737ca7a..86a26f36 100644\n> --- a/src/libcamera/base/event_dispatcher_poll.cpp\n> +++ b/src/libcamera/base/event_dispatcher_poll.cpp\n> @@ -7,7 +7,6 @@\n>  \n>  #include <libcamera/base/event_dispatcher_poll.h>\n>  \n> -#include <algorithm>\n>  #include <chrono>\n\nI think chrono is also unneeded.\n\n>  #include <iomanip>\n\nOne of the very few places where iomanip is actually needed :-) I wonder\nhow we ended up including it in so many places.\n\n>  #include <poll.h>\n\nvector should be added.\n\n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 382a68f7..88210ff3 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -9,7 +9,6 @@\n>  \n>  #include <array>\n>  #include <atomic>\n> -#include <iomanip>\n\nMissing ios, optional and sstream.\n\n>  \n>  #include <libcamera/base/log.h>\n>  #include <libcamera/base/thread.h>\n> @@ -21,7 +20,6 @@\n>  \n>  #include \"libcamera/internal/camera.h\"\n>  #include \"libcamera/internal/camera_controls.h\"\n> -#include \"libcamera/internal/formats.h\"\n>  #include \"libcamera/internal/pipeline_handler.h\"\n>  #include \"libcamera/internal/request.h\"\n>  \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 11d35321..67400797 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -7,7 +7,6 @@\n>  \n>  #include <libcamera/controls.h>\n>  \n> -#include <iomanip>\n>  #include <sstream>\n>  #include <string>\n>  #include <string.h>\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 006ba9f7..e4f656da 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -8,7 +8,6 @@\n>  \n>  #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n>  \n> -#include <algorithm>\n>  #include <limits.h>\n>  \n>  #include <libcamera/base/log.h>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 1d1d9a30..3ee89590 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -7,9 +7,6 @@\n>  \n>  #include \"libcamera/internal/formats.h\"\n>  \n> -#include <algorithm>\n> -#include <errno.h>\n> -\n>  #include <libcamera/base/log.h>\n>  #include <libcamera/base/utils.h>\n>  \n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index 0756b691..86d88a86 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -8,7 +8,6 @@\n>  #include \"libcamera/internal/ipa_module.h\"\n>  \n>  #include <algorithm>\n> -#include <array>\n>  #include <ctype.h>\n>  #include <dlfcn.h>\n>  #include <elf.h>\n> diff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\n> index 69975d8f..85004737 100644\n> --- a/src/libcamera/ipa_proxy.cpp\n> +++ b/src/libcamera/ipa_proxy.cpp\n> @@ -7,7 +7,6 @@\n>  \n>  #include \"libcamera/internal/ipa_proxy.h\"\n>  \n> -#include <string.h>\n>  #include <sys/stat.h>\n>  #include <sys/types.h>\n>  #include <unistd.h>\n> diff --git a/src/libcamera/orientation.cpp b/src/libcamera/orientation.cpp\n> index fd191197..bf960249 100644\n> --- a/src/libcamera/orientation.cpp\n> +++ b/src/libcamera/orientation.cpp\n> @@ -8,7 +8,6 @@\n>  #include <libcamera/orientation.h>\n>  \n>  #include <array>\n> -#include <string>\n>  \n>  /**\n>   * \\file orientation.h\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 1fc22d6a..a63d3503 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -22,7 +22,6 @@\n>  #include \"libcamera/internal/camera.h\"\n>  #include \"libcamera/internal/camera_manager.h\"\n>  #include \"libcamera/internal/device_enumerator.h\"\n> -#include \"libcamera/internal/framebuffer.h\"\n>  #include \"libcamera/internal/media_device.h\"\n>  #include \"libcamera/internal/request.h\"\n>  #include \"libcamera/internal/tracepoints.h\"\n> diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\n> index 86d27b2d..c0f4d49f 100644\n> --- a/src/libcamera/process.cpp\n> +++ b/src/libcamera/process.cpp\n> @@ -10,7 +10,6 @@\n>  #include <algorithm>\n>  #include <dirent.h>\n>  #include <fcntl.h>\n> -#include <iostream>\n>  #include <list>\n>  #include <signal.h>\n>  #include <string.h>\n> diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\n> index c6d7f801..1382081a 100644\n> --- a/src/libcamera/sensor/camera_sensor.cpp\n> +++ b/src/libcamera/sensor/camera_sensor.cpp\n> @@ -10,7 +10,6 @@\n>  \n>  #include <algorithm>\n>  #include <float.h>\n> -#include <iomanip>\n>  #include <limits.h>\n>  #include <math.h>\n>  #include <string.h>\n> @@ -24,7 +23,6 @@\n>  #include \"libcamera/internal/bayer_format.h\"\n>  #include \"libcamera/internal/camera_lens.h\"\n>  #include \"libcamera/internal/camera_sensor_properties.h\"\n> -#include \"libcamera/internal/formats.h\"\n>  #include \"libcamera/internal/sysfs.h\"\n>  \n>  /**\n> diff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\n> index d4c7991a..65b53919 100644\n> --- a/src/libcamera/shared_mem_object.cpp\n> +++ b/src/libcamera/shared_mem_object.cpp\n> @@ -10,7 +10,6 @@\n>  \n>  #include \"libcamera/internal/shared_mem_object.h\"\n>  \n> -#include <stddef.h>\n>  #include <stdint.h>\n>  #include <sys/mman.h>\n>  #include <sys/types.h>\n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index 053cc4b8..e70688f6 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -9,9 +9,7 @@\n>  \n>  #include <algorithm>\n>  #include <array>\n> -#include <iomanip>\n>  #include <limits.h>\n> -#include <sstream>\n\nYou should include ostream.\n\n>  \n>  #include <libcamera/request.h>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93DE0C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 31 Aug 2024 00:32:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AA3D63469;\n\tSat, 31 Aug 2024 02:32:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5980D6341E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 31 Aug 2024 02:32:03 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A53A374C;\n\tSat, 31 Aug 2024 02:30:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"abRn1mpY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725064253;\n\tbh=7DdzCKf4ZSIaHPrsInr1fa8huRxi+qdKd2VAf18tZgQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=abRn1mpYPlpbtQwCO0Z/GNGrxlMXqGY9ufWAxqrXJJCYGSXirwUbymukZXeDt3+f9\n\tEh1GJ9ZEamVz1wwQvVv88K4YBKUr/sZXXumlkGHHDQAmWRsKDRx5CQVg057w4hO+hn\n\tLp9a4s9RRtirAXQQulz5C4DfXiW/YSsUfGtR8sLg=","Date":"Sat, 31 Aug 2024 03:31:31 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 15/20] libcamera: libcamera: Remove unused includes","Message-ID":"<20240831003131.GO3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-16-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-16-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]