[{"id":31010,"web_url":"https://patchwork.libcamera.org/comment/31010/","msgid":"<20240831001945.GM3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:19:45","subject":"Re: [PATCH v2 13/20] libcamera: v4l2: Fix indirect include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:27:10PM +0200, Milan Zamazal wrote:\n> Use the direct include of V4L2PixelFormat.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 56c557b5..2267b6ee 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -24,7 +24,7 @@\n> #include \n> #include \n> \n> -#include \"libcamera/internal/formats.h\"\n> +#include \"libcamera/internal/v4l2_pixelformat.h\"\n> \n> #include \"v4l2_camera.h\"\n> #include \"v4l2_camera_file.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03A04C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:20:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A25FC6345A;\n\tSat, 31 Aug 2024 02:20:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C40B6341E\n\tfor ;\n\tSat, 31 Aug 2024 02:20:18 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F208C74C;\n\tSat, 31 Aug 2024 02:19:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SC8wOz+0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725063549;\n\tbh=1iVKdMZQW0klkDLT3h57xGFh6F06OriBzefhMjqckJM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SC8wOz+0LS/Kr8OFMkLqemHWHzkXkyJ+0Xwc8GiLSpeHHthjpE2UPd4Mfny6T//oA\n\t+yi4LLthE/5bkzvX8Uv0qehOvWcTY4uGCKFJWKCMxeq/kXuPRHmOaUfv8+0hMZ3vvJ\n\tqPTTGtx49PoTNd4MBWB3LrgImkOWdDxvw9qMySgI=","Date":"Sat, 31 Aug 2024 03:19:45 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 13/20] libcamera: v4l2: Fix indirect include","Message-ID":"<20240831001945.GM3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-14-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-14-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]