[{"id":31004,"web_url":"https://patchwork.libcamera.org/comment/31004/","msgid":"<20240831000938.GG3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:09:38","subject":"Re: [PATCH v2 09/20] libcamera: uvcvideo: Formatting improvement","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:27:06PM +0200, Milan Zamazal wrote:\n> The LSP autoformatter doesn't like some of the current formatting, let's\n> make it happy.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 133ff977..706457c0 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -304,8 +304,8 @@ int PipelineHandlerUVC::processControl(ControlList *controls, unsigned int id,\n> \n> \tcase V4L2_CID_EXPOSURE_AUTO: {\n> \t\tint32_t ivalue = value.get()\n> -\t\t\t ? V4L2_EXPOSURE_APERTURE_PRIORITY\n> -\t\t\t : V4L2_EXPOSURE_MANUAL;\n> +\t\t\t\t\t ? V4L2_EXPOSURE_APERTURE_PRIORITY\n> +\t\t\t\t\t : V4L2_EXPOSURE_MANUAL;\n\nThis hinders readability in my opinion.\n\n> \t\tcontrols->set(V4L2_CID_EXPOSURE_AUTO, ivalue);\n> \t\tbreak;\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F037C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:10:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4B1763469;\n\tSat, 31 Aug 2024 02:10:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03A6563456\n\tfor ;\n\tSat, 31 Aug 2024 02:10:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66C1D7E2;\n\tSat, 31 Aug 2024 02:09:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fnegcEpl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725062942;\n\tbh=5h92+kQgfNNenrqQK1JFODmoNHcBD8u+mQUqycWNeGg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fnegcEplcLM/BYQhi2leLO1FFYOigttjP8+HISfLfg7cBytVgT+feAHthyWJVER7Q\n\tDBnd55i3IAjAn2JBCb+xGV4VhCMLFMIahdoNAot2azU3rqaZAKpvEjwqeHKN4SfiOz\n\tU/ldUEX78oSN3dp31dV0CJtmb0yNKZWe0gAH7Abc=","Date":"Sat, 31 Aug 2024 03:09:38 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 09/20] libcamera: uvcvideo: Formatting improvement","Message-ID":"<20240831000938.GG3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-10-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-10-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]