[{"id":31002,"web_url":"https://patchwork.libcamera.org/comment/31002/","msgid":"<20240831000746.GE3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:07:46","subject":"Re: [PATCH v2 07/20] libcamera: libipa: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:27:04PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/libipa/histogram.h | 1 -\n> src/ipa/libipa/matrix.h | 1 -\n> src/ipa/libipa/matrix_interpolator.cpp | 7 -------\n> src/ipa/libipa/matrix_interpolator.h | 2 --\n> src/ipa/libipa/pwl.cpp | 2 --\n> src/ipa/libipa/pwl.h | 3 ---\n> src/ipa/libipa/vector.h | 2 --\n> 7 files changed, 18 deletions(-)\n> \n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 032adca0..6fd64168 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -7,7 +7,6 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> #include \n> #include \n> diff --git a/src/ipa/libipa/matrix.h b/src/ipa/libipa/matrix.h\n> index 8aa8f343..5471e697 100644\n> --- a/src/ipa/libipa/matrix.h\n> +++ b/src/ipa/libipa/matrix.h\n> @@ -7,7 +7,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> \n> diff --git a/src/ipa/libipa/matrix_interpolator.cpp b/src/ipa/libipa/matrix_interpolator.cpp\n> index 04ca177f..d5188f8a 100644\n> --- a/src/ipa/libipa/matrix_interpolator.cpp\n> +++ b/src/ipa/libipa/matrix_interpolator.cpp\n> @@ -6,15 +6,8 @@\n> */\n> #include \"matrix_interpolator.h\"\n> \n> -#include \n> -#include \n> -\n> #include \n> \n> -#include \"libcamera/internal/yaml_parser.h\"\n> -\n> -#include \"matrix.h\"\n> -\n> /**\n> * \\file matrix_interpolator.h\n> * \\brief Helper class for interpolating maps of matrices\n> diff --git a/src/ipa/libipa/matrix_interpolator.h b/src/ipa/libipa/matrix_interpolator.h\n> index 087c4fd1..afbce538 100644\n> --- a/src/ipa/libipa/matrix_interpolator.h\n> +++ b/src/ipa/libipa/matrix_interpolator.h\n> @@ -7,10 +7,8 @@\n> \n> #pragma once\n> \n> -#include \n> #include \n> #include \n> -#include \n> \n> #include \n> \n> diff --git a/src/ipa/libipa/pwl.cpp b/src/ipa/libipa/pwl.cpp\n> index 9b213754..88fe2022 100644\n> --- a/src/ipa/libipa/pwl.cpp\n> +++ b/src/ipa/libipa/pwl.cpp\n> @@ -8,10 +8,8 @@\n> \n> #include \"pwl.h\"\n> \n> -#include \n> #include \n> #include \n> -#include \n> \n> /**\n> * \\file pwl.h\n> diff --git a/src/ipa/libipa/pwl.h b/src/ipa/libipa/pwl.h\n> index b6f93494..d4ec9f4f 100644\n> --- a/src/ipa/libipa/pwl.h\n> +++ b/src/ipa/libipa/pwl.h\n> @@ -7,14 +7,11 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> #include \n> #include \n> #include \n> \n> -#include \"libcamera/internal/yaml_parser.h\"\n> -\n> #include \"vector.h\"\n> \n> namespace libcamera {\n> diff --git a/src/ipa/libipa/vector.h b/src/ipa/libipa/vector.h\n> index 556e0967..d14ad0de 100644\n> --- a/src/ipa/libipa/vector.h\n> +++ b/src/ipa/libipa/vector.h\n> @@ -6,10 +6,8 @@\n> */\n> #pragma once\n> \n> -#include \n> #include \n> #include \n> -#include \n\nYou should include ostream.\n\n> \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBE69C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:08:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D6FEA63469;\n\tSat, 31 Aug 2024 02:08:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA57263456\n\tfor ;\n\tSat, 31 Aug 2024 02:08:19 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAB0074C;\n\tSat, 31 Aug 2024 02:07:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dqK0G6tT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725062829;\n\tbh=zB5Qg3M0c25Ysmmfd0adtpvqHu/vOIJMrC/mypWpuXA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dqK0G6tT0A/X4aizZa9H1jy0H3/6TBLpwPQ+qbvFLA1Wts3rYXSk/tUYzwzIqizHp\n\tsauQZkP9YfCh3/oCLe6B0/iEms0MlBCwGAXin62eGAbokvhaOIsZDNDkotqJVTDauN\n\tIK1+9p6c2/5cN3RshdXi10SatYvhWJ//oVNTRTK0=","Date":"Sat, 31 Aug 2024 03:07:46 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 07/20] libcamera: libipa: Remove unused includes","Message-ID":"<20240831000746.GE3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-8-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-8-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]