[{"id":31000,"web_url":"https://patchwork.libcamera.org/comment/31000/","msgid":"<20240831000133.GC3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:01:33","subject":"Re: [PATCH v2 05/20] libcamera: rkisp1: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:27:02PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/rkisp1/algorithms/agc.h | 1 -\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 --\n> src/ipa/rkisp1/algorithms/ccm.cpp | 4 ----\n> src/ipa/rkisp1/algorithms/dpf.cpp | 2 --\n> src/ipa/rkisp1/rkisp1.cpp | 2 --\n> src/ipa/rkisp1/utils.h | 1 -\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 --\n> 7 files changed, 14 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index d64ff42c..aa86f2c5 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -15,7 +15,6 @@\n> #include \n> \n> #include \"libipa/agc_mean_luminance.h\"\n> -#include \"libipa/histogram.h\"\n> \n> #include \"algorithm.h\"\n> \n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index b40f405f..a5972015 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -8,8 +8,6 @@\n> #include \"awb.h\"\n> \n> #include \n> -#include \n> -#include \n\nI wonder if iomanip was included for std::showpoint, which needs ios.\n\n> \n> #include \n> \n> diff --git a/src/ipa/rkisp1/algorithms/ccm.cpp b/src/ipa/rkisp1/algorithms/ccm.cpp\n> index ca80112a..47a8b7e5 100644\n> --- a/src/ipa/rkisp1/algorithms/ccm.cpp\n> +++ b/src/ipa/rkisp1/algorithms/ccm.cpp\n> @@ -7,10 +7,6 @@\n> \n> #include \"ccm.h\"\n> \n> -#include \n> -#include \n> -#include \n> -#include \n\nWhile at it, is missing.\n\n> #include \n\nvector doesn't seem to be needed.\n\n> \n> #include \n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index 079cc2c3..94080b28 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -7,8 +7,6 @@\n> \n> #include \"dpf.h\"\n> \n> -#include \n> -\n\nBut vector is missing here :-) So are algorithm and string.\n\n> #include \n> \n> #include \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 79ae9289..55269579 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -6,8 +6,6 @@\n> */\n> \n> #include \n> -#include \n> -#include \n\nHere array and chrono are missing.\n\n> #include \n> #include \n> \n> diff --git a/src/ipa/rkisp1/utils.h b/src/ipa/rkisp1/utils.h\n> index 450f2244..5f38b50b 100644\n> --- a/src/ipa/rkisp1/utils.h\n> +++ b/src/ipa/rkisp1/utils.h\n> @@ -8,7 +8,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> #include \n> \n> namespace libcamera {\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 710d9573..5ff8eb9c 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -6,8 +6,6 @@\n> */\n> \n> #include \n> -#include \n> -#include \n> #include \n> #include \n> #include \n\nMissing optional.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4F26C324C\n\tfor ;\n\tSat, 31 Aug 2024 00:02:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F16C263456;\n\tSat, 31 Aug 2024 02:02:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAAA86341E\n\tfor ;\n\tSat, 31 Aug 2024 02:02:07 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 100F174C;\n\tSat, 31 Aug 2024 02:00:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kBYglxgV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725062458;\n\tbh=OdRgSM/bZRVxVk88/PjYFoIDoEreSOozCGGG89K78s8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kBYglxgVi/6Emy4mYJ69JB28/eTeMgH9rBtArnWuYKq/b6IzjjSTv4T+qhajlc+6g\n\tckrFIvzeAMp+22HriaO4defFgnzzKvbV12P+cOfaPxACgEqonmQg6q2maLt93sbiX7\n\tQx9Ex5bvYbIH1yBgP+2lTs4dy+h2JI5uyX7u8rQU=","Date":"Sat, 31 Aug 2024 03:01:33 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 05/20] libcamera: rkisp1: Remove unused includes","Message-ID":"<20240831000133.GC3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-6-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-6-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]