[{"id":30998,"web_url":"https://patchwork.libcamera.org/comment/30998/","msgid":"<20240830233202.GA3811@pendragon.ideasonboard.com>","date":"2024-08-30T23:32:02","subject":"Re: [PATCH v2 02/20] libcamera: ipu3: Remove unused includes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2024 at 05:26:59PM +0200, Milan Zamazal wrote:\n> The includes that are not used can be removed.\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/ipu3/algorithms/af.cpp | 3 ---\n> src/ipa/ipu3/algorithms/agc.cpp | 1 -\n> src/ipa/ipu3/algorithms/blc.cpp | 2 --\n> src/ipa/ipu3/ipu3.cpp | 5 -----\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 1 -\n> 5 files changed, 12 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/algorithms/af.cpp b/src/ipa/ipu3/algorithms/af.cpp\n> index 29eb7355..cf68fb59 100644\n> --- a/src/ipa/ipu3/algorithms/af.cpp\n> +++ b/src/ipa/ipu3/algorithms/af.cpp\n> @@ -11,7 +11,6 @@\n> #include \n> #include \n> #include \n> -#include \n> #include \n> #include \n> #include \n> @@ -23,8 +22,6 @@\n> \n> #include \n> \n> -#include \"libipa/histogram.h\"\n> -\n> /**\n> * \\file af.h\n> */\n> diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\n> index 0e0114f6..3378c4fd 100644\n> --- a/src/ipa/ipu3/algorithms/agc.cpp\n> +++ b/src/ipa/ipu3/algorithms/agc.cpp\n> @@ -9,7 +9,6 @@\n> \n> #include \n> #include \n> -#include \n> \n> #include \n> #include \n> diff --git a/src/ipa/ipu3/algorithms/blc.cpp b/src/ipa/ipu3/algorithms/blc.cpp\n> index 257f40e2..fa4b9272 100644\n> --- a/src/ipa/ipu3/algorithms/blc.cpp\n> +++ b/src/ipa/ipu3/algorithms/blc.cpp\n> @@ -7,8 +7,6 @@\n> \n> #include \"blc.h\"\n> \n> -#include \n> -\n> /**\n> * \\file blc.h\n> * \\brief IPU3 Black Level Correction control\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index cdcdf1fb..656c51fc 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -32,12 +32,7 @@\n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> #include \"libcamera/internal/yaml_parser.h\"\n> \n> -#include \"algorithms/af.h\"\n> #include \"algorithms/agc.h\"\n\nagc.h isn't used, but you need to include module.h.\n\nWith that,\n\nReviewed-by: Laurent Pinchart \n\n> -#include \"algorithms/algorithm.h\"\n> -#include \"algorithms/awb.h\"\n> -#include \"algorithms/blc.h\"\n> -#include \"algorithms/tone_mapping.h\"\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> #include \"ipa_context.h\"\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 2071c338..29172f34 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -6,7 +6,6 @@\n> */\n> \n> #include \n> -#include \n> #include \n> #include \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2053C324C\n\tfor ;\n\tFri, 30 Aug 2024 23:32:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0AA063466;\n\tSat, 31 Aug 2024 01:32:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13C2E6341E\n\tfor ;\n\tSat, 31 Aug 2024 01:32:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7689B74C;\n\tSat, 31 Aug 2024 01:31:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"A2IUGl6c\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725060684;\n\tbh=x6T2fbYved8MOlFwt1GAR+FlkHG17uIZ9PN377ghVYo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=A2IUGl6cUnUaoUt0ZjdJGjCy/aNVIuW3Rucf43Vur+CEq6HrAgqPWGPMbUO++QOQ+\n\teOz+QRrXHjRasHP2ADBgA1C7o9UWMGPuV641sQJJ7v0N9o0Axp2cfU9NUw7qvKdUwS\n\t6ykSvUjrXdfdC2M9q+hNXwM8+sIembE3rsEUPBjI=","Date":"Sat, 31 Aug 2024 02:32:02 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 02/20] libcamera: ipu3: Remove unused includes","Message-ID":"<20240830233202.GA3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-3-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-3-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]