[{"id":31007,"web_url":"https://patchwork.libcamera.org/comment/31007/","msgid":"<20240831001718.GJ3811@pendragon.ideasonboard.com>","date":"2024-08-31T00:17:18","subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Aug 30, 2024 at 05:26:58PM +0200, Milan Zamazal wrote:\n> generated_serializer_test.cpp uses iostream without including it,\n> relying on imports from another included header.  Let's include iostream\n\nDouble space.\n\n> there.\n> \n> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  .../generated_serializer/generated_serializer_test.cpp           | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> index 4b11d67f..dd696885 100644\n> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> @@ -6,6 +6,7 @@\n>   */\n>  \n>  #include <algorithm>\n> +#include <iostream>\n>  #include <tuple>\n>  #include <vector>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB863C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 31 Aug 2024 00:17:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53FB363469;\n\tSat, 31 Aug 2024 02:17:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA3B56341E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 31 Aug 2024 02:17:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FAAB74C;\n\tSat, 31 Aug 2024 02:16:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lnd4bEBJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725063400;\n\tbh=no9KnNT9+chCIx4gWeacujqlS3R9Hsy8QjSVdJKeKzY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Lnd4bEBJTVrVW0PlUcYH6B/NcGjyZR0HdGZ51JhuI8/THkKIl/N24UjbUtxGR0pJq\n\tCHyvSqGZsP29t6Gtcwd7K6VWnxCLq6yedGFTrI3xDJWF6sZjS2Ik/hox+5nQF82KPw\n\tUfkHJtSUypY+V68ZYtVX71R0TnNGYLODe7QeI564=","Date":"Sat, 31 Aug 2024 03:17:18 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","Message-ID":"<20240831001718.GJ3811@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-2-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240830152721.1420313-2-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31039,"web_url":"https://patchwork.libcamera.org/comment/31039/","msgid":"<87y14av0zj.fsf@redhat.com>","date":"2024-09-02T09:49:52","subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Hi Laurent,\n\nthank you for review.\n\nLaurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> On Fri, Aug 30, 2024 at 05:26:58PM +0200, Milan Zamazal wrote:\n>> generated_serializer_test.cpp uses iostream without including it,\n>> relying on imports from another included header.  Let's include iostream\n>\n> Double space.\n\nThis is intentional.  Emacs uses this (American?) style to distinguish\nsentences from abbreviations (and there are opinions that it is better\nreadable on computer screens).  I don't use it in source code comments\nbut use it elsewhere.\n\n>> there.\n>> \n>> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>\n>> ---\n>>  .../generated_serializer/generated_serializer_test.cpp           | 1 +\n>>  1 file changed, 1 insertion(+)\n>> \n>> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> index 4b11d67f..dd696885 100644\n>> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> @@ -6,6 +6,7 @@\n>>   */\n>>  \n>>  #include <algorithm>\n>> +#include <iostream>\n>>  #include <tuple>\n>>  #include <vector>\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F324FC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Sep 2024 09:50:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EBEEF634CB;\n\tMon,  2 Sep 2024 11:49:59 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49F45618FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Sep 2024 11:49:58 +0200 (CEST)","from mail-lj1-f199.google.com (mail-lj1-f199.google.com\n\t[209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-684-BJGREKq3P7y0vAifCUlVLA-1; Mon, 02 Sep 2024 05:49:55 -0400","by mail-lj1-f199.google.com with SMTP id\n\t38308e7fff4ca-2f3f6d581fbso45651811fa.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 02 Sep 2024 02:49:55 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-a89891da22bsm534301966b.182.2024.09.02.02.49.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Sep 2024 02:49:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BPckKKA1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725270597;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=iVXD20E3JCtnhzTxuO1vk26B8LmIpXHdaNQtgmmuiHQ=;\n\tb=BPckKKA1ZgLyVlLwjXMBQVPHEw2n285W4OgvJU5AwcY82uJyChuoQ+MfWH29DM9ESlJw9A\n\tVjRxUAoyuhEdlPjc52+JbOYn2Nm3VtnbrEwZb7zNcGGzSrIocxsJgAXz3X6oeTn/xjP1d/\n\tpyJDoQmUKMzuIhnsLDIFlCIGO7JQxFY=","X-MC-Unique":"BJGREKq3P7y0vAifCUlVLA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725270594; x=1725875394;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iVXD20E3JCtnhzTxuO1vk26B8LmIpXHdaNQtgmmuiHQ=;\n\tb=YKlC1m8X2kSQgSODMGEUILCVVeue9M5Kzz6GrEfsqA2IrABnvu9BjzATj4navOJusF\n\tlPL2DzxNtIwHan8TeFNerGPguyoURt1yHzMpsDY07Ycwi58l7GkzcAxme2+vKotShVf3\n\tLTtc2MBap0kNMnKGOC7AOkwmex9Zjjls/Yep5kKzKLygksOlzEejtv/a/ffLsuk+ltbN\n\t6lyNATEduJ/HvgJB3ELOloNGUPPwog6fjqlMYDH10BfdEk7MdGHEmxMyY1bcmSx3o+vf\n\tFf+5PcgF5jdyqBlVzmJi7X06VoFF0JSejeEourUKfeZyPxekGTQCNLdOrNlCfQLjkbu8\n\t8PIg==","X-Gm-Message-State":"AOJu0Yxmrj7b0hTEHFv6BLtH80YT6vzWRrVjxbtlBn+XxsQUEvAZKUdF\n\twr99GPF6cMntbPm6gXtW43AC72HJrazSLTL/CpWFQtwptnGgZvtDDqoF6h+fygf6jmaQmjpPW5Q\n\tpYThBbMLNX/VTtibvQf06bP1Z/m0lStHzvm2mgZxsuo3zQSPIjQPC5C0if/O7ef2ki5gXYHh+iU\n\tJ/EDC2XliWVM+q5P1FbaxxrY1NwPs3hb8xWcex44tQOUlNfGH8ohsZKOU=","X-Received":["by 2002:a2e:be2c:0:b0:2ee:52f4:266 with SMTP id\n\t38308e7fff4ca-2f6105c47e0mr127407531fa.3.1725270593948; \n\tMon, 02 Sep 2024 02:49:53 -0700 (PDT)","by 2002:a2e:be2c:0:b0:2ee:52f4:266 with SMTP id\n\t38308e7fff4ca-2f6105c47e0mr127407291fa.3.1725270593395; \n\tMon, 02 Sep 2024 02:49:53 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IGf1VWaUtPSPQZHpfxOaM8lFYi44vRRg7EkFC37ExjPSzCmFMtnqXVoeUlPiU6u/LXtsr3SMg==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","In-Reply-To":"<20240831001718.GJ3811@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Sat, 31 Aug 2024 03:17:18 +0300\")","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-2-mzamazal@redhat.com>\n\t<20240831001718.GJ3811@pendragon.ideasonboard.com>","Date":"Mon, 02 Sep 2024 11:49:52 +0200","Message-ID":"<87y14av0zj.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31045,"web_url":"https://patchwork.libcamera.org/comment/31045/","msgid":"<20240902123407.GC4313@pendragon.ideasonboard.com>","date":"2024-09-02T12:34:07","subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 02, 2024 at 11:49:52AM +0200, Milan Zamazal wrote:\n> Laurent Pinchart writes:\n> > On Fri, Aug 30, 2024 at 05:26:58PM +0200, Milan Zamazal wrote:\n> >> generated_serializer_test.cpp uses iostream without including it,\n> >> relying on imports from another included header.  Let's include iostream\n> >\n> > Double space.\n> \n> This is intentional.  Emacs uses this (American?) style to distinguish\n> sentences from abbreviations (and there are opinions that it is better\n> readable on computer screens).  I don't use it in source code comments\n> but use it elsewhere.\n\nSo the Americans messed up not just the spelling, for also the\ntypography ? :-) Jokes aside, you should switch to vim. Jokes aside\nagain, I won't insist on reformatting commit messages for that, even if\nit looks completely alien to me (and thus hinders readability). It would\nbe more annoying in comments in code or in documentation.\n\n> >> there.\n> >> \n> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n> >\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> >\n> >> ---\n> >>  .../generated_serializer/generated_serializer_test.cpp           | 1 +\n> >>  1 file changed, 1 insertion(+)\n> >> \n> >> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> >> index 4b11d67f..dd696885 100644\n> >> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n> >> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> >> @@ -6,6 +6,7 @@\n> >>   */\n> >>  \n> >>  #include <algorithm>\n> >> +#include <iostream>\n> >>  #include <tuple>\n> >>  #include <vector>\n> >>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 272ADC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Sep 2024 12:34:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FD69634CB;\n\tMon,  2 Sep 2024 14:34:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E84AB63471\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Sep 2024 14:34:39 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89B964CE;\n\tMon,  2 Sep 2024 14:33:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FL32Rk0p\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1725280408;\n\tbh=BlbbLl283UCaXobpS7B5SO6Kpe+9i7iPkSqE54AUCFk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FL32Rk0pRe3AoCJ/oGgBk6LGW92rY1YOqrMlcZEpeRCoACTsg94XPzmDIGuTNOsL6\n\tR7BVOw0jA5uJ5QLqmOSZ2ZvTdRnmZbd++jKr9xxvPL8PAgacBaC9XfQz5tR5Fdwzzo\n\tpdJ+l2ydmK8etmlNBMdhK/9A67njeAfDqozZIpZo=","Date":"Mon, 2 Sep 2024 15:34:07 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Milan Zamazal <mzamazal@redhat.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","Message-ID":"<20240902123407.GC4313@pendragon.ideasonboard.com>","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-2-mzamazal@redhat.com>\n\t<20240831001718.GJ3811@pendragon.ideasonboard.com>\n\t<87y14av0zj.fsf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87y14av0zj.fsf@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":31057,"web_url":"https://patchwork.libcamera.org/comment/31057/","msgid":"<87frqit3sp.fsf@redhat.com>","date":"2024-09-02T16:32:06","subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:\n\n> On Mon, Sep 02, 2024 at 11:49:52AM +0200, Milan Zamazal wrote:\n>> Laurent Pinchart writes:\n>> > On Fri, Aug 30, 2024 at 05:26:58PM +0200, Milan Zamazal wrote:\n>\n>> >> generated_serializer_test.cpp uses iostream without including it,\n>> >> relying on imports from another included header.  Let's include iostream\n>> >\n>> > Double space.\n>> \n>> This is intentional.  Emacs uses this (American?) style to distinguish\n>> sentences from abbreviations (and there are opinions that it is better\n>> readable on computer screens).  I don't use it in source code comments\n>> but use it elsewhere.\n>\n> So the Americans messed up not just the spelling, for also the\n> typography ? :-) Jokes aside, you should switch to vim. \n\nLast time I tried I couldn't move around using my Dvorak keyboard. :-)\n\n> Jokes aside again, I won't insist on reformatting commit messages for\n> that, even if it looks completely alien to me\n\nIt seems larger spaces after sentences become old fashioned.  But it's\nno way something exotic, it's what e.g. TeX uses by default IIRC (and\nyes, it can be changed with \\frenchspacing, to make us all happy :-)).\n\n> (and thus hinders readability).\n\nI'd say what really hinders readability is using camelCase in a language\nthat uses snake_case in its standard library ;-).\n\n> It would be more annoying in comments in code or in documentation.\n\nYes, where consistency is needed, it should be respected.\n\n>> >> there.\n>> >> \n>> >> Signed-off-by: Milan Zamazal <mzamazal@redhat.com>\n>> >\n>> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>> >\n>> >> ---\n>> >>  .../generated_serializer/generated_serializer_test.cpp           | 1 +\n>> >>  1 file changed, 1 insertion(+)\n>> >> \n>> >> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> >> index 4b11d67f..dd696885 100644\n>> >> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> >> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n>> >> @@ -6,6 +6,7 @@\n>> >>   */\n>> >>  \n>> >>  #include <algorithm>\n>> >> +#include <iostream>\n>> >>  #include <tuple>\n>> >>  #include <vector>\n>> >>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA075BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon,  2 Sep 2024 16:32:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D321C618FF;\n\tMon,  2 Sep 2024 18:32:13 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB518618FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon,  2 Sep 2024 18:32:11 +0200 (CEST)","from mail-wm1-f71.google.com (mail-wm1-f71.google.com\n\t[209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-333-If0mv83TO8qiMik5w6h8JQ-1; Mon, 02 Sep 2024 12:32:09 -0400","by mail-wm1-f71.google.com with SMTP id\n\t5b1f17b1804b1-42bb68e1706so41024355e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 02 Sep 2024 09:32:09 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42bb6e36626sm142902145e9.47.2024.09.02.09.32.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 02 Sep 2024 09:32:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"gw7SN00B\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725294730;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=gaJDuypLlf0XEIVq1fWcvi2JyZISauhqWxl4QLRKl/I=;\n\tb=gw7SN00BgRU/XPnSuyljTB8EC+Jt4w5gmTDhQ84/M/sBfONrjaVQzJyb5qRxQfElrZpFXU\n\tc5hB6BDHBJZOL8RdlzcCwMqdOHP0cp3s1C35yuT+7Jy0FCMRRwfAphimdB1DQpRR06hMWy\n\tQTXQf6npeRml1mGG+77Ddy41s4uuEdQ=","X-MC-Unique":"If0mv83TO8qiMik5w6h8JQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1725294728; x=1725899528;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=gaJDuypLlf0XEIVq1fWcvi2JyZISauhqWxl4QLRKl/I=;\n\tb=aTZ96pPaVkZJQBZFKYdhe2IAkLDPn4pIGsZjVLHotGK7qbCfq32KDT8+/PYW00eMU2\n\tf4dftGAJALmHci6HlSXZJ2GOyTvbFDzYa9VzqllnRionpynChxrbIj5uV0+ptTmKvJhO\n\txxiMHnWfOwi25MroGUP4btig01V7WtUaaiqCj4TlMOSdWeMbR5Ty12o5GOmgNJytbbjG\n\tSmro8EK0oVREyK3hzos5HKwpWVFrx+XwhArcXyfxXut0eIdi/f3GXdWgSu+1xL21q/sG\n\t1QNe++6Y334adJGh10Phsg4zq0P/lNP4wNLzHwUdsG82c+oAOnHlvkmYolOUMDQzQO1+\n\tCatw==","X-Gm-Message-State":"AOJu0Ywqy8mIhlAgxc0lIQvApJxBEziIo9HPKyacLoXAC0cvhy6G1m1K\n\tkR4hZoZM3p0E3QDbGFUoXAimngSyjXhoDmUwacSmM64/lTp+NMUj+QozCjD01LUxBVb+IFqwO9q\n\tooJX31ZtauGTv2MY4xgMS+e5cYWQtQyOFXqfBR1B4F2JP2zJgWgtU+ubv1SLARMQ/Ve7eDIGp9x\n\tR6eRXGBCTg4SQbdNVxoPhZ4MxyB0ig1fBvSgBWjtkVRyP6hTvu24/MjSg=","X-Received":["by 2002:a05:600c:4ecb:b0:428:e09d:3c with SMTP id\n\t5b1f17b1804b1-42c88108630mr5505535e9.33.1725294728207; \n\tMon, 02 Sep 2024 09:32:08 -0700 (PDT)","by 2002:a05:600c:4ecb:b0:428:e09d:3c with SMTP id\n\t5b1f17b1804b1-42c88108630mr5505275e9.33.1725294727699; \n\tMon, 02 Sep 2024 09:32:07 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFv+sKTnABSDkPHK1yUHY541PSxYrUSIZyDHbtVCLKvgyDypKccJ6SGH6hTf1yz2Nqt37tLAQ==","From":"Milan Zamazal <mzamazal@redhat.com>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 01/20] tests: Add a missing iostream include","In-Reply-To":"<20240902123407.GC4313@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Mon, 2 Sep 2024 15:34:07 +0300\")","References":"<20240830152721.1420313-1-mzamazal@redhat.com>\n\t<20240830152721.1420313-2-mzamazal@redhat.com>\n\t<20240831001718.GJ3811@pendragon.ideasonboard.com>\n\t<87y14av0zj.fsf@redhat.com>\n\t<20240902123407.GC4313@pendragon.ideasonboard.com>","Date":"Mon, 02 Sep 2024 18:32:06 +0200","Message-ID":"<87frqit3sp.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]