[{"id":2802,"web_url":"https://patchwork.libcamera.org/comment/2802/","msgid":"<20191006185919.6wc4fiiqb4l2367v@uno.localdomain>","date":"2019-10-06T18:59:19","subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: timer: Allow\n\trestarting a timer before expiration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sun, Oct 06, 2019 at 08:32:22AM +0300, Laurent Pinchart wrote:\n> The Timer API allows restarting a timer before expiration. This isn't\n> correctly implemented, fix it.\n\nHow come the timer.cpp test which test restarts was not failing ?\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/timer.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/src/libcamera/timer.cpp b/src/libcamera/timer.cpp\n> index 8c74e1015e43..5d4e52713e6e 100644\n> --- a/src/libcamera/timer.cpp\n> +++ b/src/libcamera/timer.cpp\n> @@ -75,6 +75,9 @@ void Timer::start(std::chrono::milliseconds duration)\n> \t\t<< duration.count() << \": deadline \"\n> \t\t<< utils::time_point_to_string(deadline_);\n>\n> +\tif (isRunning())\n> +\t\tunregisterTimer();\n> +\n> \tregisterTimer();\n> }\n>\n> @@ -88,6 +91,9 @@ void Timer::start(std::chrono::milliseconds duration)\n> */\n> void Timer::stop()\n> {\n> +\tif (!isRunning())\n> +\t\treturn;\n> +\n> \tunregisterTimer();\n> }\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8AC360E1E\n\tfor ;\n\tSun, 6 Oct 2019 20:57:33 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 79AFCFF803;\n\tSun, 6 Oct 2019 18:57:33 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sun, 6 Oct 2019 20:59:19 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191006185919.6wc4fiiqb4l2367v@uno.localdomain>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>\n\t<20191006053226.8976-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"e4cu72ytuh6jlzk5\"","Content-Disposition":"inline","In-Reply-To":"<20191006053226.8976-6-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: timer: Allow\n\trestarting a timer before expiration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Oct 2019 18:57:34 -0000"}},{"id":2811,"web_url":"https://patchwork.libcamera.org/comment/2811/","msgid":"<20191007030104.GI4740@pendragon.ideasonboard.com>","date":"2019-10-07T03:01:04","subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: timer: Allow\n\trestarting a timer before expiration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Sun, Oct 06, 2019 at 08:59:19PM +0200, Jacopo Mondi wrote:\n> On Sun, Oct 06, 2019 at 08:32:22AM +0300, Laurent Pinchart wrote:\n> > The Timer API allows restarting a timer before expiration. This isn't\n> > correctly implemented, fix it.\n> \n> How come the timer.cpp test which test restarts was not failing ?\n\nBecause it was testing restart after expiration, not before it.\n\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/timer.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/libcamera/timer.cpp b/src/libcamera/timer.cpp\n> > index 8c74e1015e43..5d4e52713e6e 100644\n> > --- a/src/libcamera/timer.cpp\n> > +++ b/src/libcamera/timer.cpp\n> > @@ -75,6 +75,9 @@ void Timer::start(std::chrono::milliseconds duration)\n> > \t\t<< duration.count() << \": deadline \"\n> > \t\t<< utils::time_point_to_string(deadline_);\n> >\n> > +\tif (isRunning())\n> > +\t\tunregisterTimer();\n> > +\n> > \tregisterTimer();\n> > }\n> >\n> > @@ -88,6 +91,9 @@ void Timer::start(std::chrono::milliseconds duration)\n> > */\n> > void Timer::stop()\n> > {\n> > +\tif (!isRunning())\n> > +\t\treturn;\n> > +\n> > \tunregisterTimer();\n> > }\n> >","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E30A6157C\n\tfor ;\n\tMon, 7 Oct 2019 05:01:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(modemcable151.96-160-184.mc.videotron.ca [184.160.96.151])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82E4BDD;\n\tMon, 7 Oct 2019 05:01:07 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570417268;\n\tbh=iXrbuZVGgSiDyj/vDp0eiIPDmiLUHYdyqZGjzLyoDy0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Vxg2jAASraNHxTXMrpOjo0d9hQfxMTy0TdYEOzVzWFVg9yM/IMYy0Snex9OJCJemV\n\t2e6r3RZXYj9HWEjzUnb2CHPlfgu36jqQHrAbiMNBZEFeydTBinaU0/ujRRfeNjSN3v\n\tb/ycDetIyuUMjyzRbM3Sz9h2PjmFYGzUxU5s2CXA=","Date":"Mon, 7 Oct 2019 06:01:04 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191007030104.GI4740@pendragon.ideasonboard.com>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>\n\t<20191006053226.8976-6-laurent.pinchart@ideasonboard.com>\n\t<20191006185919.6wc4fiiqb4l2367v@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191006185919.6wc4fiiqb4l2367v@uno.localdomain>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: timer: Allow\n\trestarting a timer before expiration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 07 Oct 2019 03:01:08 -0000"}}]