[{"id":2801,"web_url":"https://patchwork.libcamera.org/comment/2801/","msgid":"<20191006185752.fsjuyqzt5my67jkn@uno.localdomain>","date":"2019-10-06T18:58:01","subject":"Re: [libcamera-devel] [PATCH 3/9] test: timer: Test that deadline()\n\tisn't reset upon time out","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Sun, Oct 06, 2019 at 08:32:20AM +0300, Laurent Pinchart wrote:\n> Verify that the timer deadline stays valid after the timer expires. As\n> the test now uses the deadline in order to compute the jitter, the\n> interval_ field isn't used anymore and can be removed.\n>\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/timer.cpp | 9 +++------\n> 1 file changed, 3 insertions(+), 6 deletions(-)\n>\n> diff --git a/test/timer.cpp b/test/timer.cpp\n> index af922cb371cd..d4f16a9bdd97 100644\n> --- a/test/timer.cpp\n> +++ b/test/timer.cpp\n> @@ -21,14 +21,13 @@ class ManagedTimer : public Timer\n> {\n> public:\n> \tManagedTimer()\n> -\t\t: Timer(), interval_(0)\n> +\t\t: Timer()\n> \t{\n> \t\ttimeout.connect(this, &ManagedTimer::timeoutHandler);\n> \t}\n>\n> \tvoid start(int msec)\n> \t{\n> -\t\tinterval_ = msec;\n> \t\tstart_ = std::chrono::steady_clock::now();\n> \t\texpiration_ = std::chrono::steady_clock::time_point();\n>\n> @@ -37,9 +36,8 @@ public:\n>\n> \tint jitter()\n> \t{\n> -\t\tstd::chrono::steady_clock::duration duration = expiration_ - start_;\n> -\t\tint msecs = std::chrono::duration_cast(duration).count();\n> -\t\treturn abs(msecs - interval_);\n> +\t\tstd::chrono::steady_clock::duration duration = expiration_ - deadline();\n> +\t\treturn abs(std::chrono::duration_cast(duration).count());\n> \t}\n>\n> private:\n> @@ -48,7 +46,6 @@ private:\n> \t\texpiration_ = std::chrono::steady_clock::now();\n> \t}\n>\n> -\tint interval_;\n> \tstd::chrono::steady_clock::time_point start_;\n> \tstd::chrono::steady_clock::time_point expiration_;\n> };\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E56660E1E\n\tfor ;\n\tSun, 6 Oct 2019 20:56:25 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 534CC60008;\n\tSun, 6 Oct 2019 18:56:24 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sun, 6 Oct 2019 20:58:01 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191006185752.fsjuyqzt5my67jkn@uno.localdomain>","References":"<20191006053226.8976-1-laurent.pinchart@ideasonboard.com>\n\t<20191006053226.8976-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"jj4nw5nrafgeef2k\"","Content-Disposition":"inline","In-Reply-To":"<20191006053226.8976-4-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 3/9] test: timer: Test that deadline()\n\tisn't reset upon time out","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 06 Oct 2019 18:56:25 -0000"}}]