[{"id":2791,"web_url":"https://patchwork.libcamera.org/comment/2791/","msgid":"<20191005165034.GC11154@pendragon.ideasonboard.com>","date":"2019-10-05T16:50:34","subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix\n\tdocumentation of AwbEnable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sat, Oct 05, 2019 at 06:47:05PM +0200, Niklas Söderlund wrote:\n> Align the wording of the documentation for the AwbEnable control with\n> review comments for similar controls.\n> \n> Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/controls.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 727fdbd9450d2f40..e36410771b750fdb 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -190,7 +190,7 @@ std::string ControlValue::toString() const\n>   * \\var AwbEnable\n>   * ControlType: Bool\n>   *\n> - * Enables or disables the AWB. See also \\a libcamera::ControlId::ManualGain\n> + * Enable or disable the AWB. See also \\a libcamera::ControlId::ManualGain\n>   */\n>  \n>  /**","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A8FD60BC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  5 Oct 2019 18:50:49 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(modemcable151.96-160-184.mc.videotron.ca [184.160.96.151])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A5379DD;\n\tSat,  5 Oct 2019 18:50:48 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570294249;\n\tbh=usMngfhiAsulLoZKmZV6qWdYO023jDppqGsD1YTPH0M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PqT+Qh4/RrKATbNzLlNgzlLyfW6YTbGeh83sMVGc4Ou7PNPMkYxfTZd0Dz1zXZmgS\n\t7luzCjx1kdocfJ+maPaFwcD4TjyOU/Vj1Z0kEt6YempkO5Qtokh5nU8+qj+L/Q7fwW\n\tso4Ixcbe2tTXignf88sbtWwDk5VmW4nfaEW/Adck=","Date":"Sat, 5 Oct 2019 19:50:34 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191005165034.GC11154@pendragon.ideasonboard.com>","References":"<20191005164705.1396897-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191005164705.1396897-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: controls: Fix\n\tdocumentation of AwbEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 05 Oct 2019 16:50:49 -0000"}}]