[{"id":30914,"web_url":"https://patchwork.libcamera.org/comment/30914/","msgid":"","date":"2024-08-27T08:27:31","subject":"Re: [PATCH] utils: update-kernel-headers: Support relative path to\n\tkernel git tree","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent\n\nThank you for the patch.\n\nOn 27/08/24 2:52 am, Laurent Pinchart wrote:\n> When given a relative path to the kernel git tree,\n> update-kernel-headers.sh fails to execute the headers_install.sh script\n> from the kernel sources. Fix it by turning the kernel directory into an\n> absolute path.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n> ---\n> utils/update-kernel-headers.sh | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> index 8405be0ac923..9a64dfb5698c 100755\n> --- a/utils/update-kernel-headers.sh\n> +++ b/utils/update-kernel-headers.sh\n> @@ -9,7 +9,7 @@ if [ $# != 1 ] ; then\n> fi\n> \n> header_dir=\"$(dirname \"$(realpath \"$0\")\")/../include/linux\"\n> -kernel_dir=\"$1\"\n> +kernel_dir=\"$(realpath \"$1\")\"\n> \n> # Bail out if the directory doesn't contain kernel sources\n> line=$(head -3 \"${kernel_dir}/Kbuild\" 2>/dev/null | tail -1)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32015C324C\n\tfor ;\n\tTue, 27 Aug 2024 08:27:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E7EE6344E;\n\tTue, 27 Aug 2024 10:27:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 97CC361901\n\tfor ;\n\tTue, 27 Aug 2024 10:27:35 +0200 (CEST)","from [IPV6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f] (unknown\n\t[IPv6:2405:201:2015:f873:55d7:c02e:b2eb:ee3f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5166C3D5;\n\tTue, 27 Aug 2024 10:26:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BpAbAhtg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724747188;\n\tbh=2RmbcmH8oPxYb3npngu+YJHBjZB2uPRo8ZZt8fQZnI8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=BpAbAhtg3Xyap0oDCWt2HTjutoHt0613zKLy5K/JIXCK7uuuTWCWJb81iPGULp4k0\n\tsap3h35JuwH5emgs4dP2x00f3KmeVrOVXIMkda3Y8YyZ3Vhuinck9pCzbQLQ60I1ws\n\tH4t/gvLxD738AhHrAHtrnjyMjqJNSg2X9xjFKMls=","Message-ID":"","Date":"Tue, 27 Aug 2024 13:57:31 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] utils: update-kernel-headers: Support relative path to\n\tkernel git tree","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240826212245.18922-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Umang Jain ","In-Reply-To":"<20240826212245.18922-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30915,"web_url":"https://patchwork.libcamera.org/comment/30915/","msgid":"","date":"2024-08-27T09:13:33","subject":"Re: [PATCH] utils: update-kernel-headers: Support relative path to\n\tkernel git tree","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"On Tue, Aug 27, 2024 at 01:57:31PM GMT, Umang Jain wrote:\n> Hi Laurent\n>\n> Thank you for the patch.\n>\n> On 27/08/24 2:52 am, Laurent Pinchart wrote:\n> > When given a relative path to the kernel git tree,\n> > update-kernel-headers.sh fails to execute the headers_install.sh script\n> > from the kernel sources. Fix it by turning the kernel directory into an\n> > absolute path.\n> >\n> > Signed-off-by: Laurent Pinchart \n>\n> Reviewed-by: Umang Jain \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> > ---\n> > utils/update-kernel-headers.sh | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/utils/update-kernel-headers.sh b/utils/update-kernel-headers.sh\n> > index 8405be0ac923..9a64dfb5698c 100755\n> > --- a/utils/update-kernel-headers.sh\n> > +++ b/utils/update-kernel-headers.sh\n> > @@ -9,7 +9,7 @@ if [ $# != 1 ] ; then\n> > fi\n> > header_dir=\"$(dirname \"$(realpath \"$0\")\")/../include/linux\"\n> > -kernel_dir=\"$1\"\n> > +kernel_dir=\"$(realpath \"$1\")\"\n> > # Bail out if the directory doesn't contain kernel sources\n> > line=$(head -3 \"${kernel_dir}/Kbuild\" 2>/dev/null | tail -1)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5096AC323E\n\tfor ;\n\tTue, 27 Aug 2024 09:13:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 31E4163457;\n\tTue, 27 Aug 2024 11:13:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFB626344A\n\tfor ;\n\tTue, 27 Aug 2024 11:13:36 +0200 (CEST)","from ideasonboard.com (mob-5-90-141-165.net.vodafone.it\n\t[5.90.141.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6CD59FF;\n\tTue, 27 Aug 2024 11:12:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oktUO/vP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724749950;\n\tbh=YMQpGU0gUtaHQQWP3wImwvlEw1BXwu1KK4cISOwUKDk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oktUO/vPJoW19H5ygOSOvfxvKuQ8YSfz4q9KrDo02WIHzfS1C++o/G/fWhBFIACbs\n\tVGL/cSZb9MAZrWMhdRV874ibuAN0+J78TdIEYS9UUG+/nx9cqvtZ/+nVQoAx39rPdV\n\teAOR4pMzEWxEYtmSj92EB0/2eOieeQfoFtlp7DMU=","Date":"Tue, 27 Aug 2024 11:13:33 +0200","From":"Jacopo Mondi ","To":"Umang Jain ","Cc":"Laurent Pinchart , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] utils: update-kernel-headers: Support relative path to\n\tkernel git tree","Message-ID":"","References":"<20240826212245.18922-1-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]