{"id":21023,"url":"https://patchwork.libcamera.org/api/patches/21023/?format=json","web_url":"https://patchwork.libcamera.org/patch/21023/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240826161709.524293-5-jacopo.mondi@ideasonboard.com>","date":"2024-08-26T16:17:03","name":"[v3,4/9] ipa: rkisp1: Pass parameters buffer size to pipeline handler","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ee0d602bb928f8e8d0bdeecabca4b84ab7d2257c","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21023/mbox/","series":[{"id":4541,"url":"https://patchwork.libcamera.org/api/series/4541/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4541","date":"2024-08-26T16:16:59","name":"rkisp1: Support BLS on i.MX8MP","version":3,"mbox":"https://patchwork.libcamera.org/series/4541/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21023/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21023/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8D1AC324C\n\tfor ;\n\tMon, 26 Aug 2024 16:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0DE916341D;\n\tMon, 26 Aug 2024 18:17:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 60EDD6341F\n\tfor ;\n\tMon, 26 Aug 2024 18:17:20 +0200 (CEST)","from ideasonboard.com (mob-5-90-142-90.net.vodafone.it\n\t[5.90.142.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B43F480;\n\tMon, 26 Aug 2024 18:16:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fD3ioHIk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724688974;\n\tbh=mEgGz6M8yOBjYk3XjlWdwrYGWPaY3Zqs8JR+DYZrpOY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fD3ioHIkTaTg8/Xgnz/Y8TtDD6uobhzkSfh15zFECZs9XxjkfynzPwmdLiV53RiiX\n\tGZuyqXJJZ6XlJysL5KF/QmTi3lS1bJZN1PD6TKev+J5heTOcfsf89Q2t87VuGH6IyR\n\t9u0sHrfUVU7sCVUtvhfQl9TLQ54KkiPxpkvsIGRo=","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ,\n\tPaul Elder ","Subject":"[PATCH v3 4/9] ipa: rkisp1: Pass parameters buffer size to pipeline\n\thandler","Date":"Mon, 26 Aug 2024 18:17:03 +0200","Message-ID":"<20240826161709.524293-5-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.45.2","In-Reply-To":"<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>","References":"<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ISP parameters buffer currently has a fixed payload size, which is\nhardcoded in the pipeline handler. To prepare for support of the\nextensible parameters format that has a variable payload size, pass the\nsize from the IPA module to the pipeline handler explicitly. Keep the\nsize hardcoded to sizeof(struct rkisp1_params_cfg) for now, this will be\nudpated later.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \nReviewed-by: Paul Elder \nSigned-off-by: Kieran Bingham \n---\n include/libcamera/ipa/rkisp1.mojom | 2 +-\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++----\n 3 files changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/ipa/rkisp1.mojom b/include/libcamera/ipa/rkisp1.mojom\nindex 585d38572aa2..80d54a03aa90 100644\n--- a/include/libcamera/ipa/rkisp1.mojom\n+++ b/include/libcamera/ipa/rkisp1.mojom\n@@ -37,7 +37,7 @@ interface IPARkISP1Interface {\n };\n \n interface IPARkISP1EventInterface {\n-\tparamsBufferReady(uint32 frame);\n+\tparamsBufferReady(uint32 frame, uint32 bytesused);\n \tsetSensorControls(uint32 frame, libcamera.ControlList sensorControls);\n \tmetadataReady(uint32 frame, libcamera.ControlList metadata);\n };\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 71698bc47391..84ffe6cf2777 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -332,7 +332,7 @@ void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)\n \tfor (auto const &algo : algorithms())\n \t\talgo->prepare(context_, frame, frameContext, params);\n \n-\tparamsBufferReady.emit(frame);\n+\tparamsBufferReady.emit(frame, sizeof(*params));\n }\n \n void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId,\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 1cdb9a44f900..ef38d86dc4b4 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -110,7 +110,7 @@ public:\n \tstd::unique_ptr ipa_;\n \n private:\n-\tvoid paramFilled(unsigned int frame);\n+\tvoid paramFilled(unsigned int frame, unsigned int bytesused);\n \tvoid setSensorControls(unsigned int frame,\n \t\t\t const ControlList &sensorControls);\n \n@@ -374,15 +374,14 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)\n \treturn 0;\n }\n \n-void RkISP1CameraData::paramFilled(unsigned int frame)\n+void RkISP1CameraData::paramFilled(unsigned int frame, unsigned int bytesused)\n {\n \tPipelineHandlerRkISP1 *pipe = RkISP1CameraData::pipe();\n \tRkISP1FrameInfo *info = frameInfo_.find(frame);\n \tif (!info)\n \t\treturn;\n \n-\tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused =\n-\t\tsizeof(struct rkisp1_params_cfg);\n+\tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n \tpipe->param_->queueBuffer(info->paramBuffer);\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n","prefixes":["v3","4/9"]}