{"id":21004,"url":"https://patchwork.libcamera.org/api/patches/21004/?format=json","web_url":"https://patchwork.libcamera.org/patch/21004/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240823143205.2668765-3-chenghaoyang@google.com>","date":"2024-08-23T14:29:09","name":"[v2,2/3] libcamera: Add face detection controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f4113f08da69959d3f4057e90520bcf3d5204254","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/21004/mbox/","series":[{"id":4536,"url":"https://patchwork.libcamera.org/api/series/4536/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4536","date":"2024-08-23T14:29:07","name":"Add Face Detection Controls","version":2,"mbox":"https://patchwork.libcamera.org/series/4536/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/21004/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/21004/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EA53C32C2\n\tfor ;\n\tFri, 23 Aug 2024 14:32:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBBBB633D2;\n\tFri, 23 Aug 2024 16:32:16 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7637633CE\n\tfor ;\n\tFri, 23 Aug 2024 16:32:10 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-3719f0758c6so1109977f8f.1\n\tfor ;\n\tFri, 23 Aug 2024 07:32:10 -0700 (PDT)","from chenghaoyang-germany.c.googlers.com.com\n\t(161.126.77.34.bc.googleusercontent.com. [34.77.126.161])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-373081ffb66sm4300627f8f.84.2024.08.23.07.32.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Aug 2024 07:32:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Q2yI6sH+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724423529; x=1725028329;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=djAA4idgeV6EJbCGqlIZlZ4tuy/a4YT0To9eKJrnat8=;\n\tb=Q2yI6sH+JumOVUQYF3Y2p/nKzMQ7urCFUGVzz20VXtBx6NI5KpRVx0TfIcjWVBHXkY\n\tKkOLFE/Pi3OouoayJxM7p1bMzw++uxSVsH6jy/AfbWq0WJZLs6DELQXsNEUI1nd4EgjH\n\tJTXJUnuuCYv4yO64Uul2sdfPztweV17fP7gfo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724423529; x=1725028329;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=djAA4idgeV6EJbCGqlIZlZ4tuy/a4YT0To9eKJrnat8=;\n\tb=vJhy4BCClHyGhyIGkBafPVCcfYWdpI4FYRqeZzN3QpEaSxAO4OmJ9LoaqcK3mWvn/f\n\taqcAxgpKRN4qx6VONkcrtC8OHpoQxrERc6QYmlrV4T9vSnI098342O1ciAN6u3Rumykv\n\tpx2vmBIBGRu8n7Ku4VW65sn/lOGWAMbaWia3Cr1jJ4yKB62BX9wK3Ua87QXKQSI8PEZc\n\te4ySU61CHp6gqcntKNecpTYEQ6CLyNJOn0qLaQ3/sPq7DlNQeENg0iRNmlfD38Gtrmwl\n\toZ14ZYGo9zDYjg0fD+QP6m04uOfFMhLxFZd00NDLKd1pAUkHOAGE2cmdXHBEm8xcEFL0\n\tQ5Uw==","X-Gm-Message-State":"AOJu0Yzvh2aO4BkoIvSRd/XN8CWZXygwj8wQf81Cb4ypDP/MojiWvbuA\n\timrGvAA/aoDpoOEg+Yx0Pkdg9Wx+5UwsQGomlDhNkF1FYjPXV4t5g2DxHoLe9vzTtMqWEMujE0h\n\tu7A==","X-Google-Smtp-Source":"AGHT+IH0Kzux6SAppsLHkh3CJnaHaYA7HESc7qSDz3T+wXFEbEAgCM12k/Fdse6g4uvpG/n/cb7u3w==","X-Received":"by 2002:a5d:56d0:0:b0:367:909b:8281 with SMTP id\n\tffacd0b85a97d-373118e9e82mr1519388f8f.59.1724423529293; \n\tFri, 23 Aug 2024 07:32:09 -0700 (PDT)","From":"Harvey Yang ","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Yudhistira Erlandinata ,\n\tbecker hsieh ,\n\tHarvey Yang ","Subject":"[PATCH v2 2/3] libcamera: Add face detection controls","Date":"Fri, 23 Aug 2024 14:29:09 +0000","Message-ID":"<20240823143205.2668765-3-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.46.0.295.g3b9ea8a38a-goog","In-Reply-To":"<20240823143205.2668765-1-chenghaoyang@google.com>","References":"<20240823143205.2668765-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Yudhistira Erlandinata \n\nAdd FaceDetectMode, FaceDetectFaceRectangles, FaceDetectFaceScores,\nand FaceDetectFaceLandmark. Also add ControlTypePoint for supporting\nFaceDetectFaceLandmark.\n\nBUG=b:308713855\nTEST=emerge-geralt libcamera-mtkisp7\n\nSigned-off-by: Yudhistira Erlandinata \nCo-developed-by: becker hsieh \nCo-developed-by: Harvey Yang \n---\n include/libcamera/controls.h | 6 +++++\n src/libcamera/control_ids_core.yaml | 42 +++++++++++++++++++++++++++++\n src/libcamera/controls.cpp | 6 +++++\n 3 files changed, 54 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 7c2bb2872..bf1b8609c 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -34,6 +34,7 @@ enum ControlType {\n \tControlTypeString,\n \tControlTypeRectangle,\n \tControlTypeSize,\n+\tControlTypePoint,\n };\n \n namespace details {\n@@ -87,6 +88,11 @@ struct control_type {\n \tstatic constexpr ControlType value = ControlTypeSize;\n };\n \n+template<>\n+struct control_type {\n+\tstatic constexpr ControlType value = ControlTypePoint;\n+};\n+\n template\n struct control_type> : public control_type> {\n };\ndiff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 6381970b4..5ff46c71e 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -860,6 +860,48 @@ controls:\n No further state changes or lens movements will occur until the\n AfPauseResume control is sent.\n \n+ - FaceDetectMode:\n+ type: uint8_t\n+ description: |\n+ Reporting mode of face detection.\n+\n+ enum:\n+ - name: FaceDetectModeOff\n+ value: 0\n+ description: |\n+ Pipeline should not report face detection result.\n+ - name: FaceDetectModeSimple\n+ value: 1\n+ description: |\n+ Pipeline should at least report faces boundary rectangles and\n+ confidence score for each of them.\n+\n+ - FaceDetectFaceRectangles:\n+ type: Rectangle\n+ description: |\n+ Boundary rectangle of the detected faces.\n+\n+ size: [n]\n+\n+ - FaceDetectFaceScores:\n+ type: uint8_t\n+ description: |\n+ Confidence score of each of the detected faces by face detector.\n+ The range of score is [0, 100], but usually those with low confidence\n+ scores will not be included.\n+ Currently identical to ANDROID_STATISTICS_FACE_SCORES.\n+\n+ size: [n]\n+\n+ - FaceDetectFaceLandmark:\n+ type: Point\n+ description: |\n+ Array of human face landmark coordinates in format:\n+ [..., left_eye_i, right_eye_i, mouth_i, left_eye_i+1, ...],\n+ with i = index of face.\n+\n+ size: [n]\n+\n - HdrMode:\n type: int32_t\n description: |\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 11d35321c..ce73ae9d7 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -61,6 +61,7 @@ static constexpr size_t ControlValueSize[] = {\n \t[ControlTypeString]\t\t= sizeof(char),\n \t[ControlTypeRectangle]\t\t= sizeof(Rectangle),\n \t[ControlTypeSize]\t\t= sizeof(Size),\n+\t[ControlTypePoint]\t\t= sizeof(Point),\n };\n \n } /* namespace */\n@@ -255,6 +256,11 @@ std::string ControlValue::toString() const\n \t\t\tstr += value->toString();\n \t\t\tbreak;\n \t\t}\n+\t\tcase ControlTypePoint: {\n+\t\t\tconst Point *value = reinterpret_cast(data);\n+\t\t\tstr += value->toString();\n+\t\t\tbreak;\n+\t\t}\n \t\tcase ControlTypeNone:\n \t\tcase ControlTypeString:\n \t\t\tbreak;\n","prefixes":["v2","2/3"]}