[{"id":2783,"web_url":"https://patchwork.libcamera.org/comment/2783/","msgid":"<20191004204344.GB1973@pendragon.ideasonboard.com>","date":"2019-10-04T20:43:44","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: meson: Allow IPAs to\n\tinclude internal headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 04, 2019 at 06:37:32PM +0200, Jacopo Mondi wrote:\n> Extend the list of inclusion paths for the IPA modules in src/ipa/ to\n> include internal libcamera headers.\n> \n> Only Open Source IPA implementations will live in src/ipa/ and they link\n> against libcamera, so they should be able to include internal headers as\n> well as public ones.\n> \n> Signed-off-by: Jacopo Mondi \n\nI think that longer term we'll have to split the internal headers\nbetween really internal and internal+IPA headers. For now this looks\ngood.\n\n> ---\n> src/ipa/meson.build | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index b5bcd7b2c3db..2827dc0303b2 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -5,10 +5,15 @@ ipa_vimc_sources = [\n> \n> ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> \n> +ipa_includes = [\n> + libcamera_includes,\n> + libcamera_internal_includes,\n> +]\n> +\n> foreach t : ipa_vimc_sources\n> ipa = shared_module(t[0], 'ipa_vimc.cpp',\n> name_prefix : '',\n> - include_directories : libcamera_includes,\n> + include_directories : ipa_includes,\n> install : true,\n> install_dir : ipa_install_dir,\n> cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n\nDon't you also need to link to libcamera ? A\n\n\tdependencies : libcamera_dep\n\nwould seem appropriate. With this fixed,\n\nReviewed-by: Laurent Pinchart ","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72EE56165B\n\tfor ;\n\tFri, 4 Oct 2019 22:43:59 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.229.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72E862E5;\n\tFri, 4 Oct 2019 22:43:58 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570221839;\n\tbh=J1hZKRgFWFvcWMxCp9Of9GpoXSlKNzMMKqpjuASz28M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=awcyCsiU5oRHQ0/NpKOVXhMkX0vdeBjr+u2sjA4tBufdxL9qWytakDbupgbodqpnx\n\tvun+e5QedACQ9RXyGcRTsyzEq/FwbmMfDO+bYEb9loaOzbZdRHlFn+vHW6homGHV6M\n\tkjvFYC+7Ns2aRzzzzc1HiZ4MK9hUXkAr6sRLFUqo=","Date":"Fri, 4 Oct 2019 23:43:44 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191004204344.GB1973@pendragon.ideasonboard.com>","References":"<20191004163734.15594-1-jacopo@jmondi.org>\n\t<20191004163734.15594-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191004163734.15594-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: meson: Allow IPAs to\n\tinclude internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 04 Oct 2019 20:43:59 -0000"}},{"id":2788,"web_url":"https://patchwork.libcamera.org/comment/2788/","msgid":"<20191005130042.z5z746cg36yrfikk@uno.localdomain>","date":"2019-10-05T13:00:42","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: meson: Allow IPAs to\n\tinclude internal headers","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Fri, Oct 04, 2019 at 11:43:44PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Fri, Oct 04, 2019 at 06:37:32PM +0200, Jacopo Mondi wrote:\n> > Extend the list of inclusion paths for the IPA modules in src/ipa/ to\n> > include internal libcamera headers.\n> >\n> > Only Open Source IPA implementations will live in src/ipa/ and they link\n> > against libcamera, so they should be able to include internal headers as\n> > well as public ones.\n> >\n> > Signed-off-by: Jacopo Mondi \n>\n> I think that longer term we'll have to split the internal headers\n> between really internal and internal+IPA headers. For now this looks\n> good.\n>\n> > ---\n> > src/ipa/meson.build | 7 ++++++-\n> > 1 file changed, 6 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> > index b5bcd7b2c3db..2827dc0303b2 100644\n> > --- a/src/ipa/meson.build\n> > +++ b/src/ipa/meson.build\n> > @@ -5,10 +5,15 @@ ipa_vimc_sources = [\n> >\n> > ipa_install_dir = join_paths(get_option('libdir'), 'libcamera')\n> >\n> > +ipa_includes = [\n> > + libcamera_includes,\n> > + libcamera_internal_includes,\n> > +]\n> > +\n> > foreach t : ipa_vimc_sources\n> > ipa = shared_module(t[0], 'ipa_vimc.cpp',\n> > name_prefix : '',\n> > - include_directories : libcamera_includes,\n> > + include_directories : ipa_includes,\n> > install : true,\n> > install_dir : ipa_install_dir,\n> > cpp_args : '-DLICENSE=\"' + t[1] + '\"')\n>\n> Don't you also need to link to libcamera ? A\n>\n> \tdependencies : libcamera_dep\n>\n> would seem appropriate. With this fixed,\n\nI wonder why I don't get linkage errors as I use LOG...\n\n>\n> Reviewed-by: Laurent Pinchart \n\nThanks\n j\n\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","Received":["from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C26B360E1F\n\tfor ;\n\tSat, 5 Oct 2019 14:58:57 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 43838240002;\n\tSat, 5 Oct 2019 12:58:57 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 5 Oct 2019 15:00:42 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191005130042.z5z746cg36yrfikk@uno.localdomain>","References":"<20191004163734.15594-1-jacopo@jmondi.org>\n\t<20191004163734.15594-5-jacopo@jmondi.org>\n\t<20191004204344.GB1973@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"pc2fs54zupkqy7o6\"","Content-Disposition":"inline","In-Reply-To":"<20191004204344.GB1973@pendragon.ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: meson: Allow IPAs to\n\tinclude internal headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 05 Oct 2019 12:58:57 -0000"}}]