[{"id":30888,"web_url":"https://patchwork.libcamera.org/comment/30888/","msgid":"","date":"2024-08-23T12:18:09","subject":"Re: [PATCH] libcamera: controls: Fix example for ExposureValue","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Fang,\n\nThanks for fixing the typo!\n\nReviewed-by: Harvey Yang \n\nBR,\nHarvey\n\nOn Fri, Aug 23, 2024 at 8:37 AM Fang Hui wrote:\n\n> EV = [-2, -1, 0.5, 0, 0.5, 1, 2]\n> should change to\n> EV = [-2, -1, -0.5, 0, 0.5, 1, 2]\n>\n> Change-Id: I502415bdc228a5b20798597d7366c0d54b92c145\n> Signed-off-by: Fang Hui \n> ---\n> src/libcamera/control_ids_core.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/control_ids_core.yaml\n> b/src/libcamera/control_ids_core.yaml\n> index 6381970b..1b1bd950 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -127,7 +127,7 @@ controls:\n> enabled.\n>\n> By convention EV adjusts the exposure as log2. For example\n> - EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n> + EV = [-2, -1, -0.5, 0, 0.5, 1, 2] results in an exposure\n> adjustment\n> of [1/4x, 1/2x, 1/sqrt(2)x, 1x, sqrt(2)x, 2x, 4x].\n>\n> \\sa AeEnable\n> --\n> 2.17.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EEFF7BDE17\n\tfor ;\n\tFri, 23 Aug 2024 12:18:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C93AE633CF;\n\tFri, 23 Aug 2024 14:18:23 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 552D763393\n\tfor ;\n\tFri, 23 Aug 2024 14:18:22 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id\n\t38308e7fff4ca-2f3ffc7841dso16931451fa.0\n\tfor ;\n\tFri, 23 Aug 2024 05:18:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"nKhu7eJL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1724415501; x=1725020301;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=yT6o4Ize6ORgHxC96L38l4o/GwD9w9T51OcXB8/F4RU=;\n\tb=nKhu7eJL8yW1lNZYX2kUClSaijpaBxIP30KL/j6zy89bhdGYuxoNOXESw1WyQw3gfU\n\t+4G6zQ4UbDsd/azADaN22rJytAK4Q8zR3+q6N9yhDAVJPjrLqschKkqryQEDvPkancGS\n\tVmLMG+tACBr/pX/YMtixbYXSeE+nEIr8maxWg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1724415501; x=1725020301;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=yT6o4Ize6ORgHxC96L38l4o/GwD9w9T51OcXB8/F4RU=;\n\tb=SeEbF8/QNYgXPXU4vexKit2gvBckBN3QxK/dhtmd4OZryqAoEg2MhLGpbKtWHMH/Vi\n\tjZVT/0xn1bRnD2dWfdhAOCBzOln3muQ8eFIclqxL/py5xotCWl5ldskvQAMqIAQKtn+4\n\tQzwNAWdSgymwKiMclBG1qJokNU2bvdu2CWZ8JuuNNqner79bfUeLCmQHvy8QWr/c/tJ0\n\t+ec9fNWvR8mX/2ZMuTBE/yaZzhDhk7mQS3GoDsnHaAgU7gwsQ63ieC6Yipa0ZysnnRcL\n\tQKQySrH6zYs7C7xDRPnL5U8YIXPBaMCAMWSFH4f5+jgFalwgBQbjvdIoAdfYABa45pgD\n\tm+bQ==","X-Gm-Message-State":"AOJu0Ywy9ZMV4R0VlllSjtD6txHpMnrsNsiDnbsBnBDuefXK/Na/C5ve\n\tq8MP9dgwBAtOuy6KGzRgOYqgU1jcMyrYOU3v7NQ+ON86MjWVUIkNeTgC9vgdjDr6xNcd9lVpMYB\n\t8K0MwXdoEgCZgmj6/Zd+ukMhGUS+gNcobK3LK","X-Google-Smtp-Source":"AGHT+IHVKVXMmhR+wLWfQPSmJutycsLEfPZYwWCeEHYVjNxqZ4snA79TEAH2DaVDs5KJTVxKTV7imvZPxpwKOrC9YKY=","X-Received":"by 2002:a2e:6112:0:b0:2ef:2490:46fb with SMTP id\n\t38308e7fff4ca-2f4f493f0c0mr15774831fa.37.1724415500917;\n\tFri, 23 Aug 2024 05:18:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20240823060202.3632586-1-hui.fang@nxp.com>","In-Reply-To":"<20240823060202.3632586-1-hui.fang@nxp.com>","From":"Cheng-Hao Yang ","Date":"Fri, 23 Aug 2024 14:18:09 +0200","Message-ID":"","Subject":"Re: [PATCH] libcamera: controls: Fix example for ExposureValue","To":"Fang Hui ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000060b63a062058c523\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30897,"web_url":"https://patchwork.libcamera.org/comment/30897/","msgid":"<20240825011807.GB21395@pendragon.ideasonboard.com>","date":"2024-08-25T01:18:07","subject":"Re: [PATCH] libcamera: controls: Fix example for ExposureValue","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Fang Hui,\n\nThank you for the patch.\n\nOn Fri, Aug 23, 2024 at 02:02:02PM +0800, Fang Hui wrote:\n> EV = [-2, -1, 0.5, 0, 0.5, 1, 2]\n> should change to\n> EV = [-2, -1, -0.5, 0, 0.5, 1, 2]\n\nGood catch.\n\n> Change-Id: I502415bdc228a5b20798597d7366c0d54b92c145\n\nNo Change-Id please. I'll drop this line when applying the patch.\n\n> Signed-off-by: Fang Hui \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/control_ids_core.yaml | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 6381970b..1b1bd950 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -127,7 +127,7 @@ controls:\n> enabled.\n> \n> By convention EV adjusts the exposure as log2. For example\n> - EV = [-2, -1, 0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n> + EV = [-2, -1, -0.5, 0, 0.5, 1, 2] results in an exposure adjustment\n> of [1/4x, 1/2x, 1/sqrt(2)x, 1x, sqrt(2)x, 2x, 4x].\n> \n> \\sa AeEnable","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A938DBDE17\n\tfor ;\n\tSun, 25 Aug 2024 01:18:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7DE6F633D2;\n\tSun, 25 Aug 2024 03:18:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27BA4633CF\n\tfor ;\n\tSun, 25 Aug 2024 03:18:11 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6CF2512;\n\tSun, 25 Aug 2024 03:17:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jeHCsuMk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724548625;\n\tbh=Mo6efjuqjN6BYDWQWBLzwkpPDjoohSp0MMXfzBP/JCY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jeHCsuMkVAmK5XHPTjuXDz1foOnpKP7LdmgU60rfsSpQnDMAJFNW7YhBZsHjoZuUd\n\tAQFFlAbZVSPNcKdu0Ut7SAQJjOPnI2Hj0/I42t8GNSzCC91Kju4eKGgic9oCI6Qy6V\n\twEyYKHDmI/WIN9tPzDh8nl+9D9fd6jn0BMi4iqxI=","Date":"Sun, 25 Aug 2024 04:18:07 +0300","From":"Laurent Pinchart ","To":"Fang Hui ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: controls: Fix example for ExposureValue","Message-ID":"<20240825011807.GB21395@pendragon.ideasonboard.com>","References":"<20240823060202.3632586-1-hui.fang@nxp.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240823060202.3632586-1-hui.fang@nxp.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]