[{"id":2782,"web_url":"https://patchwork.libcamera.org/comment/2782/","msgid":"<20191004203910.GA1973@pendragon.ideasonboard.com>","date":"2019-10-04T20:39:10","subject":"Re: [libcamera-devel] [PATCH v2 3/6] ipa: ipa_manager: Print the\n\tloaded IPA modules path","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Fri, Oct 04, 2019 at 06:37:31PM +0200, Jacopo Mondi wrote:\n> Add debug message to report which IPA modules have been loaded and in\n> which order.\n> \n> The loading order is particularly relevant for the test VIMC IPA, as the\n> same IPA is compiled with an open source license tag and a proprietary\n> one and they both match() against the VIMC pipeline handler. Being\n> informed about their loading order is helpful to understand which one of\n> the two is actually in use.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\nbut pushed already (as a standalone patch) :-)\n\n> ---\n> src/libcamera/ipa_manager.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 27aa17920bab..f3180c0739cb 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -136,6 +136,8 @@ int IPAManager::addDir(const char *libDir)\n> \t\t\tcontinue;\n> \t\t}\n> \n> +\t\tLOG(IPAManager, Debug) << \"Loaded IPA module '\" << path << \"'\";\n> +\n> \t\tmodules_.push_back(ipaModule);\n> \t\tcount++;\n> \t}","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 50F856165B\n\tfor ;\n\tFri, 4 Oct 2019 22:39:26 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.229.213])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 121042E5;\n\tFri, 4 Oct 2019 22:39:24 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570221565;\n\tbh=+/+ryXI5YlVvhgBkYxq/i5dwuHeFgUkPATRzRrYOaYo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sDCHdPjRAPSfWsubMrIqANUHtQvKo7xgqEQrZaLfF1bqEKzXlUPQIXIy6UHvlx71v\n\tfexpLTusxiROX514NypUslkTgEL3b7SUFWdBB85vp/LP0M07Tm7rk4Px305g8m02Rp\n\t2F670HqGCbX4r6Voeem5TQ7YXr4gkR2TQWGxG8jE=","Date":"Fri, 4 Oct 2019 23:39:10 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191004203910.GA1973@pendragon.ideasonboard.com>","References":"<20191004163734.15594-1-jacopo@jmondi.org>\n\t<20191004163734.15594-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20191004163734.15594-4-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] ipa: ipa_manager: Print the\n\tloaded IPA modules path","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 04 Oct 2019 20:39:26 -0000"}}]