[{"id":30843,"web_url":"https://patchwork.libcamera.org/comment/30843/","msgid":"<20240815211858.GC21937@pendragon.ideasonboard.com>","date":"2024-08-15T21:18:58","subject":"Re: [PATCH 3/3] libcamera: pipeline: simple: Use MediaLink string\n\thelper","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Aug 15, 2024 at 10:09:25PM +0100, Kieran Bingham wrote:\n> Replace the open-coded implementation of a link representation\n> with the operator<< overload string representation to simplify\n> the code and unify appearance of reporting MediaLinks.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1e7ec7d97255..2d205e9925ef 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t}\n> \n> \t\tLOG(SimplePipeline, Debug)\n> -\t\t\t<< \"Link '\" << source->entity()->name()\n> -\t\t\t<< \"':\" << source->index()\n> -\t\t\t<< \" -> '\" << sink->entity()->name()\n> -\t\t\t<< \"':\" << sink->index()\n> -\t\t\t<< \" configured with format \" << *format;\n> +\t\t\t<< \"Link \" << *link << \": configured with format \"\n> +\t\t\t<< *format;\n> \t}\n> \n> \treturn 0;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AF019BDB13\n\tfor ;\n\tThu, 15 Aug 2024 21:19:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69BC7633BE;\n\tThu, 15 Aug 2024 23:19:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09C5063393\n\tfor ;\n\tThu, 15 Aug 2024 23:19:25 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 416C6827;\n\tThu, 15 Aug 2024 23:18:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sTdCxQcS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723756706;\n\tbh=xIPsnrtv+AP3c32IeFAAvG8HMIL2HJHYLuAa8g0FJmw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sTdCxQcSQv2cuRSYC1kdLV4U9AqWQQVK5Y5SYyS0yr0GoxqQiu2b57AJOBsyaRDJ8\n\tnz53SlzTUh1xf+QMwlHWfuh5xADKGOVQbit1Co4FbEjscbc0tffumoLDCbDSMWgo1x\n\tkMlToY6ENoIs+fB7HtBeAmPuQFu1DZy1kX5HQkks=","Date":"Fri, 16 Aug 2024 00:18:58 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 3/3] libcamera: pipeline: simple: Use MediaLink string\n\thelper","Message-ID":"<20240815211858.GC21937@pendragon.ideasonboard.com>","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>\n\t<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31187,"web_url":"https://patchwork.libcamera.org/comment/31187/","msgid":"","date":"2024-09-12T08:56:18","subject":"Re: [PATCH 3/3] libcamera: pipeline: simple: Use MediaLink string\n\thelper","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Aug 15, 2024 at 10:09:25PM +0100, Kieran Bingham wrote:\n> Replace the open-coded implementation of a link representation\n> with the operator<< overload string representation to simplify\n> the code and unify appearance of reporting MediaLinks.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 7 ++-----\n> 1 file changed, 2 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1e7ec7d97255..2d205e9925ef 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -774,11 +774,8 @@ int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n> \t\t}\n> \n> \t\tLOG(SimplePipeline, Debug)\n> -\t\t\t<< \"Link '\" << source->entity()->name()\n> -\t\t\t<< \"':\" << source->index()\n> -\t\t\t<< \" -> '\" << sink->entity()->name()\n> -\t\t\t<< \"':\" << sink->index()\n> -\t\t\t<< \" configured with format \" << *format;\n> +\t\t\t<< \"Link \" << *link << \": configured with format \"\n> +\t\t\t<< *format;\n> \t}\n> \n> \treturn 0;\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D95CBF415\n\tfor ;\n\tThu, 12 Sep 2024 08:56:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BAE9634FE;\n\tThu, 12 Sep 2024 10:56:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 479C4634F9\n\tfor ;\n\tThu, 12 Sep 2024 10:56:22 +0200 (CEST)","from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF6E22C6;\n\tThu, 12 Sep 2024 10:55:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hnBUV4Q4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726131302;\n\tbh=8Tz4cFlts/EjFZezHt3qBRPXeBFwEPi13wT3PjW+Dfo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hnBUV4Q4neYuQ7wUwUlkVFpTDwPbiG4TIfau6b8luFyki+gXEtPJZgBE0Lat7vrFO\n\t592rdDKH3OYZfUb8lJrTUgk/mYjJgObqK82RNq6ucpBrH9db3/PNdpYJqkjcUO/+0Z\n\tUTiDsjK7iuSyb+J2R7O99b3W00Ud8djyqx7T5FGI=","Date":"Thu, 12 Sep 2024 10:56:18 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 3/3] libcamera: pipeline: simple: Use MediaLink string\n\thelper","Message-ID":"","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>\n\t<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240815210925.4172287-4-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]