[{"id":30841,"web_url":"https://patchwork.libcamera.org/comment/30841/","msgid":"<20240815211745.GA21937@pendragon.ideasonboard.com>","date":"2024-08-15T21:17:45","subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Aug 15, 2024 at 10:09:23PM +0100, Kieran Bingham wrote:\n> Various parts of libcamera print the representation of a MediaLink by\n> inline joining the parts to make a string representation.\n> \n> This repeated use case can be supported with a common helper to print\n> the MediaLink in a common manner using the existing toString() and\n> operator<< overload style to make it easier to report on MediaLink\n> types.\n> \n> This implementation will report in the following style:\n> \n> 'imx283 1-001a'[0] -> 'video-mux'[0]\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/internal/media_object.h | 4 ++++\n> src/libcamera/media_object.cpp | 25 +++++++++++++++++++++++\n> 2 files changed, 29 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index c9d77511a991..3ebef938bc49 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -48,6 +48,8 @@ public:\n> \tunsigned int flags() const { return flags_; }\n> \tint setEnabled(bool enable);\n> \n> +\tstd::string toString() const;\n> +\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(MediaLink)\n> \n> @@ -61,6 +63,8 @@ private:\n> \tunsigned int flags_;\n> };\n> \n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link);\n> +\n> class MediaPad : public MediaObject\n> {\n> public:\n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index 1b191a1e4df8..fa2c44b0abb6 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -146,6 +146,31 @@ MediaLink::MediaLink(const struct media_v2_link *link, MediaPad *source,\n> {\n> }\n> \n> +std::string MediaLink::toString() const\n\nNo warning from doxygen about missing documentation ?\n\n> +{\n> +\tstd::stringstream ss;\n> +\tss << *this;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> +/**\n> + * \\brief Insert a text representation of a Link into an output stream\n> + * \\param[in] out The output stream\n> + * \\param[in] r The MediaLink\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link)\n> +{\n> +\tout << \"'\"\n> +\t << link.source()->entity()->name() << \"'[\"\n> +\t << link.source()->index() << \"] -> '\"\n> +\t << link.sink()->entity()->name() << \"'[\"\n> +\t << link.sink()->index() << \"]\";\n\nHow about also adding the same two helpers for MediaPad ? Then you could\nwrite\n\n\tout << link.source() << \" -> \" << link->sink();\n\nReviewed-by: Laurent Pinchart \n\n> +\n> +\treturn out;\n> +}\n> +\n> /**\n> * \\fn MediaLink::source()\n> * \\brief Retrieve the link's source pad","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 887ACBDB13\n\tfor ;\n\tThu, 15 Aug 2024 21:18:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0E8F63369;\n\tThu, 15 Aug 2024 23:18:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8237C61955\n\tfor ;\n\tThu, 15 Aug 2024 23:18:11 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91857827;\n\tThu, 15 Aug 2024 23:17:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MAl/X+k/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723756632;\n\tbh=zyMYY8mQnHtHiGM2GVGEXRVS4DL1aVxP+9pWI6avJaM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MAl/X+k/8VfFnFrYdTVJ1Z6xmrEPy9JTIlrSgp3psSceQPW5BOJuZziZ5RR2RRSAL\n\t7uAvE0UgBsTBMXoJ+T+Vnf3s1GDVVvsedGfQlj1kuNj9Mh6+SDTB53pjWqSOdHNjxU\n\tyI94QMrHMcGZWaR3EgM3X+8rLojV8zWufBYWXS6E=","Date":"Fri, 16 Aug 2024 00:17:45 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","Message-ID":"<20240815211745.GA21937@pendragon.ideasonboard.com>","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>\n\t<20240815210925.4172287-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240815210925.4172287-2-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30844,"web_url":"https://patchwork.libcamera.org/comment/30844/","msgid":"<172375771438.129190.668616421269392884@ping.linuxembedded.co.uk>","date":"2024-08-15T21:35:14","subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-15 22:17:45)\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Thu, Aug 15, 2024 at 10:09:23PM +0100, Kieran Bingham wrote:\n> > Various parts of libcamera print the representation of a MediaLink by\n> > inline joining the parts to make a string representation.\n> > \n> > This repeated use case can be supported with a common helper to print\n> > the MediaLink in a common manner using the existing toString() and\n> > operator<< overload style to make it easier to report on MediaLink\n> > types.\n> > \n> > This implementation will report in the following style:\n> > \n> > 'imx283 1-001a'[0] -> 'video-mux'[0]\n> > \n> > Signed-off-by: Kieran Bingham \n> > ---\n> > include/libcamera/internal/media_object.h | 4 ++++\n> > src/libcamera/media_object.cpp | 25 +++++++++++++++++++++++\n> > 2 files changed, 29 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> > index c9d77511a991..3ebef938bc49 100644\n> > --- a/include/libcamera/internal/media_object.h\n> > +++ b/include/libcamera/internal/media_object.h\n> > @@ -48,6 +48,8 @@ public:\n> > unsigned int flags() const { return flags_; }\n> > int setEnabled(bool enable);\n> > \n> > + std::string toString() const;\n> > +\n> > private:\n> > LIBCAMERA_DISABLE_COPY_AND_MOVE(MediaLink)\n> > \n> > @@ -61,6 +63,8 @@ private:\n> > unsigned int flags_;\n> > };\n> > \n> > +std::ostream &operator<<(std::ostream &out, const MediaLink &link);\n> > +\n> > class MediaPad : public MediaObject\n> > {\n> > public:\n> > diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> > index 1b191a1e4df8..fa2c44b0abb6 100644\n> > --- a/src/libcamera/media_object.cpp\n> > +++ b/src/libcamera/media_object.cpp\n> > @@ -146,6 +146,31 @@ MediaLink::MediaLink(const struct media_v2_link *link, MediaPad *source,\n> > {\n> > }\n> > \n> > +std::string MediaLink::toString() const\n> \n> No warning from doxygen about missing documentation ?\n\nOoops - I didn't look closely to check.\n\nI'll update.\n\n> \n> > +{\n> > + std::stringstream ss;\n> > + ss << *this;\n> > +\n> > + return ss.str();\n> > +}\n> > +\n> > +/**\n> > + * \\brief Insert a text representation of a Link into an output stream\n> > + * \\param[in] out The output stream\n> > + * \\param[in] r The MediaLink\n> > + * \\return The output stream \\a out\n> > + */\n> > +std::ostream &operator<<(std::ostream &out, const MediaLink &link)\n> > +{\n> > + out << \"'\"\n> > + << link.source()->entity()->name() << \"'[\"\n> > + << link.source()->index() << \"] -> '\"\n> > + << link.sink()->entity()->name() << \"'[\"\n> > + << link.sink()->index() << \"]\";\n> \n> How about also adding the same two helpers for MediaPad ? Then you could\n> write\n> \n> out << link.source() << \" -> \" << link->sink();\n\nThat may as well complete the set! I expect MediaPad is also used as\nstrings elsewhere through the code base quite a lot so is likely to be\nuseful.\n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > +\n> > + return out;\n> > +}\n> > +\n> > /**\n> > * \\fn MediaLink::source()\n> > * \\brief Retrieve the link's source pad\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05F43C323E\n\tfor ;\n\tThu, 15 Aug 2024 21:35:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3A21633B9;\n\tThu, 15 Aug 2024 23:35:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3088363369\n\tfor ;\n\tThu, 15 Aug 2024 23:35:17 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CE19827;\n\tThu, 15 Aug 2024 23:34:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vfNZHIYi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723757658;\n\tbh=WnxwMzV/VxPS3YOK5ldnnZTCROWLjmNp9fcPM80cts8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vfNZHIYitLi/7/GBPJwzKEUlLcMnfR0g76pD0Z5PLzRB9QMWsfHFQVBfQJjOOymkv\n\tZITnegeLRrgvHNCqVn4PHpiqse1DOS8x+0NyyFO3qzDNr0H/EnK6Q5MXsFaDz4ljyF\n\tWGhzXzCBJL5EbiDGxsmuwJuaTVFolUx/hq1kMyKk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240815211745.GA21937@pendragon.ideasonboard.com>","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>\n\t<20240815210925.4172287-2-kieran.bingham@ideasonboard.com>\n\t<20240815211745.GA21937@pendragon.ideasonboard.com>","Subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","From":"Kieran Bingham ","Cc":"libcamera devel ","To":"Laurent Pinchart ","Date":"Thu, 15 Aug 2024 22:35:14 +0100","Message-ID":"<172375771438.129190.668616421269392884@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31185,"web_url":"https://patchwork.libcamera.org/comment/31185/","msgid":"","date":"2024-09-12T08:53:37","subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch. \n\nOn Thu, Aug 15, 2024 at 10:09:23PM +0100, Kieran Bingham wrote:\n> Various parts of libcamera print the representation of a MediaLink by\n> inline joining the parts to make a string representation.\n> \n> This repeated use case can be supported with a common helper to print\n> the MediaLink in a common manner using the existing toString() and\n> operator<< overload style to make it easier to report on MediaLink\n> types.\n> \n> This implementation will report in the following style:\n> \n> 'imx283 1-001a'[0] -> 'video-mux'[0]\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> include/libcamera/internal/media_object.h | 4 ++++\n> src/libcamera/media_object.cpp | 25 +++++++++++++++++++++++\n> 2 files changed, 29 insertions(+)\n> \n> diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\n> index c9d77511a991..3ebef938bc49 100644\n> --- a/include/libcamera/internal/media_object.h\n> +++ b/include/libcamera/internal/media_object.h\n> @@ -48,6 +48,8 @@ public:\n> \tunsigned int flags() const { return flags_; }\n> \tint setEnabled(bool enable);\n> \n> +\tstd::string toString() const;\n> +\n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(MediaLink)\n> \n> @@ -61,6 +63,8 @@ private:\n> \tunsigned int flags_;\n> };\n> \n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link);\n> +\n> class MediaPad : public MediaObject\n> {\n> public:\n> diff --git a/src/libcamera/media_object.cpp b/src/libcamera/media_object.cpp\n> index 1b191a1e4df8..fa2c44b0abb6 100644\n> --- a/src/libcamera/media_object.cpp\n> +++ b/src/libcamera/media_object.cpp\n> @@ -146,6 +146,31 @@ MediaLink::MediaLink(const struct media_v2_link *link, MediaPad *source,\n> {\n> }\n> \n> +std::string MediaLink::toString() const\n> +{\n> +\tstd::stringstream ss;\n> +\tss << *this;\n> +\n> +\treturn ss.str();\n> +}\n> +\n> +/**\n> + * \\brief Insert a text representation of a Link into an output stream\n> + * \\param[in] out The output stream\n> + * \\param[in] r The MediaLink\n> + * \\return The output stream \\a out\n> + */\n> +std::ostream &operator<<(std::ostream &out, const MediaLink &link)\n> +{\n> +\tout << \"'\"\n> +\t << link.source()->entity()->name() << \"'[\"\n> +\t << link.source()->index() << \"] -> '\"\n> +\t << link.sink()->entity()->name() << \"'[\"\n> +\t << link.sink()->index() << \"]\";\n> +\n> +\treturn out;\n> +}\n> +\n> /**\n> * \\fn MediaLink::source()\n> * \\brief Retrieve the link's source pad\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC96FBF415\n\tfor ;\n\tThu, 12 Sep 2024 08:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5E24634FC;\n\tThu, 12 Sep 2024 10:53:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CCE8634F5\n\tfor ;\n\tThu, 12 Sep 2024 10:53:45 +0200 (CEST)","from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8C884AD;\n\tThu, 12 Sep 2024 10:52:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WZhRJj4k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726131145;\n\tbh=GkaYfgvhBVz5WBxM6p9vqy6845luL39OvjUClUzyoTE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WZhRJj4k5XoheNALSJZVrqwtLucb46lf16q/505EYFh+QabILIKW2szg8y/fzVMwK\n\t3upenBrrsZ5Qwm9CFVuluMxrerJh949Z2K6v/+BvaX/PIUjE1E0cXRE+Mmi69U25Rm\n\t8+zF+oBv0Jd6OoK7xo5xMeKX32cDZv5QLCse0IJU=","Date":"Thu, 12 Sep 2024 10:53:37 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 1/3] libcamera: media_object: Add MediaLink string\n\trepresentations","Message-ID":"","References":"<20240815210925.4172287-1-kieran.bingham@ideasonboard.com>\n\t<20240815210925.4172287-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240815210925.4172287-2-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]