[{"id":30808,"web_url":"https://patchwork.libcamera.org/comment/30808/","msgid":"","date":"2024-08-14T10:52:08","subject":"Re: [PATCH v2 2/2] utils: tuning: Change Tuner.add() to accept a\n\tlist of modules","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Aug 14, 2024 at 11:41:31AM +0200, Stefan Klug wrote:\n> Change the first parameter of Tuner.add() to accept either a list of\n> modules or a single module. This allows more compact code and is in sync\n> with Tuner.set_output_order().\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\n\\o/\n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/libtuning/libtuning.py | 5 ++++-\n> utils/tuning/rkisp1.py | 10 +---------\n> 2 files changed, 5 insertions(+), 10 deletions(-)\n> \n> diff --git a/utils/tuning/libtuning/libtuning.py b/utils/tuning/libtuning/libtuning.py\n> index e7c63535fefd..bac573235040 100644\n> --- a/utils/tuning/libtuning/libtuning.py\n> +++ b/utils/tuning/libtuning/libtuning.py\n> @@ -95,7 +95,10 @@ class Tuner(object):\n> self.output = {}\n> \n> def add(self, module):\n> - self.modules.append(module)\n> + if isinstance(module, list):\n> + self.modules.extend(module)\n> + else:\n> + self.modules.append(module)\n> \n> def set_input_parser(self, parser):\n> self.parser = parser\n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index 5d7a69fc4a13..f5c42a61d15e 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -45,15 +45,7 @@ lsc = LSCRkISP1(debug=[lt.Debug.Plot],\n> smoothing_function=lt.smoothing.MedianBlur(3),)\n> \n> tuner = lt.Tuner('RkISP1')\n> -tuner.add(agc)\n> -tuner.add(awb)\n> -tuner.add(blc)\n> -tuner.add(ccm)\n> -tuner.add(color_processing)\n> -tuner.add(filter)\n> -tuner.add(gamma_out)\n> -tuner.add(lsc)\n> -\n> +tuner.add([agc, awb, blc, ccm, color_processing, filter, gamma_out, lsc])\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> tuner.set_output_order([agc, awb, blc, ccm, color_processing,\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A12B5C323E\n\tfor ;\n\tWed, 14 Aug 2024 10:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 639E9633B5;\n\tWed, 14 Aug 2024 12:52:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD4E263394\n\tfor ;\n\tWed, 14 Aug 2024 12:52:14 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-024.catv02.itscom.jp\n\t[175.177.49.24])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E28B42E0;\n\tWed, 14 Aug 2024 12:51:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k2LgT4sj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723632677;\n\tbh=vDPynIGcLa/dk8LqzMMG8CrKoOq2HjL9dpkD01u6LiI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=k2LgT4sjImqTbdnNZi2sBx5RDaUnnGLA/+rSFUzJq5JAL8X8cOUlQQO4ILnqIBxKb\n\t6EFPK+pWqKgMzw8/9e7R8HCgsM0nx4jNydUnT+COSQgpdoTWgl4z2d+UVS7BStavFc\n\tvU3OHj7fFqDfvlLI1EWIT3c9Hg144tS4nPFVRXbk=","Date":"Wed, 14 Aug 2024 19:52:08 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v2 2/2] utils: tuning: Change Tuner.add() to accept a\n\tlist of modules","Message-ID":"","References":"<20240814094134.73333-1-stefan.klug@ideasonboard.com>\n\t<20240814094134.73333-3-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240814094134.73333-3-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]