[{"id":30791,"web_url":"https://patchwork.libcamera.org/comment/30791/","msgid":"<87ttfowkng.fsf@redhat.com>","date":"2024-08-13T14:40:51","subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Kieran Bingham writes:\n\n> Fix a small typo in the comment regarding the default routing\n> table configuration.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 1e7ec7d97255..49f9137b9363 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t\t\t\t/*\n> \t\t\t\t * Reset the routing table to its default state\n> \t\t\t\t * to make sure entities are enumerate according\n\nenumerated ?\n\n> -\t\t\t\t * to the defaul routing configuration.\n> +\t\t\t\t * to the default routing configuration.\n> \t\t\t\t */\n> \t\t\t\tret = resetRoutingTable(subdev.get());\n> \t\t\t\tif (ret) {\n\nReviewed-by: Milan Zamazal ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07402C323E\n\tfor ;\n\tTue, 13 Aug 2024 14:41:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D58BB633B5;\n\tTue, 13 Aug 2024 16:40:58 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7300863382\n\tfor ;\n\tTue, 13 Aug 2024 16:40:57 +0200 (CEST)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-198-gHOMtL3OOC-G22ak7DEebg-1; Tue, 13 Aug 2024 10:40:54 -0400","by mail-wr1-f70.google.com with SMTP id\n\tffacd0b85a97d-3687f5a2480so2951739f8f.3\n\tfor ;\n\tTue, 13 Aug 2024 07:40:54 -0700 (PDT)","from nuthatch (nat-pool-brq-t.redhat.com. [213.175.37.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-36e4c936f5fsm10563298f8f.28.2024.08.13.07.40.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 13 Aug 2024 07:40:52 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"U51bjwV7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723560056;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=J8vQSwQgRvwkUaeE1S2Ulz4J/cAwuMsK9bT9G8r5S9U=;\n\tb=U51bjwV7C67LaoXqcOmDm1Heu7IzDKw+HO95pSbgWZYPxNjcGUrQ5ZPorThoLp348jb3S1\n\tEqQfc8PV4E+nMzZlQxOF0JuUuL5wh7wGXK53Q3iFwi3qNbgHEj5w93Wgd43Dtkg4Y+Efwo\n\tTHe/K7Xsu9rT4TeB1UF5auFf91yltAc=","X-MC-Unique":"gHOMtL3OOC-G22ak7DEebg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723560053; x=1724164853;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=J8vQSwQgRvwkUaeE1S2Ulz4J/cAwuMsK9bT9G8r5S9U=;\n\tb=W/iYezMjy/8TaVJCNqZkeUX9C9yA3JWWoNQEk7susfvD8ay3T944R+8D6/znbSxuWM\n\to0W0qH71oZ/UpUNkfJ4zzBfMrGdC7seD81Ym8EeytnCyLR6ECL3/KE+VMcTL+I0TbOxb\n\tQoNF5L2A65MRbHUsI7ebLnecOgwlqk+/PZmBm3jzN6GmEekYTBF9g1rV0h7dqxH3evcO\n\tFnz4PMBkS7vntCZ+FwwO4Nf1AvhLQ8pYHI5qWrErikgUqxm2BxPy6D0QnJlkqjYqpxxI\n\t0hlIlb3BoVW4kY5yUn5w1vcDgBLom4zWoaszhEaAISMh9IXv90ezlmcUailR/jb6Iy9S\n\tco4A==","X-Gm-Message-State":"AOJu0YwiG+u5UnqhFN+TGRACn+jn/dcIER9cawR97foLJlr1mXu94YPh\n\tmq98Nb7E71SOU+iKJT3pqwfZ+F2V0aoD4/ERUeDeIbz/uZ5BO91cQcm1k8fpmK0pp4S148/32d1\n\tJPME7RfXNu4eFelTV+AJugxxyDThyVNpCtOU+mXsR9munt0zI8C1v3WXYCU1VWcHqIKBzGJQaky\n\tULkL53l6hCgBIf8EkSq8s9VZ3eMNq/mLTlWps8EUyHlqrOPhVxD9t7uKc=","X-Received":["by 2002:a5d:47c4:0:b0:368:74a8:6c34 with SMTP id\n\tffacd0b85a97d-3716cd08271mr2951308f8f.36.1723560053159; \n\tTue, 13 Aug 2024 07:40:53 -0700 (PDT)","by 2002:a5d:47c4:0:b0:368:74a8:6c34 with SMTP id\n\tffacd0b85a97d-3716cd08271mr2951289f8f.36.1723560052529; \n\tTue, 13 Aug 2024 07:40:52 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEUEAb8FwP0HUpSie1Fc3VYVJD0Jnkc7icWzgoG4mAV44KcKZHeBaaDnr78QN0DHQBdKf496g==","From":"Milan Zamazal ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","In-Reply-To":"<20240813141429.2042369-1-kieran.bingham@ideasonboard.com>\n\t(Kieran Bingham's message of \"Tue, 13 Aug 2024 15:14:29 +0100\")","References":"<20240813141429.2042369-1-kieran.bingham@ideasonboard.com>","Date":"Tue, 13 Aug 2024 16:40:51 +0200","Message-ID":"<87ttfowkng.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30793,"web_url":"https://patchwork.libcamera.org/comment/30793/","msgid":"<172356193852.1687952.16218280486689822863@ping.linuxembedded.co.uk>","date":"2024-08-13T15:12:18","subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-08-13 15:40:51)\n> Kieran Bingham writes:\n> \n> > Fix a small typo in the comment regarding the default routing\n> > table configuration.\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 1e7ec7d97255..49f9137b9363 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> > /*\n> > * Reset the routing table to its default state\n> > * to make sure entities are enumerate according\n> \n> enumerated ?\n\nIndeed, I'll change both in the same patch and update the commit\nmessage.\n\n> \n> > - * to the defaul routing configuration.\n> > + * to the default routing configuration.\n> > */\n> > ret = resetRoutingTable(subdev.get());\n> > if (ret) {\n> \n> Reviewed-by: Milan Zamazal \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A28DCC323E\n\tfor ;\n\tTue, 13 Aug 2024 15:12:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2EC263398;\n\tTue, 13 Aug 2024 17:12:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 309C563382\n\tfor ;\n\tTue, 13 Aug 2024 17:12:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0453F4AB;\n\tTue, 13 Aug 2024 17:11:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sw/XmhnY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723561884;\n\tbh=Za64UDPZCV6pnLcW8Z6Z26A0/ntuWURfRU1ub14S7gM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Sw/XmhnYlhx1t4hj+G2j9p/HtMUYcUatDR2l00N/EE3MH2if3LOPHJCq75UT+SGve\n\tkAKuO5S8MKR0qMw2GEpd37PJmgIlH6w6f0GJdEHJFyU2yXrerVSBWMTrgbxfos1IMK\n\ttCwd4rcAKfVI+28KXUrsZ/Z+C9QFng/6fyGZkeEQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87ttfowkng.fsf@redhat.com>","References":"<20240813141429.2042369-1-kieran.bingham@ideasonboard.com>\n\t<87ttfowkng.fsf@redhat.com>","Subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","From":"Kieran Bingham ","Cc":"libcamera devel ","To":"Milan Zamazal ","Date":"Tue, 13 Aug 2024 16:12:18 +0100","Message-ID":"<172356193852.1687952.16218280486689822863@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30796,"web_url":"https://patchwork.libcamera.org/comment/30796/","msgid":"<20240813165010.GF24634@pendragon.ideasonboard.com>","date":"2024-08-13T16:50:10","subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Aug 13, 2024 at 04:12:18PM +0100, Kieran Bingham wrote:\n> Quoting Milan Zamazal (2024-08-13 15:40:51)\n> > Kieran Bingham writes:\n> > \n> > > Fix a small typo in the comment regarding the default routing\n> > > table configuration.\n> > >\n> > > Signed-off-by: Kieran Bingham \n> > > ---\n> > > src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > > index 1e7ec7d97255..49f9137b9363 100644\n> > > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > > @@ -1617,7 +1617,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> > > /*\n> > > * Reset the routing table to its default state\n> > > * to make sure entities are enumerate according\n> > \n> > enumerated ?\n> \n> Indeed, I'll change both in the same patch and update the commit\n> message.\n\nAnd you can then push with my\n\nReviewed-by: Laurent Pinchart \n\n> > > - * to the defaul routing configuration.\n> > > + * to the default routing configuration.\n> > > */\n> > > ret = resetRoutingTable(subdev.get());\n> > > if (ret) {\n> > \n> > Reviewed-by: Milan Zamazal ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08571C323E\n\tfor ;\n\tTue, 13 Aug 2024 16:50:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DDB90633B5;\n\tTue, 13 Aug 2024 18:50:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7C4C63382\n\tfor ;\n\tTue, 13 Aug 2024 18:50:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6471CAD8;\n\tTue, 13 Aug 2024 18:49:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pUEgMk1H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723567778;\n\tbh=1fkxMuAJAyb4b4KQXpo/rvT/EF40vCbmk/e2PwwC6Tk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pUEgMk1HkK9xDl2KAy6m+0ofrymtQP1Q0KwGKfg6nRZ2JBFJ/kIo+rJMt5yTasXIi\n\t6zThPHvIUFhW481X4vWG4Zqc9+CpgC5CM+k76Qvj9DTXxL/CLQD88BTI3CLSMcaPU6\n\tNJ4GtZmUiCq1Eohtv5RgW+Vdk3yWbI8vYfADIaHU=","Date":"Tue, 13 Aug 2024 19:50:10 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"Milan Zamazal ,\n\tlibcamera devel ","Subject":"Re: [PATCH] libcamera: pipeline: simple: Fix 'default' typo in\n\tcomment","Message-ID":"<20240813165010.GF24634@pendragon.ideasonboard.com>","References":"<20240813141429.2042369-1-kieran.bingham@ideasonboard.com>\n\t<87ttfowkng.fsf@redhat.com>\n\t<172356193852.1687952.16218280486689822863@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172356193852.1687952.16218280486689822863@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]