{"id":20901,"url":"https://patchwork.libcamera.org/api/patches/20901/?format=json","web_url":"https://patchwork.libcamera.org/patch/20901/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240813124722.22425-2-jaslo@ziska.de>","date":"2024-08-13T12:25:05","name":"[v2,1/3] gstreamer: Remove auto-focus-mode property from device provider","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5252e097f22592a18c93ceb04e2a8fe8a389daf9","submitter":{"id":173,"url":"https://patchwork.libcamera.org/api/people/173/?format=json","name":"Jaslo Ziska","email":"jaslo@ziska.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20901/mbox/","series":[{"id":4515,"url":"https://patchwork.libcamera.org/api/series/4515/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4515","date":"2024-08-13T12:25:04","name":"gstreamer: Generate controls from control_ids_*.yaml files","version":2,"mbox":"https://patchwork.libcamera.org/series/4515/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20901/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20901/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3685BBDB13\n\tfor ;\n\tTue, 13 Aug 2024 12:48:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8708633B5;\n\tTue, 13 Aug 2024 14:48:17 +0200 (CEST)","from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de\n\t[81.169.146.220])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92AAC63382\n\tfor ;\n\tTue, 13 Aug 2024 14:48:16 +0200 (CEST)","from archlinux.fritz.box by smtp.strato.de (RZmta 51.1.0 AUTH)\n\twith ESMTPSA id zb9f0a07DCmGU7g\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tTue, 13 Aug 2024 14:48:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"aI1KpMgD\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"ejcKC+5V\"; dkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1723553296; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=VCqnqBRR0EwLKq6C+HE4yYOeCSvTSGkhZTTZ0vhU6Bk52CWOu/A0WEH+2Il0CHsG9j\n\tdwzb3Gm2jS09Cbcox+kvCsc4wIC1j7RDrGkEsLwpzFp/q4rtRjSb4+5no8mmLKGiW8Td\n\tDbBAnm1uoYFRfoeYzrH8LO70/mng9Nc16DEPe5gXW+sw2ki3d/B6HRigZPizGcHsjOxc\n\tQ+9JR//deMf5fRGAHa4u+UwFIpC4XwCL8Nu2+/Vgh+FKUpyLFGUKRKPbwxOEr805cdgU\n\tPre52ArYlfsmL2x/Vd+8FYk9y3CNd8hYyBUyvyD7e/Bf9HmnNNtRF7oCpKCJLsBjJqz2\n\t02sA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; t=1723553296;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=;\n\tb=qaAOhF7/mMUchFrVE/VV80KoHpEM42sdjBjyHBkhD2qjHfthvGFotwlmZuRPELGHdL\n\tpt9T0QjHHw4X4acccZgO9wi9Km1GQu7jERvdc5m5KGIRdZ4bpGo5m4xSD8+JEo8/Ds9C\n\t2ORc2g2hxBgR0sQqF1VGpbfpUZbU7LpzJ7RJ9pKLOhaaahM1UoXjrefyOE+OQjQatkCe\n\t4F6r7v6eDDWJ1FF28ioox9A1gtx39TeVFEnVFM8qYhci+dwjjZOfau7oBph4oQnPkC7y\n\tTaQGeWQeGAjVIZyNKJ1rflm69FKuYOfcH3fJRfhmJjlpPk11Fu6J3q/R2HIcbgis+Qv9\n\tDeMg==","ARC-Authentication-Results":"i=1; strato.com;\n arc=none;\n dkim=none","X-RZG-CLASS-ID":"mo00","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; t=1723553296;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=;\n\tb=aI1KpMgDFJdGbePhSqx0OX+gnwTRuICZxW6Tknv+uKQWmmsHtZFqvPlYIJaWqZeXth\n\tgtZOT2641Cn7o7S9KpeLuzzMWpxjDtj4UC+h2W+VWCTDAXgM2VHfd3G1Yv6pXAu39+OD\n\tEWAc0mWwU77/JgaEQuskFaiEMpK4GDGmNWOpzz3fIAe7APGwBWyRb8TvjZlFeCMCxefl\n\tFf/Tl8/v/0EgEqqEzJcza4LZT8zJKo0edO6XC4mgB1kyLBe/DfEFZNsqMR+zWTYeN1KR\n\tDCS7vCO8ETMJdeugEQQu9s3etnsHKRy+3hqO8whdwip0S7vSD1Ewj6kd5ochc4sgd6jS\n\twDAw==","v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1723553296;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=VrgI6MUBEQZ4SixjjRaGQ1/YDwuso5jYmEdUtg1ppXs=;\n\tb=ejcKC+5VJJNaeyzUL94Ncc0UOq92HMz18mhq/QWFTmMpoYzKL6tGCtqJJ2/Ay+NifE\n\tBRmjbO3DJDvsqUt+ibDw=="],"X-RZG-AUTH":"\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cGhoqwVPJQb1HfVSED9d9Z5psVXjkhV67rRpA=\"","From":"Jaslo Ziska ","To":"libcamera-devel@lists.libcamera.org","Cc":"Jaslo Ziska ","Subject":"[PATCH v2 1/3] gstreamer: Remove auto-focus-mode property from\n\tdevice provider","Date":"Tue, 13 Aug 2024 14:25:05 +0200","Message-ID":"<20240813124722.22425-2-jaslo@ziska.de>","X-Mailer":"git-send-email 2.46.0","In-Reply-To":"<20240813124722.22425-1-jaslo@ziska.de>","References":"<20240813124722.22425-1-jaslo@ziska.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"us-ascii\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The device provider is not supposed to have control properties, remove\nthe auto-focus-mode property which was introduced by accident.\n\nFixes: 5a142438b025 (\"gstreamer: Add enable_auto_focus option to the GStreamer plugin\")\nSigned-off-by: Jaslo Ziska \n---\n src/gstreamer/gstlibcameraprovider.cpp | 15 ---------------\n 1 file changed, 15 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex 4fb1b007..5da96ea3 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -33,7 +33,6 @@ GST_DEBUG_CATEGORY_STATIC(provider_debug);\n \n enum {\n \tPROP_DEVICE_NAME = 1,\n-\tPROP_AUTO_FOCUS_MODE = 2,\n };\n \n #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n@@ -43,7 +42,6 @@ G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n struct _GstLibcameraDevice {\n \tGstDevice parent;\n \tgchar *name;\n-\tcontrols::AfModeEnum auto_focus_mode = controls::AfModeManual;\n };\n \n G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n@@ -60,7 +58,6 @@ gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n \tg_assert(source);\n \n \tg_object_set(source, \"camera-name\", GST_LIBCAMERA_DEVICE(device)->name, nullptr);\n-\tg_object_set(source, \"auto-focus-mode\", GST_LIBCAMERA_DEVICE(device)->auto_focus_mode, nullptr);\n \n \treturn source;\n }\n@@ -87,9 +84,6 @@ gst_libcamera_device_set_property(GObject *object, guint prop_id,\n \tcase PROP_DEVICE_NAME:\n \t\tdevice->name = g_value_dup_string(value);\n \t\tbreak;\n-\tcase PROP_AUTO_FOCUS_MODE:\n-\t\tdevice->auto_focus_mode = static_cast(g_value_get_enum(value));\n-\t\tbreak;\n \tdefault:\n \t\tG_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);\n \t\tbreak;\n@@ -129,15 +123,6 @@ gst_libcamera_device_class_init(GstLibcameraDeviceClass *klass)\n \t\t\t\t\t\t(GParamFlags)(G_PARAM_STATIC_STRINGS | G_PARAM_WRITABLE |\n \t\t\t\t\t\t\t G_PARAM_CONSTRUCT_ONLY));\n \tg_object_class_install_property(object_class, PROP_DEVICE_NAME, pspec);\n-\n-\tpspec = g_param_spec_enum(\"auto-focus-mode\",\n-\t\t\t\t \"Set auto-focus mode\",\n-\t\t\t\t \"Available options: AfModeManual, \"\n-\t\t\t\t \"AfModeAuto or AfModeContinuous.\",\n-\t\t\t\t gst_libcamera_auto_focus_get_type(),\n-\t\t\t\t static_cast(controls::AfModeManual),\n-\t\t\t\t G_PARAM_WRITABLE);\n-\tg_object_class_install_property(object_class, PROP_AUTO_FOCUS_MODE, pspec);\n }\n \n static GstDevice *\n","prefixes":["v2","1/3"]}