[{"id":30935,"web_url":"https://patchwork.libcamera.org/comment/30935/","msgid":"","date":"2024-08-28T07:22:10","subject":"Re: [PATCH v4 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Aug 13, 2024 at 10:44:23AM +0200, Stefan Klug wrote:\n> The rkisp1 tuner used a static module to insert the AWB algorithm into\n> the tuning file. Replace that with the new AWB module.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> utils/tuning/rkisp1.py | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index f5c42a61d15e..9f40fd8bd63b 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -2,6 +2,7 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> #\n> # Copyright (C) 2022, Paul Elder \n> +# Copyright (C) 2024, Ideas On Board\n> #\n> # Tuning script for rkisp1\n> \n> @@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> +from libtuning.modules.awb import AWBRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> from libtuning.modules.static import StaticModule\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> agc = AGCRkISP1(debug=[lt.Debug.Plot])\n> -awb = StaticModule('Awb')\n> +awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')\n> -- \n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 72170C323E\n\tfor ;\n\tWed, 28 Aug 2024 07:22:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A35F63466;\n\tWed, 28 Aug 2024 09:22:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 389F56345D\n\tfor ;\n\tWed, 28 Aug 2024 09:22:18 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:632b:90c4:b4b9:9e22])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9D71B844;\n\tWed, 28 Aug 2024 09:21:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SANzZUgc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724829670;\n\tbh=XZH3jPSPeJTHUZpTzM5+1M9DH9vY2xDPOkJPyW8FDI0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SANzZUgce3bR6qm0na3nLZwGa3c7C0LWaHDltSIjSbiuVlsvNFN1l+YlvGD4Zwxgy\n\t6VKNmQ42XrCs7VwiOEyoHrglyehz6gu991NXR0nuaTirQV0KuYhPEpNnegGjEcFvkZ\n\tIGgaEYZ6R0KmaovqkBCz9uNUbpZ4NUqYbHvBn0rE=","Date":"Wed, 28 Aug 2024 16:22:10 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","Message-ID":"","References":"<20240813084451.44099-1-stefan.klug@ideasonboard.com>\n\t<20240813084451.44099-7-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240813084451.44099-7-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30974,"web_url":"https://patchwork.libcamera.org/comment/30974/","msgid":"<20240829233303.GC26181@pendragon.ideasonboard.com>","date":"2024-08-29T23:33:03","subject":"Re: [PATCH v4 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Stefan,\n\nThank you for the patch.\n\nOn Tue, Aug 13, 2024 at 10:44:23AM +0200, Stefan Klug wrote:\n> The rkisp1 tuner used a static module to insert the AWB algorithm into\n> the tuning file. Replace that with the new AWB module.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\nI would probably move the three tuning tool patches to the beginning of\nthe series, I had to read them before reviewing 2/6 and 3/6 to\nunderstand what was happening.\n\n> ---\n> utils/tuning/rkisp1.py | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index f5c42a61d15e..9f40fd8bd63b 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -2,6 +2,7 @@\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> #\n> # Copyright (C) 2022, Paul Elder \n> +# Copyright (C) 2024, Ideas On Board\n> #\n> # Tuning script for rkisp1\n> \n> @@ -14,13 +15,14 @@ from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> +from libtuning.modules.awb import AWBRkISP1\n> from libtuning.modules.ccm import CCMRkISP1\n> from libtuning.modules.static import StaticModule\n> \n> coloredlogs.install(level=logging.INFO, fmt='%(name)s %(levelname)s %(message)s')\n> \n> agc = AGCRkISP1(debug=[lt.Debug.Plot])\n> -awb = StaticModule('Awb')\n> +awb = AWBRkISP1(debug=[lt.Debug.Plot])\n> blc = StaticModule('BlackLevelCorrection')\n> ccm = CCMRkISP1(debug=[lt.Debug.Plot])\n> color_processing = StaticModule('ColorProcessing')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E833C323E\n\tfor ;\n\tThu, 29 Aug 2024 23:33:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A14E63458;\n\tFri, 30 Aug 2024 01:33:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3A376002E\n\tfor ;\n\tFri, 30 Aug 2024 01:33:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF3E23A2;\n\tFri, 30 Aug 2024 01:32:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RWa5d/iL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724974346;\n\tbh=DVmi9Z08QzjI6KMHV94yp4qtgvyr0GhONHJ/264Atus=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RWa5d/iLKAkUugPYZO7cxXHJng1BFt2vEwKJ9nPB/7t05Pk2C2jndkFTaOw2eUkQr\n\tlhkzvQA1pBxdgwOUjvnW/iSrTw+q8JDqNyN89HevrznF0Hon2aIEQciJgKCamRLcBt\n\t/PA3dw6dSAfPY6+b21IK6bJIt4lN9fqzQVJ7rv64=","Date":"Fri, 30 Aug 2024 02:33:03 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"Re: [PATCH v4 6/6] utils: tuning: rkisp1: Replace static AWB with\n\tnew AWB module","Message-ID":"<20240829233303.GC26181@pendragon.ideasonboard.com>","References":"<20240813084451.44099-1-stefan.klug@ideasonboard.com>\n\t<20240813084451.44099-7-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240813084451.44099-7-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]