{"id":20890,"url":"https://patchwork.libcamera.org/api/patches/20890/?format=json","web_url":"https://patchwork.libcamera.org/patch/20890/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240812115009.946036-17-mzamazal@redhat.com>","date":"2024-08-12T11:50:05","name":"[16/16] libcamera: software_isp: Remove stats-sharing TODO item","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af63376bf3fa2ffad39818605ae920749182b3ba","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20890/mbox/","series":[{"id":4511,"url":"https://patchwork.libcamera.org/api/series/4511/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4511","date":"2024-08-12T11:49:49","name":"Software ISP: Share params and stats buffers","version":1,"mbox":"https://patchwork.libcamera.org/series/4511/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20890/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20890/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7860FC323E\n\tfor ;\n\tMon, 12 Aug 2024 11:50:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 177D2633CA;\n\tMon, 12 Aug 2024 13:50:57 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 903AA633DB\n\tfor ;\n\tMon, 12 Aug 2024 13:50:47 +0200 (CEST)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-687-PM8kHWjdNMm_BWu7ukP3PQ-1;\n\tMon, 12 Aug 2024 07:50:45 -0400","from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 434971954B16 for ;\n\tMon, 12 Aug 2024 11:50:44 +0000 (UTC)","from nuthatch.redhat.com (unknown [10.45.225.57])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 33E9219772C4; Mon, 12 Aug 2024 11:50:42 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"etuepSCM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723463446;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=YIGnnrU9sn832F49PZotPozmJP3zPpgRObwzrRoBQfE=;\n\tb=etuepSCMEryT09t/oDtNLX4sO8I+3d4y/bTvxgjqe8i0JMns4LwVbl268Z6kXRMx387TCP\n\tfaMiRoeBtdh+o7O0Z88Tj8OTM/SHL/ur753NybMr9NKO0YhCs7o1+/lOPqwb/p9tZ0OI+s\n\tjVnUT7pY1F+YB6g4XFGxZ7E1Uy+eR80=","X-MC-Unique":"PM8kHWjdNMm_BWu7ukP3PQ-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ","Subject":"[PATCH 16/16] libcamera: software_isp: Remove stats-sharing TODO\n\titem","Date":"Mon, 12 Aug 2024 13:50:05 +0200","Message-ID":"<20240812115009.946036-17-mzamazal@redhat.com>","In-Reply-To":"<20240812115009.946036-1-mzamazal@redhat.com>","References":"<20240812115009.946036-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.15","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Shared per-frame statistics buffers are implemented, we can remove\nTODO #2.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/TODO | 27 ---------------------------\n 1 file changed, 27 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO\nindex db1115dd..b83c3ba3 100644\n--- a/src/libcamera/software_isp/TODO\n+++ b/src/libcamera/software_isp/TODO\n@@ -1,30 +1,3 @@\n-2. Reconsider stats sharing\n-\n->>> +void SwStatsCpu::finishFrame(void)\n->>> +{\n->>> +\t*sharedStats_ = stats_;\n->> \n->> Is it more efficient to copy the stats instead of operating directly on\n->> the shared memory ?\n->\n-> I inherited doing things this way from Andrey. I kept this because\n-> we don't really have any synchronization with the IPA reading this.\n->\n-> So the idea is to only touch this when the next set of statistics\n-> is ready since we don't know when the IPA is done with accessing\n-> the previous set of statistics ...\n->\n-> This is both something which seems mostly a theoretic problem,\n-> yet also definitely something which I think we need to fix.\n->\n-> Maybe use a ringbuffer of stats buffers and pass the index into\n-> the ringbuffer to the emit signal ?\n-\n-That would match how we deal with hardware ISPs, and I think that's a\n-good idea. It will help decoupling the processing side from the IPA.\n-\n----\n-\n 3. Remove statsReady signal\n \n > class SwStatsCpu\n","prefixes":["16/16"]}