[{"id":30724,"web_url":"https://patchwork.libcamera.org/comment/30724/","msgid":"<875xs6w85e.fsf@redhat.com>","date":"2024-08-12T06:46:21","subject":"Re: [PATCH] libcamera: Fix header grouping","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n\n> The libcamera coding style groups the C and C++ standard library headers\n> in a single group. Fix the few offenders in the source tree.\n>\n> While at it, add a missing blank line between header groups in a\n> separate location.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Milan Zamazal \n\n> ---\n> include/libcamera/base/file.h | 5 ++---\n> include/libcamera/ipa/ipa_interface.h | 3 +--\n> src/gstreamer/gstlibcamerapool.cpp | 1 +\n> src/ipa/libipa/camera_sensor_helper.h | 3 +--\n> 4 files changed, 5 insertions(+), 7 deletions(-)\n>\n> diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> index 192668abeff1..6d3f106d5900 100644\n> --- a/include/libcamera/base/file.h\n> +++ b/include/libcamera/base/file.h\n> @@ -7,11 +7,10 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -\n> #include \n> +#include \n> #include \n> +#include \n> \n> #include \n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 53cf5377fcc6..7c835e984442 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,10 +7,9 @@\n> \n> #pragma once\n> \n> +#include \n> #include \n> #include \n> -\n> -#include \n> #include \n> \n> #include \n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index 0b1a5689eadb..9cd7eccb5af3 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -9,6 +9,7 @@\n> #include \"gstlibcamerapool.h\"\n> \n> #include \n> +\n> #include \n> \n> #include \"gstlibcamera-utils.h\"\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index ac276e27f523..758682058b9c 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -7,10 +7,9 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n>\n> base-commit: 62760bd2605a83e663b9003244ff42f8946f8955","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78C7CBE173\n\tfor ;\n\tMon, 12 Aug 2024 06:46:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 260CB633B4;\n\tMon, 12 Aug 2024 08:46:30 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 47B256338D\n\tfor ;\n\tMon, 12 Aug 2024 08:46:28 +0200 (CEST)","from mail-ed1-f70.google.com (mail-ed1-f70.google.com\n\t[209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-80-bvR6qEeJPPiESy0PYlD9UQ-1; Mon, 12 Aug 2024 02:46:25 -0400","by mail-ed1-f70.google.com with SMTP id\n\t4fb4d7f45d1cf-58bd84067fdso3023297a12.0\n\tfor ;\n\tSun, 11 Aug 2024 23:46:25 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-5bd191a1e8esm1854737a12.37.2024.08.11.23.46.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 11 Aug 2024 23:46:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"a+8oSwuW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1723445187;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=FVtxFIHQ9gUfU7oIAYLFWMW7EyMKeVEiL/0GNDgiUlQ=;\n\tb=a+8oSwuWOWxsm9B1d/u15pzEqT1D0+4K7lHRfLxB+gr6Ms7eOgC6TQ9g65RqoG0FkYdLhR\n\tUcdhaF3pan9XvqkfIcVGik8jQdi8VL3dWx+g+g5AYY4NZcZ0ISOEjEeKlI+gDHb1MLVYjn\n\tFyBvvjDY8QfwWF2RUM5pGQlbadGqv24=","X-MC-Unique":"bvR6qEeJPPiESy0PYlD9UQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723445184; x=1724049984;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FVtxFIHQ9gUfU7oIAYLFWMW7EyMKeVEiL/0GNDgiUlQ=;\n\tb=bbWgsFbPmK+RSbFkk7CpbzpPS6zPw7N8rwFE15EInj0iVN7ZBYS30csp1WjouMig4b\n\tb2Rj9H7FfcgYtvdh1QEgkMZzmzJMflpJYKNNkU4GKZudyLb0g9YldEZGVofbTZugvwah\n\tonvoV3aJNvQdbpF3r4Zg7uuoR5UQbyArTp8UmPCeebk0d5UZILD8Y/Ydw1ClAuGtMvf8\n\tLBp4Hw8S8JkBlSOZYaoh56N/MwgQB3hVWwKiwi0Qhp8OXzOrN6YHIM40hYFAmNCclgEs\n\tBvX+tACQZPcMFuafoacGjrsuwL1J1yDcTrr8ZpBsdTdWer2gOHiLACknQCuzrWNUIEPG\n\tje7A==","X-Gm-Message-State":"AOJu0Yyq/PR75M790nQwnSiIi/0DASnkjP30bIcRXQ7gsdvPehbw95dy\n\tchmbthHyQdG7Ai+ACI960DEDG1XI9UavNgSRsSDYE237qjfrMuS27UBKwlhpfbTKNCmoiYSDcdu\n\tADOPVDGF4DWirs4GX31aEZgdnev+cRPAO2URCYT4q4fJvyAtkuuqvzzf3G/feJqRlcsr/9cNVUL\n\tx6EE4CIRylqolHnwTcs0aoXMOSpfrXCEr+VyEXNlrVHCvn6rEUNXAGAsQ=","X-Received":["by 2002:a05:6402:2111:b0:5a2:2b56:e08e with SMTP id\n\t4fb4d7f45d1cf-5bd0a5662d5mr6292080a12.18.1723445183694; \n\tSun, 11 Aug 2024 23:46:23 -0700 (PDT)","by 2002:a05:6402:2111:b0:5a2:2b56:e08e with SMTP id\n\t4fb4d7f45d1cf-5bd0a5662d5mr6292064a12.18.1723445183149; \n\tSun, 11 Aug 2024 23:46:23 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IHwjVEcdgpp+HCEVETt9qUmTF0TEmwSvsxp+t829UCaos1qaHLN48O8Y0euQT42DJJePIQjKQ==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: Fix header grouping","In-Reply-To":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>\n\t(Laurent Pinchart's message of \"Sat, 10 Aug 2024 04:17:46 +0300\")","References":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>","Date":"Mon, 12 Aug 2024 08:46:21 +0200","Message-ID":"<875xs6w85e.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30726,"web_url":"https://patchwork.libcamera.org/comment/30726/","msgid":"<8328c96c-300d-4f77-8ab2-88992ca27dc2@ideasonboard.com>","date":"2024-08-12T10:35:18","subject":"Re: [PATCH] libcamera: Fix header grouping","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent, thanks for the patch\n\nOn 10/08/2024 02:17, Laurent Pinchart wrote:\n> The libcamera coding style groups the C and C++ standard library headers\n> in a single group. Fix the few offenders in the source tree.\n>\n> While at it, add a missing blank line between header groups in a\n> separate location.\n>\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Daniel Scally \n\n> ---\n> include/libcamera/base/file.h | 5 ++---\n> include/libcamera/ipa/ipa_interface.h | 3 +--\n> src/gstreamer/gstlibcamerapool.cpp | 1 +\n> src/ipa/libipa/camera_sensor_helper.h | 3 +--\n> 4 files changed, 5 insertions(+), 7 deletions(-)\n>\n> diff --git a/include/libcamera/base/file.h b/include/libcamera/base/file.h\n> index 192668abeff1..6d3f106d5900 100644\n> --- a/include/libcamera/base/file.h\n> +++ b/include/libcamera/base/file.h\n> @@ -7,11 +7,10 @@\n> \n> #pragma once\n> \n> -#include \n> -#include \n> -\n> #include \n> +#include \n> #include \n> +#include \n> \n> #include \n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 53cf5377fcc6..7c835e984442 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -7,10 +7,9 @@\n> \n> #pragma once\n> \n> +#include \n> #include \n> #include \n> -\n> -#include \n> #include \n> \n> #include \n> diff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\n> index 0b1a5689eadb..9cd7eccb5af3 100644\n> --- a/src/gstreamer/gstlibcamerapool.cpp\n> +++ b/src/gstreamer/gstlibcamerapool.cpp\n> @@ -9,6 +9,7 @@\n> #include \"gstlibcamerapool.h\"\n> \n> #include \n> +\n> #include \n> \n> #include \"gstlibcamera-utils.h\"\n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index ac276e27f523..758682058b9c 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -7,10 +7,9 @@\n> \n> #pragma once\n> \n> -#include \n> -\n> #include \n> #include \n> +#include \n> #include \n> #include \n> \n>\n> base-commit: 62760bd2605a83e663b9003244ff42f8946f8955","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5133CBE173\n\tfor ;\n\tMon, 12 Aug 2024 10:35:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29D4B633B5;\n\tMon, 12 Aug 2024 12:35:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1D1BB63369\n\tfor ;\n\tMon, 12 Aug 2024 12:35:20 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BEB206B5\n\tfor ;\n\tMon, 12 Aug 2024 12:34:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FFjsimY4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723458863;\n\tbh=8yRoz+ocQhptRg2vFQORyWdJgMEHP8mHZciHBN/dqiE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=FFjsimY4A2NGiHa1dd6/5aeNkV3Xr3mmG04rxe/DLKwLZ5c6+fg+Un6zBWRWSZ+9L\n\t6nobYg9l/mw1NzLfK9ksTwpP6W1QzLcimiFL2uN9+z6mF1eZsNkzOh3w8y9RHhwHJk\n\tlkXWtyZkRSzM31vrfusoG27wE8lYROyvyKe02W0E=","Message-ID":"<8328c96c-300d-4f77-8ab2-88992ca27dc2@ideasonboard.com>","Date":"Mon, 12 Aug 2024 11:35:18 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: Fix header grouping","To":"libcamera-devel@lists.libcamera.org","References":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240810011746.21481-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]