[{"id":2771,"web_url":"https://patchwork.libcamera.org/comment/2771/","msgid":"<20191003215000.GH4737@pendragon.ideasonboard.com>","date":"2019-10-03T21:50:00","subject":"Re: [libcamera-devel] [PATCH v4 03/11] libcamera: controls: Add\n\tAeLocked control","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Oct 03, 2019 at 07:49:33PM +0200, Niklas Söderlund wrote:\n> Add a control to report lock status of the Auto Exposure algorithm. The\n> idea is that if an AE algorithm is running the control shall be added to\n> the meta data control list.\n> \n> If the AE algorithm is locked the value shall be set to true, if it's\n> converging it shall be set to false. If the AE algorithm is not running\n> the control shall not be present in the meta data control list.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/control_ids.yaml | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 4626f6ef48bcaeea..142bdede2b96c0e0 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -12,6 +12,13 @@ controls:\n> \n> \\sa ManualExposure\n> \n> + - AeLocked:\n> + type: bool\n> + description: |\n> + Report the lock status of a running AE algorithm.\n\nI think you should capture here the documentation from the commit\nmessage. With that fixed,\n\nReviewed-by: Laurent Pinchart \n\n> +\n> + \\sa AeEnable\n> +\n> - AwbEnable:\n> type: bool\n> description: |","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFF0E60BE8\n\tfor ;\n\tThu, 3 Oct 2019 23:50:14 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [132.205.229.214])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C4B8B2E5;\n\tThu, 3 Oct 2019 23:50:13 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1570139414;\n\tbh=BvyBiesx9Ax3tjYFXXamNK6ZLYtcel3BoGIHJ2AIhTg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lPAJZ1T+R8BC+9MjqnEDXKbjYnRIDVD9jmBwYeMT+M9qVQbYhUcMaukh13fNJGOkV\n\thlm0SszaO5/bWtWLo1vatrwn100aYcmPWZ35Rx/xk33/1r0HUvuykmTSp1OkhdWBnm\n\tU0OKrWTYNW4/WFHSH3ZMo7GzuHxL/weedgwenn70=","Date":"Fri, 4 Oct 2019 00:50:00 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191003215000.GH4737@pendragon.ideasonboard.com>","References":"<20191003174941.1296988-1-niklas.soderlund@ragnatech.se>\n\t<20191003174941.1296988-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20191003174941.1296988-4-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v4 03/11] libcamera: controls: Add\n\tAeLocked control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 03 Oct 2019 21:50:15 -0000"}}]