[{"id":30717,"web_url":"https://patchwork.libcamera.org/comment/30717/","msgid":"<20240810122806.GB7180@pendragon.ideasonboard.com>","date":"2024-08-10T12:28:06","subject":"Re: [PATCH] libcamera: v4l2_videodevice: Improve readability","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran and Stefan,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2024 at 06:30:41PM +0100, Kieran Bingham wrote:\n> From: Stefan Klug \n> \n> The handling for the sequence number validation within\n> V4L2VideoDevice::dequeueBuffer makes use of a std::optional, which can\n> be used as a boolean in conditional statements. This has the impact in\n> this use case that it can be mis-read to be interpretting the value fo\n\ns/interpretting/interpreting/\n\n> firstFrame_ which is assigned as teh buf.sequence.\n\ns/teh/the/\n\n> \n> Remove this potential for confusion by making it clear that the first\n> frame handling is only performed when firstFrame_ does not have a value\n> assigned.\n> \n> Signed-off-by: Stefan Klug \n> [Kieran: Rework commit message]\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index 6f32521f3d6f..59379308d5b3 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1841,7 +1841,7 @@ FrameBuffer *V4L2VideoDevice::dequeueBuffer()\n> \t * Detect kernel drivers which do not reset the sequence number to zero\n> \t * on stream start.\n> \t */\n> -\tif (!firstFrame_) {\n> +\tif (!firstFrame_.has_value()) {\n> \t\tif (buf.sequence)\n> \t\t\tLOG(V4L2, Info)\n> \t\t\t\t<< \"Zero sequence expected for first frame (got \"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 808FEBE173\n\tfor ;\n\tSat, 10 Aug 2024 12:28:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB1C163393;\n\tSat, 10 Aug 2024 14:28:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD2666338D\n\tfor ;\n\tSat, 10 Aug 2024 14:28:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADF532D5;\n\tSat, 10 Aug 2024 14:27:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WDkl6cGj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723292855;\n\tbh=gk0U5cFmUzP2v5TN4t0lK/38hXsKo2+KlIsWWxjcWns=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WDkl6cGjX5aoSAbedqtug3Qk869bF8omlSb+X1ro0G2SNKU+g5yiuKo/xVJJ9myf2\n\tyFBKJ3D6aHBhH2AfDJrfg00GfjlqhE5dFmZa0sDikhg85ayDhHaNSHMCgDIsMZ1Re1\n\tS6yzoIJmWSDKPrKjwuBIoOYxPek9y7pVodBxf1v0=","Date":"Sat, 10 Aug 2024 15:28:06 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ,\n\tStefan Klug ","Subject":"Re: [PATCH] libcamera: v4l2_videodevice: Improve readability","Message-ID":"<20240810122806.GB7180@pendragon.ideasonboard.com>","References":"<20240808173041.2505335-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240808173041.2505335-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]