[{"id":30716,"web_url":"https://patchwork.libcamera.org/comment/30716/","msgid":"<20240810122509.GA7180@pendragon.ideasonboard.com>","date":"2024-08-10T12:25:09","subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2024 at 05:57:01PM +0100, Kieran Bingham wrote:\n> Configure the default sensor black level reported by the datasheet.\n\ns/Configure/Report/ maybe ?\n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c07b1a8dcaec..039109f9540d 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -549,6 +549,8 @@ class CameraSensorHelperImx283 : public CameraSensorHelper\n> public:\n> \tCameraSensorHelperImx283()\n> \t{\n> +\t\t/* From datasheet: 0x32 at 10bits. */\n> +\t\tblackLevel_ = 3200;\n\nIt's funny that 0x32 << 6 == 3200 :-)\n\nReviewed-by: Laurent Pinchart \n\n> \t\tgainType_ = AnalogueGainLinear;\n> \t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB6EFBE173\n\tfor ;\n\tSat, 10 Aug 2024 12:25:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AE0FB633B5;\n\tSat, 10 Aug 2024 14:25:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B2F36338D\n\tfor ;\n\tSat, 10 Aug 2024 14:25:34 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C44A2D5;\n\tSat, 10 Aug 2024 14:24:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ahs0YKyv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723292679;\n\tbh=bti9WIsBkBUEVIlgcgEqK2PX/2o7Bq4CIksf3Eyvi80=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ahs0YKyvcUP8gCkF0BtvYVmxMzRzJHOW9ETOCeVq6X2CQloaFPtHQZafIbcigBaN2\n\t2zN9WARn3cizpKF9PfBtmcR4503qfzqvVviuRqAuyeXW2f4w7dK4PZJKaYfmdms363\n\tsM5adN59g71sJOM9jBYK02+BP3Ujc+a/mnyEIEVc=","Date":"Sat, 10 Aug 2024 15:25:09 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level","Message-ID":"<20240810122509.GA7180@pendragon.ideasonboard.com>","References":"<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":31183,"web_url":"https://patchwork.libcamera.org/comment/31183/","msgid":"","date":"2024-09-12T08:45:10","subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch. \n\nOn Thu, Aug 08, 2024 at 05:57:01PM +0100, Kieran Bingham wrote:\n> Configure the default sensor black level reported by the datasheet.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c07b1a8dcaec..039109f9540d 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -549,6 +549,8 @@ class CameraSensorHelperImx283 : public CameraSensorHelper\n> public:\n> \tCameraSensorHelperImx283()\n> \t{\n> +\t\t/* From datasheet: 0x32 at 10bits. */\n> +\t\tblackLevel_ = 3200;\n> \t\tgainType_ = AnalogueGainLinear;\n> \t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n> \t}\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D7C38C324C\n\tfor ;\n\tThu, 12 Sep 2024 08:45:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78E76634FB;\n\tThu, 12 Sep 2024 10:45:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8F70618F6\n\tfor ;\n\tThu, 12 Sep 2024 10:45:13 +0200 (CEST)","from ideasonboard.com (213-229-8-243.static.upcbusiness.at\n\t[213.229.8.243])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D02A1083;\n\tThu, 12 Sep 2024 10:43:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i0OLiCjD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1726130635;\n\tbh=1VA7Aq+mbrn0DE+5NLG/tCszAmkSJkW++bqcin3M11k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i0OLiCjD4vFpp4fSWVf+/5FohwHMB5lx6rtdyb/E+3rvpZFpH1qsutkiiAjUpzMvB\n\tWAl6WLICD2NLpMhkzLKs/a5dYPpYEublfrNqUBaIqCm68Hknx5+q3vX9MMih4qSGSm\n\tP8dYwOSJ6K1lbV7AyC07PcalVeHWtAEHbEQKKftA=","Date":"Thu, 12 Sep 2024 10:45:10 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add IMX283 black level","Message-ID":"","References":"<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240808165701.2442029-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]