[{"id":30955,"web_url":"https://patchwork.libcamera.org/comment/30955/","msgid":"<20240828170424.GK27131@pendragon.ideasonboard.com>","date":"2024-08-28T17:04:24","subject":"Re: [PATCH v1 6/7] pipeline: rpi: Pass ISP output index into\n\tplatformSetIspCrop()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2024 at 11:23:45AM +0100, Naushir Patuck wrote:\n> At this point, the index is unused, but will be in a future commit where\n> we can set different crops on each ISP output.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 +-\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-\n> src/libcamera/pipeline/rpi/vc4/vc4.cpp | 4 ++--\n> 3 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index 412e71648231..a6ea4e9c47dd 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -1317,7 +1317,7 @@ void CameraData::applyScalerCrop(const ControlList &controls)\n> \n> \t\tif (ispCrop != cropParams.ispCrop) {\n> \t\t\tcropParams.ispCrop = ispCrop;\n> -\t\t\tplatformSetIspCrop(ispCrop);\n> +\t\t\tplatformSetIspCrop(cropParams.ispIndex, ispCrop);\n> \t\t}\n> \t}\n> }\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index 0ccfa4e82e86..7959d874dd6f 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -83,7 +83,7 @@ public:\n> \n> \tRectangle scaleIspCrop(const Rectangle &ispCrop) const;\n> \tvoid applyScalerCrop(const ControlList &controls);\n> -\tvirtual void platformSetIspCrop(const Rectangle &ispCrop) = 0;\n> +\tvirtual void platformSetIspCrop(unsigned int index, const Rectangle &ispCrop) = 0;\n> \n> \tvoid cameraTimeout();\n> \tvoid frameStarted(uint32_t sequence);\n> diff --git a/src/libcamera/pipeline/rpi/vc4/vc4.cpp b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> index ffc45653daf1..04fb3c066baf 100644\n> --- a/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> +++ b/src/libcamera/pipeline/rpi/vc4/vc4.cpp\n> @@ -109,7 +109,7 @@ public:\n> \tConfig config_;\n> \n> private:\n> -\tvoid platformSetIspCrop(const Rectangle &ispCrop) override\n> +\tvoid platformSetIspCrop([[maybe_unused]] unsigned int index, const Rectangle &ispCrop) override\n> \t{\n> \t\tRectangle crop = ispCrop;\n> \t\tisp_[Isp::Input].dev()->setSelection(V4L2_SEL_TGT_CROP, &crop);\n> @@ -707,7 +707,7 @@ int Vc4CameraData::platformConfigure(const RPi::RPiCameraConfiguration *rpiConfi\n> \tSize size = unicamFormat.size.boundedToAspectRatio(maxSize);\n> \tRectangle ispCrop = size.centeredTo(Rectangle(unicamFormat.size).center());\n> \n> -\tplatformSetIspCrop(ispCrop);\n> +\tplatformSetIspCrop(0, ispCrop);\n> \t/*\n> \t * Set the scaler crop to the value we are using (scaled to native sensor\n> \t * coordinates).","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91221C323E\n\tfor ;\n\tWed, 28 Aug 2024 17:04:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5013263469;\n\tWed, 28 Aug 2024 19:04:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8026361E4F\n\tfor ;\n\tWed, 28 Aug 2024 19:04:29 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACDC02C5;\n\tWed, 28 Aug 2024 19:03:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LW/116sk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724864601;\n\tbh=Ft/Djw8I974nHet1Oxm0Xm9B8QwWkWeZ2lY3qct8esc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LW/116sk5DEV32eAxqh51agjf6N2IVG6tF0jvZr3lOtdncL99DsXyzaV/X9AN2Eu5\n\tFx2ju1D/Syt5NwMA3FtvJIBk6LqRKg+BBJexdbk+nWsI1O1Qo0ND+5wr3nFWBCQI3s\n\tYIqob3wsLD9nKemXXEFO6+AuJUGM8zHSDUtfUb4Y=","Date":"Wed, 28 Aug 2024 20:04:24 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 6/7] pipeline: rpi: Pass ISP output index into\n\tplatformSetIspCrop()","Message-ID":"<20240828170424.GK27131@pendragon.ideasonboard.com>","References":"<20240808102346.13065-1-naush@raspberrypi.com>\n\t<20240808102346.13065-7-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240808102346.13065-7-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]