[{"id":30701,"web_url":"https://patchwork.libcamera.org/comment/30701/","msgid":"<172310783937.1650394.1022643162239372795@ping.linuxembedded.co.uk>","date":"2024-08-08T09:03:59","subject":"Re: [PATCH] ipa: libipa: Add missing CameraSensorHelper fn label in\n\tdocs","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Milan Zamazal (2024-08-08 09:44:15)\n> The constructor reference was missing, causing the constructor\n> documentation to appear in blackLevel() documentation.\n\nOoops indeed.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Milan Zamazal \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c07b1a8d..ffc7c1d7 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -41,6 +41,7 @@ namespace ipa {\n> */\n> \n> /**\n> + * \\fn CameraSensorHelper::CameraSensorHelper()\n> * \\brief Construct a CameraSensorHelper instance\n> *\n> * CameraSensorHelper derived class instances shall never be constructed\n> -- \n> 2.44.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A967C323E\n\tfor ;\n\tThu, 8 Aug 2024 09:04:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3388963393;\n\tThu, 8 Aug 2024 11:04:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C8AA6337F\n\tfor ;\n\tThu, 8 Aug 2024 11:04:02 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD3E28D0;\n\tThu, 8 Aug 2024 11:03:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dRrPJ/rx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723107788;\n\tbh=Z7174SeqyQ8FiNgsx8QRDPWL8d39qui8TViCCmjYLFA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=dRrPJ/rxwe7+KOBntELPNJwHKx5lzRcDk2lrmypBw1ofQKsvSEmqMnY1XMpsWOMe1\n\tsxzPsu6RP3WEgg/+Bl7oek+5k6zPeQr+DAmVgGH47/ylPSSaX6W0eqqgDgBqMr8Jv4\n\tiuzwsZSUirC+siXhW2ybR9AdQ/njEPN0fl72R+gE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240808084415.261894-1-mzamazal@redhat.com>","References":"<20240808084415.261894-1-mzamazal@redhat.com>","Subject":"Re: [PATCH] ipa: libipa: Add missing CameraSensorHelper fn label in\n\tdocs","From":"Kieran Bingham ","Cc":"Milan Zamazal ","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Thu, 08 Aug 2024 10:03:59 +0100","Message-ID":"<172310783937.1650394.1022643162239372795@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30734,"web_url":"https://patchwork.libcamera.org/comment/30734/","msgid":"<20240812121337.GA21149@pendragon.ideasonboard.com>","date":"2024-08-12T12:13:37","subject":"Re: [PATCH] ipa: libipa: Add missing CameraSensorHelper fn label in\n\tdocs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan,\n\nThank you for the patch.\n\nOn Thu, Aug 08, 2024 at 10:44:15AM +0200, Milan Zamazal wrote:\n> The constructor reference was missing, causing the constructor\n> documentation to appear in blackLevel() documentation.\n> \n> Signed-off-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index c07b1a8d..ffc7c1d7 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -41,6 +41,7 @@ namespace ipa {\n> */\n> \n> /**\n> + * \\fn CameraSensorHelper::CameraSensorHelper()\n> * \\brief Construct a CameraSensorHelper instance\n> *\n> * CameraSensorHelper derived class instances shall never be constructed","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0411BC323E\n\tfor ;\n\tMon, 12 Aug 2024 12:14:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3604B633B9;\n\tMon, 12 Aug 2024 14:14:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D042A63398\n\tfor ;\n\tMon, 12 Aug 2024 14:14:00 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 640137CC;\n\tMon, 12 Aug 2024 14:13:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pljugQGH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723464784;\n\tbh=VM24ZQgUMFEsBdvlOVUKwWuQsrwYdMlE5PHNAgN96zA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pljugQGH77zp6uJkjfb89DD9xl8i2SOIKaNKAE1/F3S9oUPr0xmKUtu0jtJ4f4npF\n\tDjG7nFVMfYDYLUeTC0mlcP76W+AGEvVN/54gdYK8HatZilztXngBnZw1ZTBxnVXlLa\n\tcXkyVByP9NB8hiYE03lKeZ6+5Uq5yD6yACNb0+bU=","Date":"Mon, 12 Aug 2024 15:13:37 +0300","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: libipa: Add missing CameraSensorHelper fn label in\n\tdocs","Message-ID":"<20240812121337.GA21149@pendragon.ideasonboard.com>","References":"<20240808084415.261894-1-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240808084415.261894-1-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]