{"id":20827,"url":"https://patchwork.libcamera.org/api/patches/20827/?format=json","web_url":"https://patchwork.libcamera.org/patch/20827/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240807154410.9552-6-laurent.pinchart@ideasonboard.com>","date":"2024-08-07T15:44:10","name":"[v6,5/5] libcamera: camera: Hide Camera::create() from the public API","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6c9872d3af02876273c17a966fb5e37b4a5aa52f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20827/mbox/","series":[{"id":4497,"url":"https://patchwork.libcamera.org/api/series/4497/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4497","date":"2024-08-07T15:44:05","name":"Split libcamera documentation in public and internal APIs","version":6,"mbox":"https://patchwork.libcamera.org/series/4497/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20827/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20827/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF163C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed,  7 Aug 2024 15:44:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4823C633B9;\n\tWed,  7 Aug 2024 17:44:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B63C633B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Aug 2024 17:44:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6367F6AF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  7 Aug 2024 17:43:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z3jKQ+gb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723045427;\n\tbh=SMVJVYTg2/cWna/e1QQyfKmIcnnBLU6FwQqAkJCpIHQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Z3jKQ+gbEoZlYQfJLJRPflHAG8kEC2fXYM62UZmXtbcjOfgHwFO8agN8CUDwO8f66\n\tSLJwDwnkmSC5S+oIFqjpOSj8XshqbldATtYX3HDH93iJcAMWYYuh+XEYwhJFqkxwwg\n\tIueBiSdOkf/ddOIkm6QFQki2k13+q9kY2ihcrAVw=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v6 5/5] libcamera: camera: Hide Camera::create() from the\n\tpublic API","Date":"Wed,  7 Aug 2024 18:44:10 +0300","Message-ID":"<20240807154410.9552-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.44.2","In-Reply-To":"<20240807154410.9552-1-laurent.pinchart@ideasonboard.com>","References":"<20240807154410.9552-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The Camera::create() function is internal. Hide it from the public API\ndocumentation.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/camera.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex aca466c9ba72..382a68f7bddd 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -821,6 +821,7 @@ void Camera::Private::setState(State state)\n  */\n \n /**\n+ * \\internal\n  * \\brief Create a camera instance\n  * \\param[in] d Camera private data\n  * \\param[in] id The ID of the camera device\n","prefixes":["v6","5/5"]}