{"id":20814,"url":"https://patchwork.libcamera.org/api/patches/20814/?format=json","web_url":"https://patchwork.libcamera.org/patch/20814/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240807093449.1926-2-naush@raspberrypi.com>","date":"2024-08-07T09:34:48","name":"[v1,1/2] libcamera: formats: Adding Support for Y12P","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a59fe7406a9aadf144ca97bc1cb3ece6aa6c4e72","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20814/mbox/","series":[{"id":4493,"url":"https://patchwork.libcamera.org/api/series/4493/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4493","date":"2024-08-07T09:34:47","name":"Raspberrypi: Add support for IMX283","version":1,"mbox":"https://patchwork.libcamera.org/series/4493/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20814/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20814/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83348C323E\n\tfor ;\n\tWed, 7 Aug 2024 09:34:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C98B63393;\n\tWed, 7 Aug 2024 11:34:57 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD9263382\n\tfor ;\n\tWed, 7 Aug 2024 11:34:55 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-42808071810so10638585e9.1\n\tfor ;\n\tWed, 07 Aug 2024 02:34:55 -0700 (PDT)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-36bbcf1daeesm15449769f8f.33.2024.08.07.02.34.53\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Aug 2024 02:34:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"i6P8cEE9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1723023295; x=1723628095;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BNeV+Mfh0xbbAy8/qvUjwm5fxs31OnXjJZpMfecEHuQ=;\n\tb=i6P8cEE9V2NYEVbFOE9IMejxet72ER2P+8EoWNNmhQrOScFtew3/Wn5XjdT0uRwSwQ\n\taI6LgiBWRRkpdE6v0Kpil7BrYZYb1V0qBWbx1qJtfoStVSbBOGPkpFkUdALEPkhl0k5E\n\t82sZCsKiAjJKEVho2GkwB0SZ2m+zVOaEDF+FvEM8Ib0+Bn8ncSnIc6M4PkHUEY67vIpK\n\tP3oC4JJp4uazZp6KQ1o6UasJ5IsHqTi1+PSDAdYQ/9S3l0sh5XEELk/MVYHhKyJZEwbC\n\tlnFtAfgm6ifTLsUDeAEAAsGN+UGfGYaiXDhZGJYBA3pOb5HKCbyEyoLmIB9nmLcjTaa5\n\tTUPw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723023295; x=1723628095;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=BNeV+Mfh0xbbAy8/qvUjwm5fxs31OnXjJZpMfecEHuQ=;\n\tb=DfbmPHDBWpjCnTMf2UVCUh7ST40rKqyfhBacN16X8F6tymc7Epd7H5EtXMyOpRZo4O\n\tpLNxje1kCqGk8Q4t1xFgIXYKY7U9mWBWs8i7rFBEFP4OFtlFtwW5GgW9f0NlDtTWhUyD\n\tKbc+q8nLcb2p1l7PiJ7coaOSLEkvbSpVQ3PI3Sclfl0IOmMrhissrw7hzLV8tYqjHjFH\n\t8kzjo6hCx02Zze0hfDchrO3L5jKtFA70pWgVdRFglahV3XFQsQ/is7juXw+kDFDF7bKM\n\toNxDHCC98tNzsi0pFuO6MBIRfRe6UqfeKOYgK1kYxHeKMBCbJJ0WWZE/6Ey23hLcC1lI\n\tbQrg==","X-Gm-Message-State":"AOJu0YylJzwq+Wkp1w1/A83IFaKRaEmZPYMwXhbBVPEekyso4TGWn78+\n\tFOgnczrMKtsTMqdTe2/xs2LEv7iXISQ3fQZEg+q/+bVr7kyr5Dbj+gmR4tN/ZJYNwhbWm9/sAM7\n\tc","X-Google-Smtp-Source":"AGHT+IFxjvrLvJcdg7mhF3Lcj0gxIPxj68qmYyocwhWGf29XAZBFxcvt06agmT7VLo6m94onN101Vg==","X-Received":"by 2002:adf:ea4d:0:b0:368:664a:d4f9 with SMTP id\n\tffacd0b85a97d-36bbc0e8a82mr13082807f8f.28.1723023294414; \n\tWed, 07 Aug 2024 02:34:54 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"will whang , Naushir Patuck ","Subject":"[PATCH v1 1/2] libcamera: formats: Adding Support for Y12P","Date":"Wed, 7 Aug 2024 10:34:48 +0100","Message-Id":"<20240807093449.1926-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240807093449.1926-1-naush@raspberrypi.com>","References":"<20240807093449.1926-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: will whang \n\nAdd support for the 12-bit Mono (V4L2_PIX_FMT_Y12P) format.\nThis format is used by the IMX585 mono sensor.\n\nSigned-off-by: will whang \nSigned-off-by: Naushir Patuck \n---\n src/libcamera/bayer_format.cpp | 2 ++\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/formats.yaml | 3 +++\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n 4 files changed, 17 insertions(+)","diff":"diff --git a/src/libcamera/bayer_format.cpp b/src/libcamera/bayer_format.cpp\nindex 014f716d28f7..c2120d1c16d7 100644\n--- a/src/libcamera/bayer_format.cpp\n+++ b/src/libcamera/bayer_format.cpp\n@@ -184,6 +184,8 @@ const std::map bayerToFormat{\n \t\t{ formats::R10_CSI2P, V4L2PixelFormat(V4L2_PIX_FMT_Y10P) } },\n \t{ { BayerFormat::MONO, 12, BayerFormat::Packing::None },\n \t\t{ formats::R12, V4L2PixelFormat(V4L2_PIX_FMT_Y12) } },\n+\t{ { BayerFormat::MONO, 12, BayerFormat::Packing::CSI2 },\n+\t\t{ formats::R12_CSI2P, V4L2PixelFormat(V4L2_PIX_FMT_Y12P) } },\n \t{ { BayerFormat::MONO, 16, BayerFormat::Packing::None },\n \t\t{ formats::R16, V4L2PixelFormat(V4L2_PIX_FMT_Y16) } },\n \t{ { BayerFormat::MONO, 16, BayerFormat::Packing::PISP1 },\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex cf41f2c261ed..f338fc373f33 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -527,6 +527,16 @@ const std::map pixelFormatInfo{\n \t\t.pixelsPerGroup = 4,\n \t\t.planes = {{ { 5, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::R12_CSI2P, {\n+\t\t.name = \"R12_CSI2P\",\n+\t\t.format = formats::R12_CSI2P,\n+\t\t.v4l2Formats = { V4L2PixelFormat(V4L2_PIX_FMT_Y12P), },\n+\t\t.bitsPerPixel = 12,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n+\t\t.packed = true,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::R12, {\n \t\t.name = \"R12\",\n \t\t.format = formats::R12,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex fe027a7cce70..2d54d391ca01 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -138,6 +138,9 @@ formats:\n - R10_CSI2P:\n fourcc: DRM_FORMAT_R10\n mod: MIPI_FORMAT_MOD_CSI2_PACKED\n+ - R12_CSI2P:\n+ fourcc: DRM_FORMAT_R12\n+ mod: MIPI_FORMAT_MOD_CSI2_PACKED\n \n - SRGGB10_CSI2P:\n fourcc: DRM_FORMAT_SRGGB10\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 70568335b266..eb9ac2224fd1 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -139,6 +139,8 @@ const std::map vpf2pf{\n \t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n \t\t{ formats::R12, \"12-bit Greyscale\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12P),\n+\t\t{ formats::R12_CSI2P, \"12-bit Greyscale Packed\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y16),\n \t\t{ formats::R16, \"16-bit Greyscale\" } },\n \n","prefixes":["v1","1/2"]}