{"id":20812,"url":"https://patchwork.libcamera.org/api/patches/20812/?format=json","web_url":"https://patchwork.libcamera.org/patch/20812/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240807080344.12780-3-naush@raspberrypi.com>","date":"2024-08-07T08:03:44","name":"[v1,2/2] ipa: rpi: Adding IMX585 + IMX585-mono support","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"3e32ccbf98c9355a5eeffea875c719e89070d234","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20812/mbox/","series":[{"id":4492,"url":"https://patchwork.libcamera.org/api/series/4492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4492","date":"2024-08-07T08:03:42","name":"Raspberrypi: Add support for IMX585","version":1,"mbox":"https://patchwork.libcamera.org/series/4492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20812/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20812/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F76BC324E\n\tfor ;\n\tWed, 7 Aug 2024 08:03:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E510633B4;\n\tWed, 7 Aug 2024 10:03:47 +0200 (CEST)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3CD1633AC\n\tfor ;\n\tWed, 7 Aug 2024 10:03:43 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2f15e48f35bso14610181fa.0\n\tfor ;\n\tWed, 07 Aug 2024 01:03:43 -0700 (PDT)","from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-42905961e9dsm16403005e9.8.2024.08.07.01.03.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Aug 2024 01:03:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Unb7Z4BP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1723017823; x=1723622623;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=zNjKDE4OTLVxsHwtowMOBpxID0k5Y/yIVUCRhbZyvEg=;\n\tb=Unb7Z4BPFPwmAHqoclbd86qfCTfUs0/93TvgppHQ0xIzseq/d3TqFGsR7bwoI5JJ0U\n\tde6dqc8B3XNr/LKIG+NzSQrbBzM3Lqc22sdJajiD8vsutfFf97AxXfR9DstN0XHzye8w\n\tPOdIclcBIqYx00bRj8qJI97YahNZnwk2v0biiO1wOpn4IyfQ3d9kGKGERE/igSDEc9bS\n\tU38rVsGun1EOEbn4d8W1zCq19b/a3XbWNX9nFbVqZTLijsM7VzENaaBJQNZEcPFCVdlc\n\tSZC4MxBVE5iHTIWslnMH/vmwgTEoQBUopHBCR/yzaK91RQYUIo2dYl7ZhQhleP8Basjh\n\tg4Ow==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1723017823; x=1723622623;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=zNjKDE4OTLVxsHwtowMOBpxID0k5Y/yIVUCRhbZyvEg=;\n\tb=T0R9L/TWLcBqwBLxza++xreatm3NzsWmSau4cp+m5XIHDbl8DdsIUqnNkcfj+DHkMZ\n\tRAd08Ps97LT8gzdlKkD9hf6aw7q6/htCTfrWdyWJ1VSSPy3LCFq+QCbq5xmsCpUVXPu9\n\t6ZZU5Mr+RZVqJhXxvPT2EIHlOPcfzibjcb5gq6MVQ8imNDxxgzICuiiASp0EeXEV+Uu+\n\tFTD3OAPqEaLM7N4pejGFyGqii8ePAtCTAWqxFM/A47Ct3kxMxdMVJlqIqtJVTsUtGcU+\n\tzWq26r4wm1MdtPeUkYtY92VTKzJTb+pl+zJeZHSkrYPcLu4cu0uG2DFEF9D0MfDdGfMe\n\tjNtQ==","X-Gm-Message-State":"AOJu0YzpWZgAXtgrFRbnRZmjvp7y3btV0RyFC/oHu5Gh9wKv84JUkNGE\n\tnjWNftMeIc150SZY9MUkixTUGARaepeF3Sf1sGvRB5I0UqDlbcSaTbIinRttVcK8NnCKEEej/gx\n\tL","X-Google-Smtp-Source":"AGHT+IEjGtNELAuPc2fkByIbZi2VkUkxa2mnCbJrZwM4fKUjZQqHb9hh+mh6k1FbJG7TFOGB8+QrSg==","X-Received":"by 2002:a2e:91d0:0:b0:2ef:1c0f:d490 with SMTP id\n\t38308e7fff4ca-2f15ab0c2a1mr125068651fa.39.1723017822051; \n\tWed, 07 Aug 2024 01:03:42 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"will whang , Naushir Patuck ","Subject":"[PATCH v1 2/2] ipa: rpi: Adding IMX585 + IMX585-mono support","Date":"Wed, 7 Aug 2024 09:03:44 +0100","Message-Id":"<20240807080344.12780-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240807080344.12780-1-naush@raspberrypi.com>","References":"<20240807080344.12780-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: will whang \n\nAdd support for the IMX585 sensor - both colour and mono variants.\n\nSigned-off-by: will whang \nSigned-off-by: Naushir Patuck \nReviewed-by: Naushir Patuck \n---\n src/ipa/rpi/cam_helper/cam_helper_imx585.cpp | 75 +++++\n src/ipa/rpi/cam_helper/meson.build | 1 +\n src/ipa/rpi/vc4/data/imx585.json | 315 ++++++++++++++++++\n src/ipa/rpi/vc4/data/imx585_mono.json | 180 ++++++++++\n src/ipa/rpi/vc4/data/meson.build | 2 +\n .../sensor/camera_sensor_properties.cpp | 4 +\n 6 files changed, 577 insertions(+)\n create mode 100644 src/ipa/rpi/cam_helper/cam_helper_imx585.cpp\n create mode 100644 src/ipa/rpi/vc4/data/imx585.json\n create mode 100644 src/ipa/rpi/vc4/data/imx585_mono.json","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx585.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx585.cpp\nnew file mode 100644\nindex 000000000000..8efdb504c75b\n--- /dev/null\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx585.cpp\n@@ -0,0 +1,75 @@\n+/* SPDX-License-Identifier: BSD-2-Clause */\n+/*\n+ * Copyright (C) 2024, Raspberry Pi Ltd\n+ *\n+ * cam_helper_Imx585.cpp - camera information for Imx585 sensor\n+ */\n+\n+#include \n+#include \n+\n+#include \"cam_helper.h\"\n+\n+using namespace RPiController;\n+\n+class CamHelperImx585 : public CamHelper\n+{\n+public:\n+\tCamHelperImx585();\n+\tuint32_t gainCode(double gain) const override;\n+\tdouble gain(uint32_t gainCode) const override;\n+\tvoid getDelays(int &exposureDelay, int &gainDelay,\n+\t\t int &vblankDelay, int &hblankDelay) const override;\n+\tunsigned int hideFramesModeSwitch() const override;\n+\n+private:\n+\t/*\n+\t * Smallest difference between the frame length and integration time,\n+\t * in units of lines.\n+\t */\n+\tstatic constexpr int frameIntegrationDiff = 4;\n+};\n+\n+/*\n+ * Imx585 doesn't output metadata, so we have to use delayed controls which\n+ * works by counting frames.\n+ */\n+\n+CamHelperImx585::CamHelperImx585()\n+\t: CamHelper({}, frameIntegrationDiff)\n+{\n+}\n+\n+uint32_t CamHelperImx585::gainCode(double gain) const\n+{\n+\tint code = 66.6667 * log10(gain);\n+\treturn std::max(0, std::min(code, 0xf0));\n+}\n+\n+double CamHelperImx585::gain(uint32_t gainCode) const\n+{\n+\treturn pow(10, 0.015 * gainCode);\n+}\n+\n+void CamHelperImx585::getDelays(int &exposureDelay, int &gainDelay,\n+\t\t\t\tint &vblankDelay, int &hblankDelay) const\n+{\n+\t/* The driver appears to behave as follows: */\n+\texposureDelay = 2;\n+\tgainDelay = 2;\n+\tvblankDelay = 2;\n+\thblankDelay = 2;\n+}\n+\n+unsigned int CamHelperImx585::hideFramesModeSwitch() const\n+{\n+\t/* After a mode switch, we seem to get 1 bad frame. */\n+\treturn 1;\n+}\n+\n+static CamHelper *create()\n+{\n+\treturn new CamHelperImx585();\n+}\n+\n+static RegisterCamHelper reg(\"imx585\", &create);\ndiff --git a/src/ipa/rpi/cam_helper/meson.build b/src/ipa/rpi/cam_helper/meson.build\nindex 7262505742f3..369669397d46 100644\n--- a/src/ipa/rpi/cam_helper/meson.build\n+++ b/src/ipa/rpi/cam_helper/meson.build\n@@ -8,6 +8,7 @@ rpi_ipa_cam_helper_sources = files([\n 'cam_helper_imx296.cpp',\n 'cam_helper_imx477.cpp',\n 'cam_helper_imx519.cpp',\n+ 'cam_helper_imx585.cpp',\n 'cam_helper_imx708.cpp',\n 'cam_helper_ov64a40.cpp',\n 'cam_helper_ov9281.cpp',\ndiff --git a/src/ipa/rpi/vc4/data/imx585.json b/src/ipa/rpi/vc4/data/imx585.json\nnew file mode 100644\nindex 000000000000..be101389f699\n--- /dev/null\n+++ b/src/ipa/rpi/vc4/data/imx585.json\n@@ -0,0 +1,315 @@\n+{\n+ \"version\": 2.0,\n+ \"target\": \"bcm2835\",\n+ \"algorithms\": [\n+ {\n+ \"rpi.black_level\":\n+ {\n+ \"black_level\": 3200\n+ }\n+ },\n+ {\n+ \"rpi.dpc\": { }\n+ },\n+ {\n+ \"rpi.lux\":\n+ {\n+ \"reference_shutter_speed\": 6384,\n+ \"reference_gain\": 1.0,\n+ \"reference_aperture\": 1.0,\n+ \"reference_lux\": 935,\n+ \"reference_Y\": 11637\n+ }\n+ },\n+ {\n+ \"rpi.noise\":\n+ {\n+ \"reference_constant\": 12,\n+ \"reference_slope\": 3.568\n+ }\n+ },\n+ {\n+ \"rpi.geq\":\n+ {\n+ \"offset\": 192,\n+ \"slope\": 0.00812\n+ }\n+ },\n+ {\n+ \"rpi.sdn\": { }\n+ },\n+ {\n+ \"rpi.awb\":\n+ {\n+ \"priors\": [\n+ {\n+ \"lux\": 0,\n+ \"prior\":\n+ [\n+ 2000, 1.0,\n+ 3000, 0.0,\n+ 13000, 0.0\n+ ]\n+ },\n+ {\n+ \"lux\": 800,\n+ \"prior\":\n+ [\n+ 2000, 0.0,\n+ 6000, 2.0,\n+ 13000, 2.0\n+ ]\n+ },\n+ {\n+ \"lux\": 1500,\n+ \"prior\":\n+ [\n+ 2000, 0.0,\n+ 4000, 1.0,\n+ 6000, 6.0,\n+ 6500, 7.0,\n+ 7000, 1.0,\n+ 13000, 1.0\n+ ]\n+ }\n+ ],\n+ \"modes\":\n+ {\n+ \"auto\":\n+ {\n+ \"lo\": 2500,\n+ \"hi\": 8000\n+ },\n+ \"incandescent\":\n+ {\n+ \"lo\": 2500,\n+ \"hi\": 3000\n+ },\n+ \"tungsten\":\n+ {\n+ \"lo\": 3000,\n+ \"hi\": 3500\n+ },\n+ \"fluorescent\":\n+ {\n+ \"lo\": 4000,\n+ \"hi\": 4700\n+ },\n+ \"indoor\":\n+ {\n+ \"lo\": 3000,\n+ \"hi\": 5000\n+ },\n+ \"daylight\":\n+ {\n+ \"lo\": 5500,\n+ \"hi\": 6500\n+ }\n+ },\n+ \"bayes\": 1,\n+ \"ct_curve\":\n+ [\n+ 2187.0, 1.1114, 0.1026,\n+ 2258.0, 1.1063, 0.1147,\n+ 5225.0, 0.6631, 0.5507,\n+ 5289.0, 0.5769, 0.5731,\n+ 6532.0, 0.5259, 0.5801\n+ ],\n+ \"sensitivity_r\": 1.0,\n+ \"sensitivity_b\": 1.0,\n+ \"transverse_pos\": 0.13694,\n+ \"transverse_neg\": 0.08426\n+ }\n+ },\n+ {\n+ \"rpi.agc\":\n+ {\n+ \"metering_modes\":\n+ {\n+ \"centre-weighted\":\n+ {\n+ \"weights\":\n+ [\n+ 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n+ ]\n+ },\n+ \"spot\":\n+ {\n+ \"weights\":\n+ [\n+ 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n+ ]\n+ },\n+ \"matrix\":\n+ {\n+ \"weights\":\n+ [\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n+ ]\n+ }\n+ },\n+ \"exposure_modes\":\n+ {\n+ \"normal\":\n+ {\n+ \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ }\n+ },\n+ \"constraint_modes\":\n+ {\n+ \"normal\": [\n+ {\n+ \"bound\": \"LOWER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.5,\n+ 1000, 0.5\n+ ]\n+ }\n+ ],\n+ \"highlight\": [\n+ {\n+ \"bound\": \"LOWER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.5,\n+ 1000, 0.5\n+ ]\n+ },\n+ {\n+ \"bound\": \"UPPER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.8,\n+ 1000, 0.8\n+ ]\n+ }\n+ ]\n+ },\n+ \"y_target\":\n+ [\n+ 0, 0.16,\n+ 1000, 0.165,\n+ 10000, 0.17\n+ ]\n+ }\n+ },\n+ {\n+ \"rpi.alsc\":\n+ {\n+ \"omega\": 1.3,\n+ \"n_iter\": 100,\n+ \"luminance_strength\": 0.7\n+ }\n+ },\n+ {\n+ \"rpi.contrast\":\n+ {\n+ \"ce_enable\": 1,\n+ \"gamma_curve\":\n+ [\n+ 0, 0,\n+ 1024, 5040,\n+ 2048, 9338,\n+ 3072, 12356,\n+ 4096, 15312,\n+ 5120, 18051,\n+ 6144, 20790,\n+ 7168, 23193,\n+ 8192, 25744,\n+ 9216, 27942,\n+ 10240, 30035,\n+ 11264, 32005,\n+ 12288, 33975,\n+ 13312, 35815,\n+ 14336, 37600,\n+ 15360, 39168,\n+ 16384, 40642,\n+ 18432, 43379,\n+ 20480, 45749,\n+ 22528, 47753,\n+ 24576, 49621,\n+ 26624, 51253,\n+ 28672, 52698,\n+ 30720, 53796,\n+ 32768, 54876,\n+ 36864, 57012,\n+ 40960, 58656,\n+ 45056, 59954,\n+ 49152, 61183,\n+ 53248, 62355,\n+ 57344, 63419,\n+ 61440, 64476,\n+ 65535, 65535\n+ ]\n+ }\n+ },\n+ {\n+ \"rpi.ccm\":\n+ {\n+ \"ccms\": [\n+ {\n+ \"ct\": 2187,\n+ \"ccm\":\n+ [\n+ 1.91049, -0.78523, -0.12525,\n+ -0.69541, 1.68995, 0.00546,\n+ -0.47685, 0.89308, 0.58376\n+ ]\n+ },\n+ {\n+ \"ct\": 2258,\n+ \"ccm\":\n+ [\n+ 1.78809, -0.66968, -0.11841,\n+ -0.67083, 1.69256, -0.02173,\n+ -0.53371, 1.05827, 0.47545\n+ ]\n+ },\n+ {\n+ \"ct\": 5225,\n+ \"ccm\":\n+ [\n+ 1.41687, -0.26811, -0.14877,\n+ -0.37784, 1.28381, 0.09403,\n+ 0.04629, -0.42973, 1.38344\n+ ]\n+ },\n+ {\n+ \"ct\": 5289,\n+ \"ccm\":\n+ [\n+ 1.42939, -0.40792, -0.02147,\n+ -0.27719, 1.46177, -0.18458,\n+ 0.08958, -0.63362, 1.54404\n+ ]\n+ },\n+ {\n+ \"ct\": 6532,\n+ \"ccm\":\n+ [\n+ 1.46551, -0.24251, -0.22301,\n+ -0.42242, 1.64605, -0.22363,\n+ 0.02631, -0.42478, 1.39847\n+ ]\n+ }\n+ ]\n+ }\n+ },\n+ {\n+ \"rpi.sharpen\": { }\n+ }\n+ ]\n+}\n\\ No newline at end of file\ndiff --git a/src/ipa/rpi/vc4/data/imx585_mono.json b/src/ipa/rpi/vc4/data/imx585_mono.json\nnew file mode 100644\nindex 000000000000..956b4aeb390d\n--- /dev/null\n+++ b/src/ipa/rpi/vc4/data/imx585_mono.json\n@@ -0,0 +1,180 @@\n+{\n+ \"version\": 2.0,\n+ \"target\": \"bcm2835\",\n+ \"algorithms\": [\n+ {\n+ \"rpi.black_level\":\n+ {\n+ \"black_level\": 3200\n+ }\n+ },\n+ {\n+ \"rpi.dpc\": { }\n+ },\n+ {\n+ \"rpi.lux\":\n+ {\n+ \"reference_shutter_speed\": 6384,\n+ \"reference_gain\": 1.0,\n+ \"reference_aperture\": 1.0,\n+ \"reference_lux\": 935,\n+ \"reference_Y\": 11637\n+ }\n+ },\n+ {\n+ \"rpi.noise\":\n+ {\n+ \"reference_constant\": 12,\n+ \"reference_slope\": 3.568\n+ }\n+ },\n+ {\n+ \"rpi.geq\":\n+ {\n+ \"offset\": 192,\n+ \"slope\": 0.00812\n+ }\n+ },\n+ {\n+ \"rpi.sdn\": { }\n+ },\n+ {\n+ \"rpi.agc\":\n+ {\n+ \"metering_modes\":\n+ {\n+ \"centre-weighted\":\n+ {\n+ \"weights\":\n+ [\n+ 3, 3, 3, 2, 2, 2, 2, 1, 1, 1, 1, 0, 0, 0, 0\n+ ]\n+ },\n+ \"spot\":\n+ {\n+ \"weights\":\n+ [\n+ 2, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0\n+ ]\n+ },\n+ \"matrix\":\n+ {\n+ \"weights\":\n+ [\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n+ ]\n+ }\n+ },\n+ \"exposure_modes\":\n+ {\n+ \"normal\":\n+ {\n+ \"shutter\": [ 100, 10000, 30000, 60000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ },\n+ \"short\":\n+ {\n+ \"shutter\": [ 100, 5000, 10000, 20000, 120000 ],\n+ \"gain\": [ 1.0, 2.0, 4.0, 6.0, 6.0 ]\n+ }\n+ },\n+ \"constraint_modes\":\n+ {\n+ \"normal\": [\n+ {\n+ \"bound\": \"LOWER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.5,\n+ 1000, 0.5\n+ ]\n+ }\n+ ],\n+ \"highlight\": [\n+ {\n+ \"bound\": \"LOWER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.5,\n+ 1000, 0.5\n+ ]\n+ },\n+ {\n+ \"bound\": \"UPPER\",\n+ \"q_lo\": 0.98,\n+ \"q_hi\": 1.0,\n+ \"y_target\":\n+ [\n+ 0, 0.8,\n+ 1000, 0.8\n+ ]\n+ }\n+ ]\n+ },\n+ \"y_target\":\n+ [\n+ 0, 0.16,\n+ 1000, 0.165,\n+ 10000, 0.17\n+ ]\n+ }\n+ },\n+ {\n+ \"rpi.alsc\":\n+ {\n+ \"omega\": 1.3,\n+ \"n_iter\": 100,\n+ \"luminance_strength\": 0.7\n+ }\n+ },\n+ {\n+ \"rpi.contrast\":\n+ {\n+ \"ce_enable\": 1,\n+ \"gamma_curve\":\n+ [\n+ 0, 0,\n+ 1024, 5040,\n+ 2048, 9338,\n+ 3072, 12356,\n+ 4096, 15312,\n+ 5120, 18051,\n+ 6144, 20790,\n+ 7168, 23193,\n+ 8192, 25744,\n+ 9216, 27942,\n+ 10240, 30035,\n+ 11264, 32005,\n+ 12288, 33975,\n+ 13312, 35815,\n+ 14336, 37600,\n+ 15360, 39168,\n+ 16384, 40642,\n+ 18432, 43379,\n+ 20480, 45749,\n+ 22528, 47753,\n+ 24576, 49621,\n+ 26624, 51253,\n+ 28672, 52698,\n+ 30720, 53796,\n+ 32768, 54876,\n+ 36864, 57012,\n+ 40960, 58656,\n+ 45056, 59954,\n+ 49152, 61183,\n+ 53248, 62355,\n+ 57344, 63419,\n+ 61440, 64476,\n+ 65535, 65535\n+ ]\n+ }\n+ },\n+ {\n+ \"rpi.sharpen\": { }\n+ }\n+ ]\n+}\ndiff --git a/src/ipa/rpi/vc4/data/meson.build b/src/ipa/rpi/vc4/data/meson.build\nindex afbf875a113a..a3198b57c141 100644\n--- a/src/ipa/rpi/vc4/data/meson.build\n+++ b/src/ipa/rpi/vc4/data/meson.build\n@@ -11,6 +11,8 @@ conf_files = files([\n 'imx477_noir.json',\n 'imx477_scientific.json',\n 'imx519.json',\n+ 'imx585.json',\n+ 'imx585_mono.json',\n 'imx708.json',\n 'imx708_noir.json',\n 'imx708_wide.json',\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 4e5217ab51ef..86c8576e319c 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -148,6 +148,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"imx585\", {\n+\t\t\t.unitCellSize = { 2900, 2900 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx708\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n","prefixes":["v1","2/2"]}