[{"id":30612,"web_url":"https://patchwork.libcamera.org/comment/30612/","msgid":"","date":"2024-08-06T07:11:37","subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the patch. \n\nOn Mon, Aug 05, 2024 at 08:48:07PM +0300, Laurent Pinchart wrote:\n> The TrailersChecker enforces the presence of a Signed-off-by tag in the\n> trailer, but doesn't verify that the tag matches the commit's author.\n> Add that verification, as required by the libcamera contribution\n> process.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/checkstyle.py | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 1eeb3809f7fe..722b59920062 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -524,10 +524,11 @@ class TrailersChecker(CommitChecker):\n> continue\n> \n> if key == 'Signed-off-by':\n> - sob_found = True\n> + if value == commit.author:\n> + sob_found = True\n> \n> if not sob_found:\n> - issues.append(CommitIssue(f\"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst\"))\n> + issues.append(CommitIssue(f\"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst\"))\n\nI like long lines :-)\n\nReviewed-by: Stefan Klug \n\n> \n> return issues\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BCA6C323E\n\tfor ;\n\tTue, 6 Aug 2024 07:11:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18E6463393;\n\tTue, 6 Aug 2024 09:11:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DBF66337E\n\tfor ;\n\tTue, 6 Aug 2024 09:11:40 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7a68:2b6f:8265:aa72])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52C672C5;\n\tTue, 6 Aug 2024 09:10:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bTkBfJh0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722928248;\n\tbh=Zx2kGKc0EgIdG0VAz+l+suTUb0BYy9PPZtW+NHX7Nus=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bTkBfJh0oLHRAOPRkakrz5fKRrwUAMKnzuVDdLrLFI0D+kc/XON6qzmJ6WhcFO85r\n\tZDS3Y1ObD+gLmxAYfKhdwfUAbv+9asC2nl5ssSAKH4gzCmfVPXZ0yINE0bvPV27qC/\n\t01JKEC9GRaQSmeGnzQYohOkjjd9Sm6a5WnXw56WE=","Date":"Tue, 6 Aug 2024 09:11:37 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","Message-ID":"","References":"<20240805174807.10125-1-laurent.pinchart@ideasonboard.com>\n\t<20240805174807.10125-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240805174807.10125-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30615,"web_url":"https://patchwork.libcamera.org/comment/30615/","msgid":"<20240806074252.GC32045@pendragon.ideasonboard.com>","date":"2024-08-06T07:42:52","subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Aug 06, 2024 at 09:11:37AM +0200, Stefan Klug wrote:\n> Hi Laurent,\n> \n> Thank you for the patch. \n> \n> On Mon, Aug 05, 2024 at 08:48:07PM +0300, Laurent Pinchart wrote:\n> > The TrailersChecker enforces the presence of a Signed-off-by tag in the\n> > trailer, but doesn't verify that the tag matches the commit's author.\n> > Add that verification, as required by the libcamera contribution\n> > process.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > utils/checkstyle.py | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> > index 1eeb3809f7fe..722b59920062 100755\n> > --- a/utils/checkstyle.py\n> > +++ b/utils/checkstyle.py\n> > @@ -524,10 +524,11 @@ class TrailersChecker(CommitChecker):\n> > continue\n> > \n> > if key == 'Signed-off-by':\n> > - sob_found = True\n> > + if value == commit.author:\n> > + sob_found = True\n> > \n> > if not sob_found:\n> > - issues.append(CommitIssue(f\"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst\"))\n> > + issues.append(CommitIssue(f\"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst\"))\n> \n> I like long lines :-)\n\nI don't, but I also disliked cutting single line strings in the middle\nin code :-)\n\n> Reviewed-by: Stefan Klug \n> \n> > \n> > return issues\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C085CC323E\n\tfor ;\n\tTue, 6 Aug 2024 07:43:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEE6C63398;\n\tTue, 6 Aug 2024 09:43:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 472AF61955\n\tfor ;\n\tTue, 6 Aug 2024 09:43:15 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 116002C5;\n\tTue, 6 Aug 2024 09:42:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aTdER8Cm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722930143;\n\tbh=qe723r66KmtZdKLoVze1DMNf/RzopiIj327u+V8cVRw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aTdER8CmTWWyzXEaoqfK7SPV2hVoYvoaEDUOE/gvzpMaHhMt254WukTeIlYtiOHhk\n\tg2Txngya1ZusDnxmLIsy2gosRTYZwo4oooMk9WkXXYz+JKSjvqoEqpwsHpd9SdDZ9m\n\tF1P3aVbyaij0DB+TIGJQ2jMR6VnOsATAfnigK1Ms=","Date":"Tue, 6 Aug 2024 10:42:52 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","Message-ID":"<20240806074252.GC32045@pendragon.ideasonboard.com>","References":"<20240805174807.10125-1-laurent.pinchart@ideasonboard.com>\n\t<20240805174807.10125-2-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30624,"web_url":"https://patchwork.libcamera.org/comment/30624/","msgid":"<172293517291.372468.5041828863119978810@ping.linuxembedded.co.uk>","date":"2024-08-06T09:06:12","subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 18:48:07)\n> The TrailersChecker enforces the presence of a Signed-off-by tag in the\n> trailer, but doesn't verify that the tag matches the commit's author.\n> Add that verification, as required by the libcamera contribution\n> process.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/checkstyle.py | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 1eeb3809f7fe..722b59920062 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -524,10 +524,11 @@ class TrailersChecker(CommitChecker):\n> continue\n> \n> if key == 'Signed-off-by':\n> - sob_found = True\n> + if value == commit.author:\n> + sob_found = True\n> \n> if not sob_found:\n> - issues.append(CommitIssue(f\"No valid 'Signed-off-by' trailer found, see Documentation/contributing.rst\"))\n> + issues.append(CommitIssue(f\"No 'Signed-off-by' trailer matching author '{commit.author}', see Documentation/contributing.rst\"))\n> \n\nThat's what I was expecting ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> return issues\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 726B6C323E\n\tfor ;\n\tTue, 6 Aug 2024 09:06:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98F3D63393;\n\tTue, 6 Aug 2024 11:06:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C24C6337E\n\tfor ;\n\tTue, 6 Aug 2024 11:06:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C7B72C5;\n\tTue, 6 Aug 2024 11:05:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NPtvJOAO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722935124;\n\tbh=nTFCTF0xCx7HzIxLtfh2IUil9uumudCMkr82MVpAGZQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=NPtvJOAO2dH6fJBhsjN1v2yRCd+DqODIMVLiNE49YXAIj7xorykw0Rb1EEGR+6cxj\n\tRE7vKMVfQc/d9vuev+g+62sUt6aoTmr/qBf15uWWvexqxaN2lnm/M0v6AkX2uz1ohr\n\tY7Fl8urp8d6N49EoSy2ha5X93+nLyhSIlKuj3Btw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805174807.10125-2-laurent.pinchart@ideasonboard.com>","References":"<20240805174807.10125-1-laurent.pinchart@ideasonboard.com>\n\t<20240805174807.10125-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 2/2] utils: checkstyle.py: Validate SoB trailer against\n\tauthor","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 06 Aug 2024 10:06:12 +0100","Message-ID":"<172293517291.372468.5041828863119978810@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]