[{"id":30669,"web_url":"https://patchwork.libcamera.org/comment/30669/","msgid":"<172303056217.1687952.17761293598680930636@ping.linuxembedded.co.uk>","date":"2024-08-07T11:36:02","subject":"Re: [PATCH v5 18/18] libcamera: camera: Hide Camera::create() from\n\tthe public API","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 15:36:54)\n> The Camera::create() function is internal. Hide it from the public API\n> documentation.\n\nFine with me but could also be merged with 04/18.\nIn fact, that already touches libcamera/camera.cpp!\n\nAnyway, if it gets it done:\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/camera.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index aca466c9ba72..382a68f7bddd 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -821,6 +821,7 @@ void Camera::Private::setState(State state)\n> */\n> \n> /**\n> + * \\internal\n> * \\brief Create a camera instance\n> * \\param[in] d Camera private data\n> * \\param[in] id The ID of the camera device\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33771BE173\n\tfor ;\n\tWed, 7 Aug 2024 11:36:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67CAB6338D;\n\tWed, 7 Aug 2024 13:36:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA42D63382\n\tfor ;\n\tWed, 7 Aug 2024 13:36:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DCC156AF;\n\tWed, 7 Aug 2024 13:35:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WcEpyBLb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723030512;\n\tbh=fGQxKKdIpOIMJJmvN3gPc5H1EFKGGyDoVhRUQLbb9OA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=WcEpyBLbqWXs7EzTUnl5Ez5IgFbF9gupyrg++P2zskbTv8hnNnEJSnlE7rJM7vxZ/\n\tDjelGHIuLd567lUBhD8sCTP8MJooqEWYDR+oac6Ru85Yh+M9xzpMaz40quKSRGt74t\n\tUOl1Y8Jv5SXtFngbhu0Z+4vXsL9M16rzRRkYwHqg=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805143654.20870-19-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-19-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v5 18/18] libcamera: camera: Hide Camera::create() from\n\tthe public API","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Aug 2024 12:36:02 +0100","Message-ID":"<172303056217.1687952.17761293598680930636@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30685,"web_url":"https://patchwork.libcamera.org/comment/30685/","msgid":"<20240807135305.GB18866@pendragon.ideasonboard.com>","date":"2024-08-07T13:53:05","subject":"Re: [PATCH v5 18/18] libcamera: camera: Hide Camera::create() from\n\tthe public API","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Aug 07, 2024 at 12:36:02PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-08-05 15:36:54)\n> > The Camera::create() function is internal. Hide it from the public API\n> > documentation.\n> \n> Fine with me but could also be merged with 04/18.\n> In fact, that already touches libcamera/camera.cpp!\n\nI've kept it separate to highlight the fact that we have internal\nfunctions exposed as public members of public classes, and that we\nshould go through the public classes to mark such members as internal.\nAnd then I forgot to mention it in the cover letter :-)\n\n> Anyway, if it gets it done:\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/camera.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> > \n> > diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> > index aca466c9ba72..382a68f7bddd 100644\n> > --- a/src/libcamera/camera.cpp\n> > +++ b/src/libcamera/camera.cpp\n> > @@ -821,6 +821,7 @@ void Camera::Private::setState(State state)\n> > */\n> > \n> > /**\n> > + * \\internal\n> > * \\brief Create a camera instance\n> > * \\param[in] d Camera private data\n> > * \\param[in] id The ID of the camera device","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E695BE173\n\tfor ;\n\tWed, 7 Aug 2024 13:53:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D079863382;\n\tWed, 7 Aug 2024 15:53:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 67A4F6337F\n\tfor ;\n\tWed, 7 Aug 2024 15:53:28 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 556286AF;\n\tWed, 7 Aug 2024 15:52:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FVtcU4KH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723038755;\n\tbh=A5GuB/ay/CcQMJNJdtrIHvsmBflY43x6JRguHLP0Xhg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FVtcU4KHbpQmO8shgsIp5meViv9HIvDiwccCeK6Cyn7vgTDUuW2p7LMONDZbOP9Qb\n\tl4CfD/FIs38zrXYs8as8++clCdjEHKgWVsD6n7dgfUA99BWJUZ7aLZre3VuERSAP1N\n\t64I6w67frcF1GjvRp9P23Gm3amQAqEQzP1wZUUkc=","Date":"Wed, 7 Aug 2024 16:53:05 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 18/18] libcamera: camera: Hide Camera::create() from\n\tthe public API","Message-ID":"<20240807135305.GB18866@pendragon.ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-19-laurent.pinchart@ideasonboard.com>\n\t<172303056217.1687952.17761293598680930636@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172303056217.1687952.17761293598680930636@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]