[{"id":30649,"web_url":"https://patchwork.libcamera.org/comment/30649/","msgid":"","date":"2024-08-07T08:44:53","subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Laurent\n\nOn 05/08/2024 15:36, Laurent Pinchart wrote:\n> The libcamera_tracepoint_header variable stores the tracepoints.h header\n> custom target, for the sole purpose of being listed as a source of the\n> libcamera shared library, through the libcamera_internal_sources\n> variable.\n>\n> Add the tracepoints.h header to libcamera_internal_headers instead of\n> libcamera_internal_sources, and list libcamera_internal_headers as a\n> source of the shared library, alongside libcamera_internal_sources. This\n> makes libcamera_internal_sources contain sources only, improving clarity\n> of the build system variables.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\nMakes sense to me: Reviewed-by: Daniel Scally \n> include/libcamera/internal/meson.build | 16 +++++++++-------\n> src/libcamera/meson.build | 2 +-\n> 2 files changed, 10 insertions(+), 8 deletions(-)\n>\n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index f96cc5e37c23..39230facc8a4 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -2,13 +2,6 @@\n> \n> subdir('tracepoints')\n> \n> -libcamera_tracepoint_header = custom_target(\n> - 'tp_header',\n> - input : ['tracepoints.h.in', tracepoint_files],\n> - output : 'tracepoints.h',\n> - command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> -)\n> -\n> libcamera_internal_headers = files([\n> 'bayer_format.h',\n> 'byte_stream_buffer.h',\n> @@ -51,5 +44,14 @@ libcamera_internal_headers = files([\n> 'yaml_parser.h',\n> ])\n> \n> +tracepoints_h = custom_target(\n> + 'tp_header',\n> + input : ['tracepoints.h.in', tracepoint_files],\n> + output : 'tracepoints.h',\n> + command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> +)\n> +\n> +libcamera_internal_headers += tracepoints_h\n> +\n> subdir('converter')\n> subdir('software_isp')\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 86e8b88cc1b2..6a7c9d77dfd8 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n> ])\n> \n> libcamera_public_sources += libcamera_public_headers\n> -libcamera_internal_sources += libcamera_tracepoint_header\n> \n> includes = [\n> libcamera_includes,\n> @@ -196,6 +195,7 @@ libcamera = shared_library('libcamera',\n> [\n> libcamera_public_sources,\n> libcamera_ipa_headers,\n> + libcamera_internal_headers,\n> libcamera_internal_sources,\n> ],\n> version : libcamera_version,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7B1ABC323E\n\tfor ;\n\tWed, 7 Aug 2024 08:44:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78DE66338D;\n\tWed, 7 Aug 2024 10:44:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 569CF63382\n\tfor ;\n\tWed, 7 Aug 2024 10:44:56 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 944216AF\n\tfor ;\n\tWed, 7 Aug 2024 10:44:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jSkaPORN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723020243;\n\tbh=L1jTHyBuSX1jkogZQZoveFXhPwDEeuQAtqW9Q35DtUU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=jSkaPORNTvfqV1hI2uXnvyF141rZvJVVMDkXi+gdqX+UXB6j8HGHMAduFq3mqxJ0g\n\tmBNnIklxImq3kPCh2IiZmEWcX7K3rsJ0TSIRYxDX/dV+G8HclkGy5yPV3KKFlurxwQ\n\tgw4ipJFIbH0EqTlNubOrikdhPtoyrx4XG+0aGWxA=","Message-ID":"","Date":"Wed, 7 Aug 2024 09:44:53 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","To":"libcamera-devel@lists.libcamera.org","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-13-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240805143654.20870-13-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30666,"web_url":"https://patchwork.libcamera.org/comment/30666/","msgid":"<172302955758.1687952.4954692080622832052@ping.linuxembedded.co.uk>","date":"2024-08-07T11:19:17","subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-08-05 15:36:48)\n> The libcamera_tracepoint_header variable stores the tracepoints.h header\n> custom target, for the sole purpose of being listed as a source of the\n> libcamera shared library, through the libcamera_internal_sources\n> variable.\n> \n> Add the tracepoints.h header to libcamera_internal_headers instead of\n> libcamera_internal_sources, and list libcamera_internal_headers as a\n> source of the shared library, alongside libcamera_internal_sources. This\n> makes libcamera_internal_sources contain sources only, improving clarity\n> of the build system variables.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> include/libcamera/internal/meson.build | 16 +++++++++-------\n> src/libcamera/meson.build | 2 +-\n> 2 files changed, 10 insertions(+), 8 deletions(-)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index f96cc5e37c23..39230facc8a4 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -2,13 +2,6 @@\n> \n> subdir('tracepoints')\n> \n> -libcamera_tracepoint_header = custom_target(\n> - 'tp_header',\n> - input : ['tracepoints.h.in', tracepoint_files],\n> - output : 'tracepoints.h',\n> - command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> -)\n> -\n> libcamera_internal_headers = files([\n> 'bayer_format.h',\n> 'byte_stream_buffer.h',\n> @@ -51,5 +44,14 @@ libcamera_internal_headers = files([\n> 'yaml_parser.h',\n> ])\n> \n> +tracepoints_h = custom_target(\n> + 'tp_header',\n> + input : ['tracepoints.h.in', tracepoint_files],\n> + output : 'tracepoints.h',\n> + command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> +)\n> +\n> +libcamera_internal_headers += tracepoints_h\n> +\n> subdir('converter')\n> subdir('software_isp')\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 86e8b88cc1b2..6a7c9d77dfd8 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n> ])\n> \n> libcamera_public_sources += libcamera_public_headers\n> -libcamera_internal_sources += libcamera_tracepoint_header\n> \n> includes = [\n> libcamera_includes,\n> @@ -196,6 +195,7 @@ libcamera = shared_library('libcamera',\n> [\n> libcamera_public_sources,\n> libcamera_ipa_headers,\n> + libcamera_internal_headers,\n\nI think this brings in a set of the headers as dependencies now (a good\nthing). I wonder if this is where we had that 'breakage requiring a full\nclean rebuild' around v0.2.0 or v0.1.0 or such.\n\nAnyway, it looks like a good thing to me.\n\n\nReviewed-by: Kieran Bingham \n\n> libcamera_internal_sources,\n> ],\n> version : libcamera_version,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FB1FBE173\n\tfor ;\n\tWed, 7 Aug 2024 11:19:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2A9B63382;\n\tWed, 7 Aug 2024 13:19:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E59E6337F\n\tfor ;\n\tWed, 7 Aug 2024 13:19:20 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15CA66AF;\n\tWed, 7 Aug 2024 13:18:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"frwg7wxA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723029508;\n\tbh=tfjN5KkWnxo4Sbr16L1U1qPIL/psZgR7VeKEWUXVkTE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=frwg7wxA4oqobXnv9FStwaMLet/84QTranaOfRq3GDL0C310ugeUhufJsHe5Lx1Oy\n\ttkmwwTonGBNama26Zk45iwKJs+Rrb1ef28W2LXdgb/AuI20c/KqpclWt0D2eWSn8rv\n\tYuSE5pu+CV40leSWuLeaS/CCei7ZQIsVBgOqszmM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240805143654.20870-13-laurent.pinchart@ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-13-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Aug 2024 12:19:17 +0100","Message-ID":"<172302955758.1687952.4954692080622832052@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":30677,"web_url":"https://patchwork.libcamera.org/comment/30677/","msgid":"<20240807130921.GF15173@pendragon.ideasonboard.com>","date":"2024-08-07T13:09:21","subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Aug 07, 2024 at 12:19:17PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart (2024-08-05 15:36:48)\n> > The libcamera_tracepoint_header variable stores the tracepoints.h header\n> > custom target, for the sole purpose of being listed as a source of the\n> > libcamera shared library, through the libcamera_internal_sources\n> > variable.\n> > \n> > Add the tracepoints.h header to libcamera_internal_headers instead of\n> > libcamera_internal_sources, and list libcamera_internal_headers as a\n> > source of the shared library, alongside libcamera_internal_sources. This\n> > makes libcamera_internal_sources contain sources only, improving clarity\n> > of the build system variables.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > include/libcamera/internal/meson.build | 16 +++++++++-------\n> > src/libcamera/meson.build | 2 +-\n> > 2 files changed, 10 insertions(+), 8 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> > index f96cc5e37c23..39230facc8a4 100644\n> > --- a/include/libcamera/internal/meson.build\n> > +++ b/include/libcamera/internal/meson.build\n> > @@ -2,13 +2,6 @@\n> > \n> > subdir('tracepoints')\n> > \n> > -libcamera_tracepoint_header = custom_target(\n> > - 'tp_header',\n> > - input : ['tracepoints.h.in', tracepoint_files],\n> > - output : 'tracepoints.h',\n> > - command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> > -)\n> > -\n> > libcamera_internal_headers = files([\n> > 'bayer_format.h',\n> > 'byte_stream_buffer.h',\n> > @@ -51,5 +44,14 @@ libcamera_internal_headers = files([\n> > 'yaml_parser.h',\n> > ])\n> > \n> > +tracepoints_h = custom_target(\n> > + 'tp_header',\n> > + input : ['tracepoints.h.in', tracepoint_files],\n> > + output : 'tracepoints.h',\n> > + command : [gen_tracepoints_header, include_build_dir, '@OUTPUT@', '@INPUT@'],\n> > +)\n> > +\n> > +libcamera_internal_headers += tracepoints_h\n> > +\n> > subdir('converter')\n> > subdir('software_isp')\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index 86e8b88cc1b2..6a7c9d77dfd8 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -55,7 +55,6 @@ libcamera_internal_sources = files([\n> > ])\n> > \n> > libcamera_public_sources += libcamera_public_headers\n> > -libcamera_internal_sources += libcamera_tracepoint_header\n> > \n> > includes = [\n> > libcamera_includes,\n> > @@ -196,6 +195,7 @@ libcamera = shared_library('libcamera',\n> > [\n> > libcamera_public_sources,\n> > libcamera_ipa_headers,\n> > + libcamera_internal_headers,\n> \n> I think this brings in a set of the headers as dependencies now (a good\n> thing). I wonder if this is where we had that 'breakage requiring a full\n> clean rebuild' around v0.2.0 or v0.1.0 or such.\n\nI don't think it will make a difference in practice. Meson handles\ndependencies on static header automatically. If a static header changes,\nthe source files that include it (directly or indirectly) will be\nrecompiled, and so libcamera will be relinked. Adding the static headers\nto the sources here shouldn't change anything.\n\nThe problems we encountered a while ago were due to missing dependencies\non generated files if I recall correctly.\n\n> Anyway, it looks like a good thing to me.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > libcamera_internal_sources,\n> > ],\n> > version : libcamera_version,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1EE91C323E\n\tfor ;\n\tWed, 7 Aug 2024 13:09:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DC5363393;\n\tWed, 7 Aug 2024 15:09:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7578F6337F\n\tfor ;\n\tWed, 7 Aug 2024 15:09:44 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 718FE6AF;\n\tWed, 7 Aug 2024 15:08:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HxOp0FZP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1723036131;\n\tbh=vvlHDgfO/iT582qk/3875B3AFjZBdK1tvQRdZuOsILQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HxOp0FZPMSbq8TYvb2h1fB1C/gKsUHz34I51+xjzuhQO/57/whLd97DC7KXeBJMpJ\n\t2YtQEiVFwV4tKJRtLfiL0jbIX5OgTlDNkGFE65GzlSg4y74mi5NcdBSwIyH5oW9oup\n\tCiicdgfo5UthgbzUPiAmo6wDBcnAQ4uY7CLELiQI=","Date":"Wed, 7 Aug 2024 16:09:21 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v5 12/18] libcamera: Consolidate tracepoint header in\n\tlibcamera_internal_headers","Message-ID":"<20240807130921.GF15173@pendragon.ideasonboard.com>","References":"<20240805143654.20870-1-laurent.pinchart@ideasonboard.com>\n\t<20240805143654.20870-13-laurent.pinchart@ideasonboard.com>\n\t<172302955758.1687952.4954692080622832052@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<172302955758.1687952.4954692080622832052@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]